You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2019/12/28 07:25:22 UTC

[kudu-CR] [util] fix compilation warnings in RELEASE mode 

Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14956


Change subject: [util] fix compilation warnings in RELEASE mode
......................................................................

[util] fix compilation warnings in RELEASE mode

Prior to this fix, compiling in RELEASE mode with 3rd-party clang would
output warning messages like below:

  src/kudu/util/block_bloom_filter.cc:171:18: \
      warning: expression result unused [-Wunused-value]
      DCHECK_NOTNULL(directory_);

This patch addresses that, placing the DCHECK_NOTNULL() macro
into expressions which use directory_ member field.

Change-Id: Ia059413ad2962a22a32ab92773a2d6871809830a
---
M src/kudu/util/block_bloom_filter.cc
1 file changed, 4 insertions(+), 6 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/56/14956/1
-- 
To view, visit http://gerrit.cloudera.org:8080/14956
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia059413ad2962a22a32ab92773a2d6871809830a
Gerrit-Change-Number: 14956
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>

[kudu-CR] [util] fix compilation warnings in RELEASE mode

Posted by "Bankim Bhavsar (Code Review)" <ge...@cloudera.org>.
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14956 )

Change subject: [util] fix compilation warnings in RELEASE mode
......................................................................


Patch Set 1: Code-Review+1

Fixes the warnings but hampers readability IMO.


-- 
To view, visit http://gerrit.cloudera.org:8080/14956
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia059413ad2962a22a32ab92773a2d6871809830a
Gerrit-Change-Number: 14956
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sat, 28 Dec 2019 14:58:27 +0000
Gerrit-HasComments: No

[kudu-CR] [util] fix compilation warnings in RELEASE mode

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14956 )

Change subject: [util] fix compilation warnings in RELEASE mode
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/14956
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia059413ad2962a22a32ab92773a2d6871809830a
Gerrit-Change-Number: 14956
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sun, 29 Dec 2019 18:36:42 +0000
Gerrit-HasComments: No

[kudu-CR] [util] fix compilation warnings in RELEASE mode

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14956 )

Change subject: [util] fix compilation warnings in RELEASE mode
......................................................................

[util] fix compilation warnings in RELEASE mode

Prior to this fix, compiling in RELEASE mode with 3rd-party clang would
output warning messages like below:

  src/kudu/util/block_bloom_filter.cc:171:18: \
      warning: expression result unused [-Wunused-value]
      DCHECK_NOTNULL(directory_);

This patch addresses that, placing the DCHECK_NOTNULL() macro
into expressions which use directory_ member field.

Change-Id: Ia059413ad2962a22a32ab92773a2d6871809830a
Reviewed-on: http://gerrit.cloudera.org:8080/14956
Tested-by: Kudu Jenkins
Reviewed-by: Bankim Bhavsar <ba...@cloudera.com>
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
M src/kudu/util/block_bloom_filter.cc
1 file changed, 4 insertions(+), 6 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  Bankim Bhavsar: Looks good to me, but someone else must approve
  Adar Dembo: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/14956
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia059413ad2962a22a32ab92773a2d6871809830a
Gerrit-Change-Number: 14956
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)