mod_proxy hides X-Cache header from upstream server in 1.3.23

["Rief, Jacob" <Ja...@Tiscover.com>]

Hello Grahamm,
from the ChangeLog this seems to be your modification
in the latest version of Apache.

Unfortunately mod_proxy hides the X-Cache header
send by an upstream server.
This is s new behaviour not seen in any earlier version of
Apache.
I understand, that its nice to have a headers in order
to determine whether an object was delivered by Apache's
own cache or not, ie. sending a X-Cache: MISS/HIT header.
However I use another caching-system (Squid) behind 
the Apache, which itself sets or adds such headers.
Since version 1.3.23 the squid X-Cache headers never
reaches my client. One solution would be to disable
the generation and hiding of the upstream X-Cache header
if the 'NoCache' directive was set.
Another would be to add the header instead of replacing it
(this is the way a squid-cluster handles the X-cache header).

BTW, I use mod_proxy through the [P] directive in mod_rewrite,
not through the ProxyPass directive.

Best regards,
Jacob 

Re: mod_proxy hides X-Cache header from upstream server in 1.3.23

[Graham Leggett <mi...@sharp.fm>]

"Rief, Jacob" wrote:

> Unfortunately mod_proxy hides the X-Cache header
> send by an upstream server.
> This is s new behaviour not seen in any earlier version of
> Apache.

Apache was ap_table_set()'ing the header instead of ap_table_merge()'ing
the header - which meant any previous upstream value was overwritten and
lost.

I have just committed a fix to the apache 1.3.24-dev tree. Can you check
it out, give it a try and tell me if your problem is fixed?

Regards,
Graham
-- 
-----------------------------------------
minfrin@sharp.fm		"There's a moon
					over Bourbon Street
						tonight..."