You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cassandra.apache.org by Michael Shuler <mi...@pbandjelly.org> on 2019/07/08 17:53:07 UTC

Request for review - 2 jiras for 3.0/3.11

Resending as a new req-for-review thread for visibility, since they look 
important to my untrained eye:

https://issues.apache.org/jira/browse/CASSANDRA-15097
https://issues.apache.org/jira/browse/CASSANDRA-15098

Michael

-------- Forwarded Message --------
Subject: Re: Time for a new 3.0/3.11 release?
Date: Wed, 3 Jul 2019 10:38:38 -0700
From: Jay Zhuang <jz...@apache.org>
Reply-To: dev@cassandra.apache.org
To: dev@cassandra.apache.org

I'd like to raise some attention for the following 2 tickets, they're
patch-ready and deployed on all our production clusters:
* CASSANDRA-15098: "Endpoints no longer owning tokens are not removed for
vnode"
   For vNode cluster, the replaced node may not be removed from gossiper
(and system.peers, every time a node restart, they will be re-populated
into gossiper from system.peers). The patch is pretty small and
straightforward.
* CASSANDRA-15097: "Avoid updating unchanged gossip state"
   I think this is a bug because it's not only causing large pending gossip
tasks, it's also causing long token-metadata update lock for large vNode
cluster.

Here is another improvement we made for vNode to avoid gossip block during
removeNode: CASSANDRA-15141. But I think it can wait until 4.x. It mostly
causes problem for 1000+ vNode clusters.

Thanks,
Jay

On Tue, Jul 2, 2019 at 10:28 PM Mick Semb Wever <mc...@apache.org> wrote:

>
>
> > Is there any chance to get CASSANDRA-15005 (ready, with PR) into a
> > 3.11.5 release?
>
>
> I doubt it Soroka. It's not a bug and there's no patch for it, so I'd see
> no reason why Michael would wait for this when he generously finds time to
> cut a release.
>
> Maybe the author and reviewer decides to push it to both 3.11.x and 4.0,
> but that's irrelevant to this thread.
>
> regards,
> Mick
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@cassandra.apache.org
> For additional commands, e-mail: dev-help@cassandra.apache.org
>
>


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cassandra.apache.org
For additional commands, e-mail: dev-help@cassandra.apache.org

Re: Request for review - 2 jiras for 3.0/3.11

Posted by Dinesh Joshi <dj...@apache.org>.
I can help review these Jiras. However, they are touching the gossip subsystem and would recommend someone more familiar with that part of the code to do a 2nd pass before we commit it.

Thanks,

Dinesh

> On Jul 8, 2019, at 10:53 AM, Michael Shuler <mi...@pbandjelly.org> wrote:
> 
> Resending as a new req-for-review thread for visibility, since they look important to my untrained eye:
> 
> https://issues.apache.org/jira/browse/CASSANDRA-15097
> https://issues.apache.org/jira/browse/CASSANDRA-15098
> 
> Michael
> 
> -------- Forwarded Message --------
> Subject: Re: Time for a new 3.0/3.11 release?
> Date: Wed, 3 Jul 2019 10:38:38 -0700
> From: Jay Zhuang <jz...@apache.org>
> Reply-To: dev@cassandra.apache.org
> To: dev@cassandra.apache.org
> 
> I'd like to raise some attention for the following 2 tickets, they're
> patch-ready and deployed on all our production clusters:
> * CASSANDRA-15098: "Endpoints no longer owning tokens are not removed for
> vnode"
>  For vNode cluster, the replaced node may not be removed from gossiper
> (and system.peers, every time a node restart, they will be re-populated
> into gossiper from system.peers). The patch is pretty small and
> straightforward.
> * CASSANDRA-15097: "Avoid updating unchanged gossip state"
>  I think this is a bug because it's not only causing large pending gossip
> tasks, it's also causing long token-metadata update lock for large vNode
> cluster.
> 
> Here is another improvement we made for vNode to avoid gossip block during
> removeNode: CASSANDRA-15141. But I think it can wait until 4.x. It mostly
> causes problem for 1000+ vNode clusters.
> 
> Thanks,
> Jay
> 
> On Tue, Jul 2, 2019 at 10:28 PM Mick Semb Wever <mc...@apache.org> wrote:
> 
>> 
>> 
>> > Is there any chance to get CASSANDRA-15005 (ready, with PR) into a
>> > 3.11.5 release?
>> 
>> 
>> I doubt it Soroka. It's not a bug and there's no patch for it, so I'd see
>> no reason why Michael would wait for this when he generously finds time to
>> cut a release.
>> 
>> Maybe the author and reviewer decides to push it to both 3.11.x and 4.0,
>> but that's irrelevant to this thread.
>> 
>> regards,
>> Mick
>> 
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@cassandra.apache.org
>> For additional commands, e-mail: dev-help@cassandra.apache.org
>> 
>> 
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@cassandra.apache.org
> For additional commands, e-mail: dev-help@cassandra.apache.org
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cassandra.apache.org
For additional commands, e-mail: dev-help@cassandra.apache.org