You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by revans2 <gi...@git.apache.org> on 2017/11/13 21:21:48 UTC
[GitHub] storm pull request #2417: STORM-2809: Always create the resources directory ...
GitHub user revans2 opened a pull request:
https://github.com/apache/storm/pull/2417
STORM-2809: Always create the resources directory so we can check for it
The issue was actually a few lines below this. In the isFullyDownloaded function. It would check if we wanted to extract things, like with the resources jar, that the destination directory existed. But that directory would only be created if there was something to extract. Some topology jars didn't have anything to extract so the directory would never be created and the worker would be relaunched every 30 seconds.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/revans2/incubator-storm STORM-2809
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/2417.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2417
----
commit 6bc873cd23ecc4d20758afca322f44f6a3713e8c
Author: Robert (Bobby) Evans <ev...@yahoo-inc.com>
Date: 2017-11-13T21:18:42Z
STORM-2809: Always create the resources directory so we can check for it
----
---
[GitHub] storm issue #2417: STORM-2809: Always create the resources directory so we c...
Posted by srdo <gi...@git.apache.org>.
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2417
Thanks for looking into this. I'll try running the integration test locally on it a number of times tomorrow.
---
[GitHub] storm issue #2417: STORM-2809: Always create the resources directory so we c...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2417
First trial starts here: https://travis-ci.org/HeartSaVioR/storm/builds/301792774
---
[GitHub] storm issue #2417: STORM-2809: Always create the resources directory so we c...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2417
I'm also running the build in my fork. Will run several times and see it's good.
Btw, Stig stated that integration test was failing consistently, then successful result of build in this PR may indicate the patch will resolve the integration test.
---
[GitHub] storm issue #2417: STORM-2809: Always create the resources directory so we c...
Posted by srdo <gi...@git.apache.org>.
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2417
+1.
Ran the integration tests 15 times locally, and 5 failed because the worker didn't start. It looks unrelated to both this and https://github.com/apache/storm/pull/2363. Will try enabling more logs to see if I can figure out what's happening.
---
[GitHub] storm issue #2417: STORM-2809: Always create the resources directory so we c...
Posted by srdo <gi...@git.apache.org>.
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2417
Thanks @revans2, merged to master.
---
[GitHub] storm pull request #2417: STORM-2809: Always create the resources directory ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2417
---
[GitHub] storm issue #2417: STORM-2809: Always create the resources directory so we c...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2417
I've ran integration tests in Travis 3 times and all succeeded.
---