You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by al...@apache.org on 2016/08/26 14:22:52 UTC
cordova-plugin-media git commit: CB-11380 (ios) Updated modified
method signature in the .h file
Repository: cordova-plugin-media
Updated Branches:
refs/heads/master 910d3c798 -> 42b279b91
CB-11380 (ios) Updated modified method signature in the .h file
Project: http://git-wip-us.apache.org/repos/asf/cordova-plugin-media/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-plugin-media/commit/42b279b9
Tree: http://git-wip-us.apache.org/repos/asf/cordova-plugin-media/tree/42b279b9
Diff: http://git-wip-us.apache.org/repos/asf/cordova-plugin-media/diff/42b279b9
Branch: refs/heads/master
Commit: 42b279b911c4b20689290f55ecb849905d3f1673
Parents: 910d3c7
Author: Alexander Sorokin <al...@akvelon.com>
Authored: Fri Aug 26 17:06:07 2016 +0300
Committer: Alexander Sorokin <al...@akvelon.com>
Committed: Fri Aug 26 17:06:07 2016 +0300
----------------------------------------------------------------------
src/ios/CDVSound.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/cordova-plugin-media/blob/42b279b9/src/ios/CDVSound.h
----------------------------------------------------------------------
diff --git a/src/ios/CDVSound.h b/src/ios/CDVSound.h
index 1dca574..c3f7a6c 100644
--- a/src/ios/CDVSound.h
+++ b/src/ios/CDVSound.h
@@ -106,7 +106,7 @@ typedef NSUInteger CDVMediaMsg;
- (NSURL*)urlForRecording:(NSString*)resourcePath;
- (NSURL*)urlForPlaying:(NSString*)resourcePath;
-- (CDVAudioFile*)audioFileForResource:(NSString*)resourcePath withId:(NSString*)mediaId doValidation:(BOOL)bValidate forRecording:(BOOL)bRecord;
+- (CDVAudioFile*)audioFileForResource:(NSString*)resourcePath withId:(NSString*)mediaId doValidation:(BOOL)bValidate forRecording:(BOOL)bRecord suppressValidationErrors:(BOOL)bSuppress;
- (BOOL)prepareToPlay:(CDVAudioFile*)audioFile withId:(NSString*)mediaId;
- (NSString*)createMediaErrorWithCode:(CDVMediaError)code message:(NSString*)message;
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
RE: cordova-plugin-media git commit: CB-11380 (ios) Updated modified
method signature in the .h file
Posted by "Alexander Sorokin (Akvelon)" <v-...@microsoft.com>.
Oh, I didn’t mean to break the API.
I agree, let me do this and send the PR shortly.
Thanks,
Alexander Sorokin
From: Shazron<ma...@gmail.com>
Sent: Friday, August 26, 2016 6:42 PM
To: alsorokin@apache.org<ma...@apache.org>
Cc: commits@cordova.apache.org<ma...@cordova.apache.org>; dev@cordova.apache.org<ma...@cordova.apache.org>
Subject: Re: cordova-plugin-media git commit: CB-11380 (ios) Updated modified method signature in the .h file
I think we should add an overload and add back the old API method, since
this is effectively removing API and we don't want the hassle of a major
version bump.
On Friday, August 26, 2016, <al...@apache.org> wrote:
> Repository: cordova-plugin-media
> Updated Branches:
> refs/heads/master 910d3c798 -> 42b279b91
>
>
> CB-11380 (ios) Updated modified method signature in the .h file
>
>
> Project: https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2fgit-wip-us.apache.org%2frepos%2fasf%2fcordova-plugin-media%2frepo&data=01%7c01%7cv-alsoro%40microsoft.com%7ce58dc80986764ec64d6a08d3cdc7a502%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=bdrJOPrWlICXFtcJ9i8pKk3DQihy0PXFfTfw%2bggueKk%3d
> Commit: https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2fgit-wip-us.apache.org%2frepos%2fasf%2fcordova-plugin-&data=01%7c01%7cv-alsoro%40microsoft.com%7ce58dc80986764ec64d6a08d3cdc7a502%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=SalJDUACrJivrjANeeckxRmqouYAchpwDZ%2bAPOTOgFw%3d
> media/commit/42b279b9
> Tree: https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2fgit-wip-us.apache.org%2frepos%2fasf%2fcordova-plugin-&data=01%7c01%7cv-alsoro%40microsoft.com%7ce58dc80986764ec64d6a08d3cdc7a502%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=SalJDUACrJivrjANeeckxRmqouYAchpwDZ%2bAPOTOgFw%3d
> media/tree/42b279b9
> Diff: https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2fgit-wip-us.apache.org%2frepos%2fasf%2fcordova-plugin-&data=01%7c01%7cv-alsoro%40microsoft.com%7ce58dc80986764ec64d6a08d3cdc7a502%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=SalJDUACrJivrjANeeckxRmqouYAchpwDZ%2bAPOTOgFw%3d
> media/diff/42b279b9
>
> Branch: refs/heads/master
> Commit: 42b279b911c4b20689290f55ecb849905d3f1673
> Parents: 910d3c7
> Author: Alexander Sorokin <alexander.sorokin@akvelon.com <javascript:;>>
> Authored: Fri Aug 26 17:06:07 2016 +0300
> Committer: Alexander Sorokin <alexander.sorokin@akvelon.com <javascript:;>
> >
> Committed: Fri Aug 26 17:06:07 2016 +0300
>
> ----------------------------------------------------------------------
> src/ios/CDVSound.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> ----------------------------------------------------------------------
>
>
> https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2fgit-wip-us.apache.org%2frepos%2fasf%2fcordova-plugin-&data=01%7c01%7cv-alsoro%40microsoft.com%7ce58dc80986764ec64d6a08d3cdc7a502%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=SalJDUACrJivrjANeeckxRmqouYAchpwDZ%2bAPOTOgFw%3d
> media/blob/42b279b9/src/ios/CDVSound.h
> ----------------------------------------------------------------------
> diff --git a/src/ios/CDVSound.h b/src/ios/CDVSound.h
> index 1dca574..c3f7a6c 100644
> --- a/src/ios/CDVSound.h
> +++ b/src/ios/CDVSound.h
> @@ -106,7 +106,7 @@ typedef NSUInteger CDVMediaMsg;
> - (NSURL*)urlForRecording:(NSString*)resourcePath;
> - (NSURL*)urlForPlaying:(NSString*)resourcePath;
>
> -- (CDVAudioFile*)audioFileForResource:(NSString*)resourcePath
> withId:(NSString*)mediaId doValidation:(BOOL)bValidate
> forRecording:(BOOL)bRecord;
> +- (CDVAudioFile*)audioFileForResource:(NSString*)resourcePath
> withId:(NSString*)mediaId doValidation:(BOOL)bValidate
> forRecording:(BOOL)bRecord suppressValidationErrors:(BOOL)bSuppress;
> - (BOOL)prepareToPlay:(CDVAudioFile*)audioFile withId:(NSString*)mediaId;
> - (NSString*)createMediaErrorWithCode:(CDVMediaError)code
> message:(NSString*)message;
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
> <javascript:;>
> For additional commands, e-mail: commits-help@cordova.apache.org
> <javascript:;>
>
>
Re: cordova-plugin-media git commit: CB-11380 (ios) Updated modified
method signature in the .h file
Posted by Shazron <sh...@gmail.com>.
I think we should add an overload and add back the old API method, since
this is effectively removing API and we don't want the hassle of a major
version bump.
On Friday, August 26, 2016, <al...@apache.org> wrote:
> Repository: cordova-plugin-media
> Updated Branches:
> refs/heads/master 910d3c798 -> 42b279b91
>
>
> CB-11380 (ios) Updated modified method signature in the .h file
>
>
> Project: http://git-wip-us.apache.org/repos/asf/cordova-plugin-media/repo
> Commit: http://git-wip-us.apache.org/repos/asf/cordova-plugin-
> media/commit/42b279b9
> Tree: http://git-wip-us.apache.org/repos/asf/cordova-plugin-
> media/tree/42b279b9
> Diff: http://git-wip-us.apache.org/repos/asf/cordova-plugin-
> media/diff/42b279b9
>
> Branch: refs/heads/master
> Commit: 42b279b911c4b20689290f55ecb849905d3f1673
> Parents: 910d3c7
> Author: Alexander Sorokin <alexander.sorokin@akvelon.com <javascript:;>>
> Authored: Fri Aug 26 17:06:07 2016 +0300
> Committer: Alexander Sorokin <alexander.sorokin@akvelon.com <javascript:;>
> >
> Committed: Fri Aug 26 17:06:07 2016 +0300
>
> ----------------------------------------------------------------------
> src/ios/CDVSound.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> ----------------------------------------------------------------------
>
>
> http://git-wip-us.apache.org/repos/asf/cordova-plugin-
> media/blob/42b279b9/src/ios/CDVSound.h
> ----------------------------------------------------------------------
> diff --git a/src/ios/CDVSound.h b/src/ios/CDVSound.h
> index 1dca574..c3f7a6c 100644
> --- a/src/ios/CDVSound.h
> +++ b/src/ios/CDVSound.h
> @@ -106,7 +106,7 @@ typedef NSUInteger CDVMediaMsg;
> - (NSURL*)urlForRecording:(NSString*)resourcePath;
> - (NSURL*)urlForPlaying:(NSString*)resourcePath;
>
> -- (CDVAudioFile*)audioFileForResource:(NSString*)resourcePath
> withId:(NSString*)mediaId doValidation:(BOOL)bValidate
> forRecording:(BOOL)bRecord;
> +- (CDVAudioFile*)audioFileForResource:(NSString*)resourcePath
> withId:(NSString*)mediaId doValidation:(BOOL)bValidate
> forRecording:(BOOL)bRecord suppressValidationErrors:(BOOL)bSuppress;
> - (BOOL)prepareToPlay:(CDVAudioFile*)audioFile withId:(NSString*)mediaId;
> - (NSString*)createMediaErrorWithCode:(CDVMediaError)code
> message:(NSString*)message;
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
> <javascript:;>
> For additional commands, e-mail: commits-help@cordova.apache.org
> <javascript:;>
>
>