You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/10/08 23:08:49 UTC

[GitHub] [arrow-julia] kou commented on issue #342: Need to improve code review/release process and reduce developer productivity friction

kou commented on issue #342:
URL: https://github.com/apache/arrow-julia/issues/342#issuecomment-1272411069

   > 1. Inability for meaningful contributors to approve pull requests (only Arrow PMC members are able to approve PRs to be merged)
   
   Apache Arrow commiters (including @quinnj) and Apache Arrow PMC members can approve pull requests.
   
   If the approval for pull request is meaningless for us, we can disable the "require 1 approval before merging a pull request" feature by removing https://github.com/apache/arrow-julia/blob/main/.asf.yaml#L41-L43 . It's just added because the original repository has the configuration.
   
   > 2. Inability for meaningful contributors to approve new releases (same as above)
   
   Is it for voting a new release? Or is it for merging a pull request to bump version such as https://github.com/apache/arrow-julia/pull/312 ?
   
   If it's for voting, at least Apache Arrow PMC members need to audit license for each release.
   See also:
   * https://www.apache.org/legal/release-policy.html#release-approval
   * https://www.apache.org/legal/release-policy.html#licensing
   
   Because Apache Arrow PMC is responsible for ensuring that all Apache Arrow artifacts comply with legal affairs policies: https://www.apache.org/dev/pmc.html#legal-policy
   
   This is for legal protection. See also: https://www.apache.org/legal/release-policy.html#why
   
   If it's for merging a pull request, the current Apache Arrow Julia contributors can confirm changes for a new release and comment on a pull request to bump version. See also my answer for 1.
   
   > It would be much more helpful if @jrevels, @omus, @ericphanson, @nickrobinson251, @bkamins, and @baumgold had the necessary permissions to approve pull requests and new releases.
   
   OK. I'll start discussions about inviting them as an Apache Arrow committer on `private@arrow.apache.org`.
   Could you provide a text to use the discussion for each person? (@quinnj doesn't need to write all texts for them. Others can write them.)
   See also: https://cwiki.apache.org/confluence/display/ARROW/Inviting+New+Committers+and+PMC+Members#InvitingNewCommittersandPMCMembers-Step1:Startadiscussionthread
   
   > On point 3, the current 72-hour window is really long. Especially when it's idiomatic in Julia packages to merge a single pull request with small fix, and immediately issue a patch release. I think ideally we'd be able to have at least 12 or 24 hour release windows that would make things much more manageable.
   
   We can use 24 hours because 72 hours is just "SHOULD": https://www.apache.org/legal/release-policy.html#release-approval
   (12 hours will be short for considering timezone.)
   But we still needs at least 3 `+1` from Apache Arrow PMC members.
   
   BTW, we already use 24 hours not 72 hours. e.g.:
   * `[VOTE][Julia] Release Apache Arrow Julia 2.3.0 RC1` `2022-04-10T05:55:59+09:00` https://lists.apache.org/thread/66v4nrp4n1vmzmwcmhf9n9b4kv25jwgk
   * `[RESULT][VOTE][Julia] Release Apache Arrow Julia 2.3.0 RC1` `2022-04-12+09:53:43+09:00` https://lists.apache.org/thread/7vrmt956dfcm04nz9pn2bt70mf1vb3p1
   
   @quinnj Are you interested in joining Apache Arrow PMC? If you're an Apache Arrow PMC member, we'll get 2 `+1` (from you and me) soon. We just need one more `+1` for a new release. If one more Apache Arrow PMC members from Apache Arrow Julia community in the future, we'll get 3+ `+1` soon.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org