You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by "rhopman (via GitHub)" <gi...@apache.org> on 2025/11/24 20:28:33 UTC

[PR] FINERACT-2411: Allow empty columns to be deleted from datatables [fineract]

rhopman opened a new pull request, #5174:
URL: https://github.com/apache/fineract/pull/5174

   ## Description
   
   Allow a column to be dropped from a datatable if the column is currently NULL for all records.
   
   ## Checklist
   
   Please make sure these boxes are checked before submitting your pull request - thanks!
   
   - [x] Write the commit message as per https://github.com/apache/fineract/#pull-requests
   - [x] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
   - [x] Create/update unit or integration tests for verifying the changes made.
   - [x] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
   - [x] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
   - [x] Submission is not a "code dump".  (Large changes can be made "in repository" via a branch.  Ask on the developer mailing list for guidance, if required.)
   
   FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] FINERACT-2411: Allow empty columns to be deleted from datatables [fineract]

Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy commented on PR #5174:
URL: https://github.com/apache/fineract/pull/5174#issuecomment-3575465899

   @rhopman Please run this to fix the spotless related issues:
   ```
   ./gradlew spotlessApply spotbugsMain spotbugsTest checkstyleMain checkstyleTest
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] FINERACT-2411: Allow empty columns to be deleted from datatables [fineract]

Posted by "rhopman (via GitHub)" <gi...@apache.org>.
rhopman commented on PR #5174:
URL: https://github.com/apache/fineract/pull/5174#issuecomment-3576137735

   Apologies @adamsaghy, I thought I did all the checks but apparently I missed this. It should be fixed now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] FINERACT-2411: Allow empty columns to be deleted from datatables [fineract]

Posted by "galovics (via GitHub)" <gi...@apache.org>.
galovics merged PR #5174:
URL: https://github.com/apache/fineract/pull/5174


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org