Re: [PR] [ARIES-2161] update destroy method to be compatible with spring 6 [aries]

["alien11689 (via GitHub)" <gi...@apache.org>]

alien11689 commented on code in PR #299:
URL: https://github.com/apache/aries/pull/299#discussion_r1866432637


##########
blueprint/blueprint-spring/pom.xml:
##########
@@ -119,13 +119,13 @@
         <dependency>
             <groupId>org.springframework</groupId>
             <artifactId>spring-context</artifactId>
-            <version>4.2.2.RELEASE</version>
+            <version>6.1.15</version>

Review Comment:
   I checked that spring 6.x does not work with minimal java 8 that we should have in the repo
   you can find the errors by running:
   ```
   mvn -f blueprint/blueprint-spring clean package
   ```
   or checking your branch with definition of blueprint build from https://github.com/apache/aries/pull/297



##########
blueprint/blueprint-spring/pom.xml:
##########
@@ -191,6 +191,13 @@
 
     <build>
         <plugins>
+            <plugin>
+                <artifactId>maven-compiler-plugin</artifactId>
+                <configuration>
+                    <target>1.7</target>

Review Comment:
   java 8 should be minimal supported version



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@aries.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org