You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Fateh Singh <fa...@gmail.com> on 2022/07/20 16:47:24 UTC
Review Request 74062: [Ranger-3834] Test cases for RoleREST.java missing (security-admin module)
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74062/
-----------------------------------------------------------
Review request for ranger, bhavik patel, Dhaval Shah, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.
Bugs: Ranger-3834
https://issues.apache.org/jira/browse/Ranger-3834
Repository: ranger
Description
-------
Unit test cases for RoleREST.java were missing.
In RoleDBStore.java, RangerDaoManager was being accesed like "roleRefUpdater.daoMgr" directly instead of using getter.
Diffs
-----
security-admin/src/main/java/org/apache/ranger/biz/RoleDBStore.java f501f2896
security-admin/src/main/java/org/apache/ranger/biz/RoleRefUpdater.java 012d4c02f
security-admin/src/test/java/org/apache/ranger/rest/TestRoleREST.java PRE-CREATION
Diff: https://reviews.apache.org/r/74062/diff/1/
Testing
-------
1) Wrote unit test cases for RoleREST.java in a file TestRoleREST.java
2) Added getter for RangerDaoManager in RoleRefUpdater instead of accessing the member variable directly -- to make code more testable.
2) Ran all the written test cases -- all test cases passed (Method coverage:: 97.1% (33/34) Line coverage:: 74.4% (490/659))
Thanks,
Fateh Singh
Re: Review Request 74062: [Ranger-3834] Test cases for RoleREST.java missing (security-admin module)
Posted by Abhishek Kumar <ab...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74062/#review224570
-----------------------------------------------------------
security-admin/src/test/java/org/apache/ranger/rest/TestRoleREST.java
Lines 104 (patched)
<https://reviews.apache.org/r/74062/#comment313346>
Methods of the Assert class have been extensively used across test classes in security-admin, please use the same here as well -
for ex: Assert.assertNotNull, Assert.assertEquals,
Assert.assertNotEquals, etc.
security-admin/src/test/java/org/apache/ranger/rest/TestRoleREST.java
Lines 107 (patched)
<https://reviews.apache.org/r/74062/#comment313347>
Same as above, please check all occurences.
- Abhishek Kumar
On July 20, 2022, 4:47 p.m., Fateh Singh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74062/
> -----------------------------------------------------------
>
> (Updated July 20, 2022, 4:47 p.m.)
>
>
> Review request for ranger, bhavik patel, Dhaval Shah, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.
>
>
> Bugs: Ranger-3834
> https://issues.apache.org/jira/browse/Ranger-3834
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Unit test cases for RoleREST.java were missing.
> In RoleDBStore.java, RangerDaoManager was being accesed like "roleRefUpdater.daoMgr" directly instead of using getter.
>
>
> Diffs
> -----
>
> security-admin/src/main/java/org/apache/ranger/biz/RoleDBStore.java f501f2896
> security-admin/src/main/java/org/apache/ranger/biz/RoleRefUpdater.java 012d4c02f
> security-admin/src/test/java/org/apache/ranger/rest/TestRoleREST.java PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/74062/diff/1/
>
>
> Testing
> -------
>
> 1) Wrote unit test cases for RoleREST.java in a file TestRoleREST.java
> 2) Added getter for RangerDaoManager in RoleRefUpdater instead of accessing the member variable directly -- to make code more testable.
> 2) Ran all the written test cases -- all test cases passed (Method coverage:: 97.1% (33/34) Line coverage:: 74.4% (490/659))
>
>
> Thanks,
>
> Fateh Singh
>
>
Re: Review Request 74062: [Ranger-3834] Test cases for RoleREST.java missing (security-admin module)
Posted by Abhay Kulkarni <ak...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74062/#review224610
-----------------------------------------------------------
Ship it!
Ship It!
- Abhay Kulkarni
On July 22, 2022, 7:40 p.m., Fateh Singh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74062/
> -----------------------------------------------------------
>
> (Updated July 22, 2022, 7:40 p.m.)
>
>
> Review request for ranger, bhavik patel, Dhaval Shah, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.
>
>
> Bugs: Ranger-3834
> https://issues.apache.org/jira/browse/Ranger-3834
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Unit test cases for RoleREST.java were missing.
> In RoleDBStore.java, RangerDaoManager was being accesed like "roleRefUpdater.daoMgr" directly instead of using getter.
>
>
> Diffs
> -----
>
> security-admin/src/main/java/org/apache/ranger/biz/RoleDBStore.java f501f2896
> security-admin/src/main/java/org/apache/ranger/biz/RoleRefUpdater.java 012d4c02f
> security-admin/src/test/java/org/apache/ranger/rest/TestRoleREST.java PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/74062/diff/3/
>
>
> Testing
> -------
>
> 1) Wrote unit test cases for RoleREST.java in a file TestRoleREST.java
> 2) Added getter for RangerDaoManager in RoleRefUpdater instead of accessing the member variable directly -- to make code more testable.
> 2) Ran all the written test cases -- all test cases passed (Method coverage:: 97.1% (33/34) Line coverage:: 74.4% (490/659))
>
>
> Thanks,
>
> Fateh Singh
>
>
Re: Review Request 74062: [Ranger-3834] Test cases for RoleREST.java missing (security-admin module)
Posted by Abhishek Kumar <ab...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74062/#review224590
-----------------------------------------------------------
security-admin/src/test/java/org/apache/ranger/rest/TestRoleREST.java
Lines 73 (patched)
<https://reviews.apache.org/r/74062/#comment313383>
@BeforeMethod annotation can be used here (part of testng lib), explicit calls to setup() is not needed in every test.
- Abhishek Kumar
On July 22, 2022, 7:40 p.m., Fateh Singh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74062/
> -----------------------------------------------------------
>
> (Updated July 22, 2022, 7:40 p.m.)
>
>
> Review request for ranger, bhavik patel, Dhaval Shah, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.
>
>
> Bugs: Ranger-3834
> https://issues.apache.org/jira/browse/Ranger-3834
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Unit test cases for RoleREST.java were missing.
> In RoleDBStore.java, RangerDaoManager was being accesed like "roleRefUpdater.daoMgr" directly instead of using getter.
>
>
> Diffs
> -----
>
> security-admin/src/main/java/org/apache/ranger/biz/RoleDBStore.java f501f2896
> security-admin/src/main/java/org/apache/ranger/biz/RoleRefUpdater.java 012d4c02f
> security-admin/src/test/java/org/apache/ranger/rest/TestRoleREST.java PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/74062/diff/2/
>
>
> Testing
> -------
>
> 1) Wrote unit test cases for RoleREST.java in a file TestRoleREST.java
> 2) Added getter for RangerDaoManager in RoleRefUpdater instead of accessing the member variable directly -- to make code more testable.
> 2) Ran all the written test cases -- all test cases passed (Method coverage:: 97.1% (33/34) Line coverage:: 74.4% (490/659))
>
>
> Thanks,
>
> Fateh Singh
>
>
Re: Review Request 74062: [Ranger-3834] Test cases for RoleREST.java missing (security-admin module)
Posted by Fateh Singh <fa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74062/
-----------------------------------------------------------
(Updated July 22, 2022, 7:40 p.m.)
Review request for ranger, bhavik patel, Dhaval Shah, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.
Changes
-------
Using Assert class for assertions instead of directly asserting
Bugs: Ranger-3834
https://issues.apache.org/jira/browse/Ranger-3834
Repository: ranger
Description
-------
Unit test cases for RoleREST.java were missing.
In RoleDBStore.java, RangerDaoManager was being accesed like "roleRefUpdater.daoMgr" directly instead of using getter.
Diffs (updated)
-----
security-admin/src/main/java/org/apache/ranger/biz/RoleDBStore.java f501f2896
security-admin/src/main/java/org/apache/ranger/biz/RoleRefUpdater.java 012d4c02f
security-admin/src/test/java/org/apache/ranger/rest/TestRoleREST.java PRE-CREATION
Diff: https://reviews.apache.org/r/74062/diff/2/
Changes: https://reviews.apache.org/r/74062/diff/1-2/
Testing
-------
1) Wrote unit test cases for RoleREST.java in a file TestRoleREST.java
2) Added getter for RangerDaoManager in RoleRefUpdater instead of accessing the member variable directly -- to make code more testable.
2) Ran all the written test cases -- all test cases passed (Method coverage:: 97.1% (33/34) Line coverage:: 74.4% (490/659))
Thanks,
Fateh Singh