You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/07/13 18:02:00 UTC
[jira] [Commented] (ZOOKEEPER-2490) infinitely connect on windows
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16086115#comment-16086115 ]
ASF GitHub Bot commented on ZOOKEEPER-2490:
-------------------------------------------
GitHub user thelordpsy opened a pull request:
https://github.com/apache/zookeeper/pull/309
ZOOKEEPER-2490: infinitely connect on windows
Apply patch file from spooky000 for ZOOKEEPER-2490
Resolves issue where memcmp always returns false in windows release builds
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/thelordpsy/zookeeper master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zookeeper/pull/309.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #309
----
commit 1ddad6f70ea85483c9807ba9f0e98ffa8d3f98eb
Author: Jeffrey Brill <jb...@blizzard.com>
Date: 2017-07-13T17:57:01Z
Apply patch file from spooky000 for ZOOKEEPER-2490
Resolves issue where memcmp always returns false in windows release builds
----
> infinitely connect on windows
> -----------------------------
>
> Key: ZOOKEEPER-2490
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2490
> Project: ZooKeeper
> Issue Type: Bug
> Components: c client
> Affects Versions: 3.5.2
> Environment: Windows
> Reporter: spooky000
> Assignee: spooky000
> Fix For: 3.5.4, 3.6.0
>
> Attachments: ZOOKEEPER-2490.patch, ZOOKEEPER-2490.patch, ZOOKEEPER-2490.patch
>
>
> in addrvec_contains function
> this memcmp always return false on windows release build.
> for (i = 0; i < avec->count; i++)
> {
> if(memcmp(&avec->data[i], addr, INET_ADDRSTRLEN) == 0)
> return 1;
> }
> because..
> #define INET_ADDRSTRLEN 16 on linux.
> #define INET_ADDRSTRLEN 22 on windows.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)