You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by srowen <gi...@git.apache.org> on 2016/07/30 14:28:10 UTC

[GitHub] spark pull request #14421: [SPARK-16816] Add api to get JavaSparkContext fro...

Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14421#discussion_r72888442
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/SparkSession.scala ---
    @@ -122,6 +122,14 @@ class SparkSession private(
       val sqlContext: SQLContext = new SQLContext(this)
     
       /**
    +   * This is the interface through which the user can get [[JavaSparkContext]]
    +   *
    +   * @since 2.0.0
    +   */
    +  @transient
    +  val javaSparkContext: JavaSparkContext = new JavaSparkContext(sparkContext)
    --- End diff --
    
    This always make a JavaSparkContext. Why not just have the caller do this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org