You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2013/03/05 23:39:35 UTC

Re: Review Request: Added support for hadoop-2.0.0-mr1-cdh4.1.2.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9174/
-----------------------------------------------------------

(Updated March 5, 2013, 10:39 p.m.)


Review request for mesos, Benjamin Hindman and Ben Mahler.


Changes
-------

benh's.


Summary (updated)
-----------------

Added support for hadoop-2.0.0-mr1-cdh4.1.2.


Description
-------

See Summary.

Also, we only run 'ant' once instead of twice.


This addresses bug MESOS-352.
    https://issues.apache.org/jira/browse/MESOS-352


Diffs (updated)
-----

  hadoop/Makefile.am d1aa75535ab617f9e4a0b8a0db84d77f1916acc4 
  hadoop/TUTORIAL.sh 5670d6afa96f858d437f26885e862712bbf72b71 
  hadoop/hadoop-2.0.0-mr1-cdh4.1.2_hadoop-env.sh.patch PRE-CREATION 
  hadoop/hadoop-2.0.0-mr1-cdh4.1.2_mesos.patch PRE-CREATION 

Diff: https://reviews.apache.org/r/9174/diff/


Testing
-------

make hadoop-2.0.0-mr1-cdh4.1.2
make hadoop-0.20.2-cdh3u3
make hadoop-0.20.205.0


Thanks,

Vinod Kone

Re: Review Request: Added support for hadoop-2.0.0-mr1-cdh4.1.2.

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9174/
-----------------------------------------------------------

(Updated March 6, 2013, 2:24 a.m.)


Review request for mesos, Benjamin Hindman and Ben Mahler.


Changes
-------

Updated diff for posterity. No need for review.


Description
-------

See Summary.

Also, we only run 'ant' once instead of twice.


This addresses bug MESOS-352.
    https://issues.apache.org/jira/browse/MESOS-352


Diffs (updated)
-----

  hadoop/Makefile.am d1aa75535ab617f9e4a0b8a0db84d77f1916acc4 
  hadoop/TUTORIAL.sh 5670d6afa96f858d437f26885e862712bbf72b71 
  hadoop/hadoop-2.0.0-mr1-cdh4.1.2_hadoop-env.sh.patch PRE-CREATION 
  hadoop/hadoop-2.0.0-mr1-cdh4.1.2_mesos.patch PRE-CREATION 

Diff: https://reviews.apache.org/r/9174/diff/


Testing
-------

make hadoop-2.0.0-mr1-cdh4.1.2
make hadoop-0.20.2-cdh3u3
make hadoop-0.20.205.0


Thanks,

Vinod Kone

Re: Review Request: Added support for hadoop-2.0.0-mr1-cdh4.1.2.

Posted by Vinod Kone <vi...@gmail.com>.

> On March 5, 2013, 11:25 p.m., Benjamin Hindman wrote:
> > hadoop/TUTORIAL.sh, line 267
> > <https://reviews.apache.org/r/9174/diff/10/?file=266585#file266585line267>
> >
> >     What about aligning these? I don't know whether or not it's worth obeying style guidelines here for readability, up to you.

I've been aligning line breaks as +2 in this tutorial.


- Vinod


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9174/#review17432
-----------------------------------------------------------


On March 5, 2013, 10:39 p.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9174/
> -----------------------------------------------------------
> 
> (Updated March 5, 2013, 10:39 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Ben Mahler.
> 
> 
> Description
> -------
> 
> See Summary.
> 
> Also, we only run 'ant' once instead of twice.
> 
> 
> This addresses bug MESOS-352.
>     https://issues.apache.org/jira/browse/MESOS-352
> 
> 
> Diffs
> -----
> 
>   hadoop/Makefile.am d1aa75535ab617f9e4a0b8a0db84d77f1916acc4 
>   hadoop/TUTORIAL.sh 5670d6afa96f858d437f26885e862712bbf72b71 
>   hadoop/hadoop-2.0.0-mr1-cdh4.1.2_hadoop-env.sh.patch PRE-CREATION 
>   hadoop/hadoop-2.0.0-mr1-cdh4.1.2_mesos.patch PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/9174/diff/
> 
> 
> Testing
> -------
> 
> make hadoop-2.0.0-mr1-cdh4.1.2
> make hadoop-0.20.2-cdh3u3
> make hadoop-0.20.205.0
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Re: Review Request: Added support for hadoop-2.0.0-mr1-cdh4.1.2.

Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9174/#review17432
-----------------------------------------------------------

Ship it!



hadoop/TUTORIAL.sh
<https://reviews.apache.org/r/9174/#comment36973>

    Can kill this now.



hadoop/TUTORIAL.sh
<https://reviews.apache.org/r/9174/#comment36974>

    What about aligning these? I don't know whether or not it's worth obeying style guidelines here for readability, up to you.



hadoop/TUTORIAL.sh
<https://reviews.apache.org/r/9174/#comment36976>

    Maybe a TODO to make these part of the tutorial?


- Benjamin Hindman


On March 5, 2013, 10:39 p.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9174/
> -----------------------------------------------------------
> 
> (Updated March 5, 2013, 10:39 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Ben Mahler.
> 
> 
> Description
> -------
> 
> See Summary.
> 
> Also, we only run 'ant' once instead of twice.
> 
> 
> This addresses bug MESOS-352.
>     https://issues.apache.org/jira/browse/MESOS-352
> 
> 
> Diffs
> -----
> 
>   hadoop/Makefile.am d1aa75535ab617f9e4a0b8a0db84d77f1916acc4 
>   hadoop/TUTORIAL.sh 5670d6afa96f858d437f26885e862712bbf72b71 
>   hadoop/hadoop-2.0.0-mr1-cdh4.1.2_hadoop-env.sh.patch PRE-CREATION 
>   hadoop/hadoop-2.0.0-mr1-cdh4.1.2_mesos.patch PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/9174/diff/
> 
> 
> Testing
> -------
> 
> make hadoop-2.0.0-mr1-cdh4.1.2
> make hadoop-0.20.2-cdh3u3
> make hadoop-0.20.205.0
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Re: Review Request: Added support for hadoop-2.0.0-mr1-cdh4.1.2.

Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9174/#review17438
-----------------------------------------------------------

Ship it!


Ship It!

- Ben Mahler


On March 5, 2013, 10:39 p.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9174/
> -----------------------------------------------------------
> 
> (Updated March 5, 2013, 10:39 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Ben Mahler.
> 
> 
> Description
> -------
> 
> See Summary.
> 
> Also, we only run 'ant' once instead of twice.
> 
> 
> This addresses bug MESOS-352.
>     https://issues.apache.org/jira/browse/MESOS-352
> 
> 
> Diffs
> -----
> 
>   hadoop/Makefile.am d1aa75535ab617f9e4a0b8a0db84d77f1916acc4 
>   hadoop/TUTORIAL.sh 5670d6afa96f858d437f26885e862712bbf72b71 
>   hadoop/hadoop-2.0.0-mr1-cdh4.1.2_hadoop-env.sh.patch PRE-CREATION 
>   hadoop/hadoop-2.0.0-mr1-cdh4.1.2_mesos.patch PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/9174/diff/
> 
> 
> Testing
> -------
> 
> make hadoop-2.0.0-mr1-cdh4.1.2
> make hadoop-0.20.2-cdh3u3
> make hadoop-0.20.205.0
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>