You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@spark.apache.org by "Wenchen Fan (JIRA)" <ji...@apache.org> on 2016/11/29 13:47:59 UTC
[jira] [Comment Edited] (SPARK-17897) not isnotnull is converted to
the always false condition isnotnull && not isnotnull
[ https://issues.apache.org/jira/browse/SPARK-17897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15705342#comment-15705342 ]
Wenchen Fan edited comment on SPARK-17897 at 11/29/16 1:47 PM:
---------------------------------------------------------------
oh sorry the web page was not refreshed and I didn't notice that you [~smilegator] already send out the PR. I have the same idea with you, let's see if it breaks any tests.
was (Author: cloud_fan):
oh sorry the web page was not refreshed and I did see you [~smilegator] already send out the PR. I have the same idea with you, let's see if it breaks any tests.
> not isnotnull is converted to the always false condition isnotnull && not isnotnull
> -----------------------------------------------------------------------------------
>
> Key: SPARK-17897
> URL: https://issues.apache.org/jira/browse/SPARK-17897
> Project: Spark
> Issue Type: Bug
> Components: Optimizer
> Affects Versions: 2.0.0, 2.0.1
> Reporter: Jordan Halterman
> Labels: correctness
>
> When a logical plan is built containing the following somewhat nonsensical filter:
> {{Filter (NOT isnotnull($f0#212))}}
> During optimization the filter is converted into a condition that will always fail:
> {{Filter (isnotnull($f0#212) && NOT isnotnull($f0#212))}}
> This appears to be caused by the following check for {{NullIntolerant}}:
> https://github.com/apache/spark/commit/df68beb85de59bb6d35b2a8a3b85dbc447798bf5#diff-203ac90583cebe29a92c1d812c07f102R63
> Which recurses through the expression and extracts nested {{IsNotNull}} calls, converting them to {{IsNotNull}} calls on the attribute at the root level:
> https://github.com/apache/spark/commit/df68beb85de59bb6d35b2a8a3b85dbc447798bf5#diff-203ac90583cebe29a92c1d812c07f102R49
> This results in the nonsensical condition above.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org