You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Lukasz Lenart <lu...@apache.org> on 2020/12/24 12:11:25 UTC
Preparing a release
Hi,
I would like to (finally) prepare a first release of the Apache
Commons OGNL project. I'm reading the docs [1][2], which I think is
enough to prepare the release.
Is it possible to release a version just to learn how to do the
release? I mean, there is still a lot of code that I would like to
fork from the original source [3], but this is a manual process and in
the meantime I would like to test/learn the release process.
[1] https://commons.apache.org/releases/prepare.html
[2] https://commons.apache.org/proper/commons-release-plugin/index.html
[3] https://github.com/jkuhnert/ognl
Regards
--
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: Preparing a release
Posted by Lukasz Lenart <lu...@apache.org>.
niedz., 27 gru 2020 o 21:14 Bernd Eckenfels <ec...@zusammenkunft.net> napisał(a):
> I would say if the maven release plugin and the maven pgp plug-ins work (on your system and for the Pom) and the project builds on al l supported platforms, go for it. If you have your ASF login and thenPgpg key in the Keys file you would meet the criteria.
>
> I am not sure about backward compatibility, package names and so on, but if it’s the first release it should be a new major, either 1.0 or 4.0.
I would love to reduce the number of Maven plugins in the project,
OGNL depends on ASM only, but there are a dozen of plugins, not sure
if all of them are required.
Another question, I have noticed that the issue reference in
changes.xml doesn't match a JIRA ticket, is that ok? e.g.:
<action issue="OGNL-1" type="update" dev="lukaszlenart">Import the
OGNL codebase</action>
but
https://issues.apache.org/jira/browse/OGNL-1 -> Type conversion improvements
Regards
--
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: Preparing a release
Posted by Bernd Eckenfels <ec...@zusammenkunft.net>.
Hello Lukasz,
I would say if the maven release plugin and the maven pgp plug-ins work (on your system and for the Pom) and the project builds on al l supported platforms, go for it. If you have your ASF login and thenPgpg key in the Keys file you would meet the criteria.
I am not sure about backward compatibility, package names and so on, but if it’s the first release it should be a new major, either 1.0 or 4.0.
Gruss
Bernd
--
http://bernd.eckenfels.net
________________________________
Von: Lukasz Lenart <lu...@apache.org>
Gesendet: Sunday, December 27, 2020 8:14:58 PM
An: dev@commons.apache.org <de...@commons.apache.org>
Betreff: Re: Preparing a release
Sorry, I was not subscribed to the list.
On 2020/12/25 01:18:00, Gary Gregory <ga...@gmail.com> wrote:
> There might be a lot more to consider here since this would be a major
> release. Are there breaking API changes we want to make? Are there
> deprecated APIs we want to drop?
>
> I see a lot of errors fly by when I do a local build on Windows but these
> do not seem to fail the build which is odd.
Not sure if I understand your questions, I still actively support OGNL 3.x which lives on Github, there is a lot of smaller changes which should be moved into this project to keep backward compatibility with projects depending on OGNL.
As imported version was 3.0.1 and now there is OGNL 3.2.18 I think this supposed to be the first step.
> It seems to me that this project has not been released in a long time, so
> there should be some consideration to taking advantage of the version of
> Java the component is now sitting on.
This project was never released after moving it under ASF umbrella.
> I think I saw an animal sniffer setting set to Java 15? How does that make
> sense?
I just tried to understand what to do to build the project, and as I understand java15 means Java 1.5
https://www.mojohaus.org/animal-sniffer/animal-sniffer-maven-plugin/usage.html
> To make a long story short, we should not be in a rush to release a major
> new version just for the sake of creating a release. Maybe that would be
> better in the 3.x context, I'm not sure.
Right, I'm just trying understand the requirements of releasing a project which belongs to Commons family.
Regards
Lukasz
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: Preparing a release
Posted by Lukasz Lenart <lu...@apache.org>.
Sorry, I was not subscribed to the list.
On 2020/12/25 01:18:00, Gary Gregory <ga...@gmail.com> wrote:
> There might be a lot more to consider here since this would be a major
> release. Are there breaking API changes we want to make? Are there
> deprecated APIs we want to drop?
>
> I see a lot of errors fly by when I do a local build on Windows but these
> do not seem to fail the build which is odd.
Not sure if I understand your questions, I still actively support OGNL 3.x which lives on Github, there is a lot of smaller changes which should be moved into this project to keep backward compatibility with projects depending on OGNL.
As imported version was 3.0.1 and now there is OGNL 3.2.18 I think this supposed to be the first step.
> It seems to me that this project has not been released in a long time, so
> there should be some consideration to taking advantage of the version of
> Java the component is now sitting on.
This project was never released after moving it under ASF umbrella.
> I think I saw an animal sniffer setting set to Java 15? How does that make
> sense?
I just tried to understand what to do to build the project, and as I understand java15 means Java 1.5
https://www.mojohaus.org/animal-sniffer/animal-sniffer-maven-plugin/usage.html
> To make a long story short, we should not be in a rush to release a major
> new version just for the sake of creating a release. Maybe that would be
> better in the 3.x context, I'm not sure.
Right, I'm just trying understand the requirements of releasing a project which belongs to Commons family.
Regards
Lukasz
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: Preparing a release
Posted by Gary Gregory <ga...@gmail.com>.
There might be a lot more to consider here since this would be a major
release. Are there breaking API changes we want to make? Are there
deprecated APIs we want to drop?
I see a lot of errors fly by when I do a local build on Windows but these
do not seem to fail the build which is odd.
It seems to me that this project has not been released in a long time, so
there should be some consideration to taking advantage of the version of
Java the component is now sitting on.
I think I saw an animal sniffer setting set to Java 15? How does that make
sense?
To make a long story short, we should not be in a rush to release a major
new version just for the sake of creating a release. Maybe that would be
better in the 3.x context, I'm not sure.
Gary
On Thu, Dec 24, 2020, 07:11 Lukasz Lenart <lu...@apache.org> wrote:
> Hi,
>
> I would like to (finally) prepare a first release of the Apache
> Commons OGNL project. I'm reading the docs [1][2], which I think is
> enough to prepare the release.
>
> Is it possible to release a version just to learn how to do the
> release? I mean, there is still a lot of code that I would like to
> fork from the original source [3], but this is a manual process and in
> the meantime I would like to test/learn the release process.
>
> [1] https://commons.apache.org/releases/prepare.html
> [2] https://commons.apache.org/proper/commons-release-plugin/index.html
> [3] https://github.com/jkuhnert/ognl
>
>
> Regards
> --
> Łukasz
> + 48 606 323 122 http://www.lenart.org.pl/
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>