[jira] Commented: (DIRSTUDIO-387) Comments are removed!

["Felix Knecht (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DIRSTUDIO-387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12674049#action_12674049 ] 

Felix Knecht commented on DIRSTUDIO-387:
----------------------------------------

Please correct me if I'm wrong Pierre-Arnaud, but to me it looks like the configuration is loaded in the classes ServerXmlIOV*. After parsing the configuration is stored in a 'ServerConfiguration' (data-) bean but not in a DOM tree and any 'unnecessary' data is drop. This means that the design isn't made to handle additional data like comments. Neither to keep comments from an already existing configuration file nor to add comments when creating a new configuration.

IMO there has to be a change in design to respect already existing comments. What about reading/creating the configuration into a DOM tree and validate the tree against a schema/dtd (what we should have anyway ;-) )?

WDOT?


> Comments are removed!
> ---------------------
>
>                 Key: DIRSTUDIO-387
>                 URL: https://issues.apache.org/jira/browse/DIRSTUDIO-387
>             Project: Directory Studio
>          Issue Type: Improvement
>          Components: studio-apacheds-configuration
>    Affects Versions: 1.2.0
>         Environment: Windows XP SP1.3 w/JRE 1.5_16
>            Reporter: Roger (Skip) Dooley
>
> Lets say your are editing a copy of a source file with your new fancy contest sensitive editor.
> Everything looks great, you make some changes save the file, and later look at the file with a text editor.  Much to your surprise all the comments you worked so hard to put in have been stripped by the editor!
> Well that is what happens in Directory Studio's configuration editor.
> The default server.xml file that comes with Dierctory Server has comments in it
> After editing with Directory Studio's configuration editor, they are gone.
> You wouldn't accept this behaviour with a source file?
> Comments should be passed through.....or maybe an option default YES

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.