You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joseph Wu <jo...@mesosphere.io> on 2015/08/24 21:08:59 UTC
Re: Review Request 37362: Maintenance Primitives: Adds an endpoint for
transitioning agents back into Normal mode.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37362/
-----------------------------------------------------------
(Updated Aug. 24, 2015, 12:08 p.m.)
Review request for mesos, Benjamin Hindman, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, and Vinod Kone.
Changes
-------
Rebased and updated diff. No other changes.
Bugs: MESOS-2067 and MESOS-3069
https://issues.apache.org/jira/browse/MESOS-2067
https://issues.apache.org/jira/browse/MESOS-3069
Repository: mesos
Description
-------
Endpoint: /maintenance.stop
Registry operation = maintenance::StopMaintenance
Sets the list of machines back to Normal mode. Removes those machines from the maintenance schedule.
Diffs (updated)
-----
src/master/http.cpp 37d76ee72f6a037f551bf2609e9393e16b496e44
src/master/maintenance.hpp PRE-CREATION
src/master/maintenance.cpp PRE-CREATION
src/master/master.hpp 0432842d77beba024c7895291ca410964bae96be
src/master/master.cpp 95207d24db0aa052eb70c4cc7eb75d0611c365cf
src/tests/master_maintenance_tests.cpp PRE-CREATION
src/tests/registrar_tests.cpp 032e644ee19751b4ce5767d46f474d34ec4b9166
Diff: https://reviews.apache.org/r/37362/diff/
Testing
-------
`make check`
New Tests:
RegistrarTest.StopMaintenance
Schedules some machines. Deactivates some. Reactivates some.
MasterMaintenanceTest.ReactivateMachines
Tests some invalid lists.
Schedules some machines. Deactivates some. Tests some valid and invalid lists.
Checks that the schedule is modified.
Thanks,
Joseph Wu
Re: Review Request 37362: Maintenance Primitives: Adds an endpoint for
transitioning agents back into Normal mode.
Posted by Joseph Wu <jo...@mesosphere.io>.
> On Aug. 25, 2015, 2:11 a.m., Guangya Liu wrote:
> > src/master/maintenance.cpp, line 153
> > <https://reviews.apache.org/r/37362/diff/7/?file=1048631#file1048631line153>
> >
> > Not quite under what does the paramter "strict" means here? Seems it was not used.
See my comment: https://reviews.apache.org/r/37358/#comment151628
> On Aug. 25, 2015, 2:11 a.m., Guangya Liu wrote:
> > src/master/maintenance.cpp, line 157
> > <https://reviews.apache.org/r/37362/diff/7/?file=1048631#file1048631line157>
> >
> > I see that "changed" will be set to true when one machine removed from mantain list, what does "changed" means here?
See my comment: https://reviews.apache.org/r/37358/#comment151627
- Joseph
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37362/#review96313
-----------------------------------------------------------
On Aug. 24, 2015, 12:08 p.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37362/
> -----------------------------------------------------------
>
> (Updated Aug. 24, 2015, 12:08 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, and Vinod Kone.
>
>
> Bugs: MESOS-2067 and MESOS-3069
> https://issues.apache.org/jira/browse/MESOS-2067
> https://issues.apache.org/jira/browse/MESOS-3069
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Endpoint: /maintenance.stop
>
> Registry operation = maintenance::StopMaintenance
> Sets the list of machines back to Normal mode. Removes those machines from the maintenance schedule.
>
>
> Diffs
> -----
>
> src/master/http.cpp 37d76ee72f6a037f551bf2609e9393e16b496e44
> src/master/maintenance.hpp PRE-CREATION
> src/master/maintenance.cpp PRE-CREATION
> src/master/master.hpp 0432842d77beba024c7895291ca410964bae96be
> src/master/master.cpp 95207d24db0aa052eb70c4cc7eb75d0611c365cf
> src/tests/master_maintenance_tests.cpp PRE-CREATION
> src/tests/registrar_tests.cpp 032e644ee19751b4ce5767d46f474d34ec4b9166
>
> Diff: https://reviews.apache.org/r/37362/diff/
>
>
> Testing
> -------
>
> `make check`
>
> New Tests:
> RegistrarTest.StopMaintenance
> Schedules some machines. Deactivates some. Reactivates some.
> MasterMaintenanceTest.ReactivateMachines
> Tests some invalid lists.
> Schedules some machines. Deactivates some. Tests some valid and invalid lists.
> Checks that the schedule is modified.
>
>
> Thanks,
>
> Joseph Wu
>
>
Re: Review Request 37362: Maintenance Primitives: Adds an endpoint for
transitioning agents back into Normal mode.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37362/#review96313
-----------------------------------------------------------
src/master/maintenance.cpp (line 153)
<https://reviews.apache.org/r/37362/#comment151633>
Not quite under what does the paramter "strict" means here? Seems it was not used.
src/master/maintenance.cpp (line 157)
<https://reviews.apache.org/r/37362/#comment151634>
I see that "changed" will be set to true when one machine removed from mantain list, what does "changed" means here?
- Guangya Liu
On Aug. 24, 2015, 7:08 p.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37362/
> -----------------------------------------------------------
>
> (Updated Aug. 24, 2015, 7:08 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, and Vinod Kone.
>
>
> Bugs: MESOS-2067 and MESOS-3069
> https://issues.apache.org/jira/browse/MESOS-2067
> https://issues.apache.org/jira/browse/MESOS-3069
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Endpoint: /maintenance.stop
>
> Registry operation = maintenance::StopMaintenance
> Sets the list of machines back to Normal mode. Removes those machines from the maintenance schedule.
>
>
> Diffs
> -----
>
> src/master/http.cpp 37d76ee72f6a037f551bf2609e9393e16b496e44
> src/master/maintenance.hpp PRE-CREATION
> src/master/maintenance.cpp PRE-CREATION
> src/master/master.hpp 0432842d77beba024c7895291ca410964bae96be
> src/master/master.cpp 95207d24db0aa052eb70c4cc7eb75d0611c365cf
> src/tests/master_maintenance_tests.cpp PRE-CREATION
> src/tests/registrar_tests.cpp 032e644ee19751b4ce5767d46f474d34ec4b9166
>
> Diff: https://reviews.apache.org/r/37362/diff/
>
>
> Testing
> -------
>
> `make check`
>
> New Tests:
> RegistrarTest.StopMaintenance
> Schedules some machines. Deactivates some. Reactivates some.
> MasterMaintenanceTest.ReactivateMachines
> Tests some invalid lists.
> Schedules some machines. Deactivates some. Tests some valid and invalid lists.
> Checks that the schedule is modified.
>
>
> Thanks,
>
> Joseph Wu
>
>
Re: Review Request 37362: Maintenance Primitives: Adds an endpoint for
transitioning agents back into UP mode.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37362/
-----------------------------------------------------------
(Updated Aug. 28, 2015, 4:20 p.m.)
Review request for mesos, Benjamin Hindman, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, and Vinod Kone.
Changes
-------
Rebased + changes from previous reviews.
Summary (updated)
-----------------
Maintenance Primitives: Adds an endpoint for transitioning agents back into UP mode.
Bugs: MESOS-2067 and MESOS-3069
https://issues.apache.org/jira/browse/MESOS-2067
https://issues.apache.org/jira/browse/MESOS-3069
Repository: mesos
Description (updated)
-------
Endpoint: /machine/up
Registry operation = maintenance::StopMaintenance
Sets the list of machines back to UP mode. Removes those machines from the maintenance schedule.
Diffs (updated)
-----
src/master/http.cpp 37d76ee72f6a037f551bf2609e9393e16b496e44
src/master/maintenance.hpp PRE-CREATION
src/master/maintenance.cpp PRE-CREATION
src/master/master.hpp 36c67599ef2c470da8d95f2caf926a154342d2cc
src/master/master.cpp 95207d24db0aa052eb70c4cc7eb75d0611c365cf
src/tests/master_maintenance_tests.cpp PRE-CREATION
src/tests/registrar_tests.cpp 032e644ee19751b4ce5767d46f474d34ec4b9166
Diff: https://reviews.apache.org/r/37362/diff/
Testing (updated)
-------
`make check`
New Tests:
RegistrarTest.StopMaintenance
Schedules some machines. Deactivates some. Reactivates some.
MasterMaintenanceTest.BringUpMachines
Tests some invalid lists.
Schedules some machines. Deactivates some. Tests some valid and invalid lists.
Checks that the schedule is modified.
Thanks,
Joseph Wu
Re: Review Request 37362: Maintenance Primitives: Adds an endpoint for
transitioning agents back into Normal mode.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37362/
-----------------------------------------------------------
(Updated Aug. 26, 2015, 3:30 p.m.)
Review request for mesos, Benjamin Hindman, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, and Vinod Kone.
Changes
-------
Update to match comments and changes in earlier reviews.
Bugs: MESOS-2067 and MESOS-3069
https://issues.apache.org/jira/browse/MESOS-2067
https://issues.apache.org/jira/browse/MESOS-3069
Repository: mesos
Description
-------
Endpoint: /maintenance.stop
Registry operation = maintenance::StopMaintenance
Sets the list of machines back to Normal mode. Removes those machines from the maintenance schedule.
Diffs (updated)
-----
src/master/http.cpp 37d76ee72f6a037f551bf2609e9393e16b496e44
src/master/maintenance.hpp PRE-CREATION
src/master/maintenance.cpp PRE-CREATION
src/master/master.hpp 36c67599ef2c470da8d95f2caf926a154342d2cc
src/master/master.cpp 95207d24db0aa052eb70c4cc7eb75d0611c365cf
src/tests/master_maintenance_tests.cpp PRE-CREATION
src/tests/registrar_tests.cpp 032e644ee19751b4ce5767d46f474d34ec4b9166
Diff: https://reviews.apache.org/r/37362/diff/
Testing
-------
`make check`
New Tests:
RegistrarTest.StopMaintenance
Schedules some machines. Deactivates some. Reactivates some.
MasterMaintenanceTest.ReactivateMachines
Tests some invalid lists.
Schedules some machines. Deactivates some. Tests some valid and invalid lists.
Checks that the schedule is modified.
Thanks,
Joseph Wu
Re: Review Request 37362: Maintenance Primitives: Adds an endpoint for
transitioning agents back into Normal mode.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37362/
-----------------------------------------------------------
(Updated Aug. 25, 2015, 10:03 a.m.)
Review request for mesos, Benjamin Hindman, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, and Vinod Kone.
Changes
-------
Adjust some spacing in the tests (correcting the style).
Bugs: MESOS-2067 and MESOS-3069
https://issues.apache.org/jira/browse/MESOS-2067
https://issues.apache.org/jira/browse/MESOS-3069
Repository: mesos
Description
-------
Endpoint: /maintenance.stop
Registry operation = maintenance::StopMaintenance
Sets the list of machines back to Normal mode. Removes those machines from the maintenance schedule.
Diffs (updated)
-----
src/master/http.cpp 37d76ee72f6a037f551bf2609e9393e16b496e44
src/master/maintenance.hpp PRE-CREATION
src/master/maintenance.cpp PRE-CREATION
src/master/master.hpp 36c67599ef2c470da8d95f2caf926a154342d2cc
src/master/master.cpp 95207d24db0aa052eb70c4cc7eb75d0611c365cf
src/tests/master_maintenance_tests.cpp PRE-CREATION
src/tests/registrar_tests.cpp 032e644ee19751b4ce5767d46f474d34ec4b9166
Diff: https://reviews.apache.org/r/37362/diff/
Testing
-------
`make check`
New Tests:
RegistrarTest.StopMaintenance
Schedules some machines. Deactivates some. Reactivates some.
MasterMaintenanceTest.ReactivateMachines
Tests some invalid lists.
Schedules some machines. Deactivates some. Tests some valid and invalid lists.
Checks that the schedule is modified.
Thanks,
Joseph Wu