You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Mark Thomas <ma...@apache.org> on 2014/02/27 20:42:53 UTC
[VOTE] Release Apache Commons DBCP 2.0 based on RC1
It has been a while since it was first suggested but we have reached the
point where DBCP 2.0 is ready for release.
The significant changes are:
- switched to Pool 2 for better performance
- added JMX support
We have also fixed quite a few bugs
DBCP 2.0 RC1 is available for review here:
https://dist.apache.org/repos/dist/dev/commons/dbcp/
(svn revision 4529)
Maven artifacts are here:
https://repository.apache.org/content/repositories/orgapachecommons-1011/
Details of changes since 1.x are in the release notes and changelog:
https://dist.apache.org/repos/dist/dev/commons/dbcp/RELEASE-NOTES.txt
http://people.apache.org/~markt/dev/DBCP-2.0-RC1-site/changes-report.html
The tag is here:
http://svn.apache.org/viewvc/commons/proper/dbcp/tags/DBCP_2_0_RC1/
(svn revision 1572625)
Site:
http://people.apache.org/~markt/dev/DBCP-2.0-RC1-site/index.html
(NB Javadoc links won't work - they'll find fine when deployed)
KEYS:
http://www.apache.org/dist/commons/KEYS
Please review the release candidate and vote.
This vote will close no sooner that 72 hours from now.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [VOTE] Release Apache Commons DBCP 2.0 based on RC1
Posted by Gary Gregory <ga...@gmail.com>.
While it exists in 1.x, the package org.apache.commons.dbcp.cpdsadapter
would be could have a better, simpler name like
org.apache.commons.dbcp2.cpds and some package level docs just to say what
CPDS even is for our first time users.
Aside from that, builds OK from zip src (hash and sig OK) with 'mvn clean
site':
Apache Maven 3.2.1 (ea8b2b07643dbb1b84b6d16e1f08391b666bc1e9;
2014-02-14T12:37:52-05:00)
Maven home: C:\Java\apache-maven-3.2.1\bin\..
Java version: 1.7.0_51, vendor: Oracle Corporation
Java home: C:\Program Files\Java\jdk1.7.0_51\jre
Default locale: en_US, platform encoding: Cp1252
OS name: "windows 7", version: "6.1", arch: "amd64", family: "windows"
Reports look good except one:
I got 54 checkstyle errors, all "File does not end with a newline." on line
0. Looking at one error I do not have the source xref generated.
Looking at the 1st link for such a line 0 I get a broken link for:
file:///C:/temp/rc/commons-dbcp2-2.0-src/target/site/xref/src/main/java/org/apache/commons/dbcp2/AbandonedTrace.html#0
When I look at the source xref report I see the HTML file here:
file:///C:/temp/rc/commons-dbcp2-2.0-src/target/site/xref/org/apache/commons/dbcp2/AbandonedTrace.html
+1
Gary
On Thu, Feb 27, 2014 at 2:42 PM, Mark Thomas <ma...@apache.org> wrote:
> It has been a while since it was first suggested but we have reached the
> point where DBCP 2.0 is ready for release.
>
> The significant changes are:
> - switched to Pool 2 for better performance
> - added JMX support
>
> We have also fixed quite a few bugs
>
> DBCP 2.0 RC1 is available for review here:
> https://dist.apache.org/repos/dist/dev/commons/dbcp/
> (svn revision 4529)
>
> Maven artifacts are here:
>
> https://repository.apache.org/content/repositories/orgapachecommons-1011/
>
> Details of changes since 1.x are in the release notes and changelog:
> https://dist.apache.org/repos/dist/dev/commons/dbcp/RELEASE-NOTES.txt
>
> http://people.apache.org/~markt/dev/DBCP-2.0-RC1-site/changes-report.html
>
> The tag is here:
> http://svn.apache.org/viewvc/commons/proper/dbcp/tags/DBCP_2_0_RC1/
> (svn revision 1572625)
>
> Site:
> http://people.apache.org/~markt/dev/DBCP-2.0-RC1-site/index.html
> (NB Javadoc links won't work - they'll find fine when deployed)
>
> KEYS:
> http://www.apache.org/dist/commons/KEYS
>
> Please review the release candidate and vote.
> This vote will close no sooner that 72 hours from now.
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
--
E-Mail: garydgregory@gmail.com | ggregory@apache.org
Java Persistence with Hibernate, Second Edition<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory
Re: [VOTE] Release Apache Commons DBCP 2.0 based on RC1
Posted by Benedikt Ritter <br...@apache.org>.
2014-02-28 14:55 GMT+01:00 Mark Thomas <ma...@apache.org>:
> On 28/02/2014 09:59, Benedikt Ritter wrote:
>
> > I've found one strange thing. When comparing the contents of the
> src.tar.gz
> > with the tag I get the following output:
> >
> > bene@localhost:~/workspace/apache/release-tools/dbcp2$ diff -q
> > commons-dbcp2-2.0-src DBCP_2_0_RC1/
> > Only in DBCP_2_0_RC1/: .svn
> > Files commons-dbcp2-2.0-src/LICENSE.txt and DBCP_2_0_RC1/LICENSE.txt
> differ
> > Files commons-dbcp2-2.0-src/NOTICE.txt and DBCP_2_0_RC1/NOTICE.txt differ
> > Files commons-dbcp2-2.0-src/README.txt and DBCP_2_0_RC1/README.txt differ
> > Files commons-dbcp2-2.0-src/build.properties.sample and
> > DBCP_2_0_RC1/build.properties.sample differ
> > Files commons-dbcp2-2.0-src/build.xml and DBCP_2_0_RC1/build.xml differ
> > Files commons-dbcp2-2.0-src/checkstyle.xml and
> DBCP_2_0_RC1/checkstyle.xml
> > differ
> > Only in DBCP_2_0_RC1/: doap_dbcp.rdf
> > Common subdirectories: commons-dbcp2-2.0-src/doc and DBCP_2_0_RC1/doc
> > Files commons-dbcp2-2.0-src/findbugs-exclude-filter.xml and
> > DBCP_2_0_RC1/findbugs-exclude-filter.xml differ
> > Files commons-dbcp2-2.0-src/pom.xml and DBCP_2_0_RC1/pom.xml differ
> > Common subdirectories: commons-dbcp2-2.0-src/src and DBCP_2_0_RC1/src
> > Files commons-dbcp2-2.0-src/test-jar.xml and DBCP_2_0_RC1/test-jar.xml
> > differ
> >
> > And for all the differing files the result is:
> >
> > bene@localhost:~/workspace/apache/release-tools/dbcp2$ diff
> > commons-dbcp2-2.0-src/LICENSE.txt DBCP_2_0_RC1/LICENSE.txt
> > 202c202
> > < limitations under the License.
> > \ No newline at end of file
> > ---
> >> limitations under the License.
> >
> > Can this be caused by the SVN checkout? I don't understand this.
>
> It isn't the svn checkout, it is the Maven assembly plug-in. I added the
> lineEnding option to ensure files in the zip has crlf endings and those
> in the tar.gz had lf endings. That process appears to trim some line
> endings.
>
This is no release blocker for me.
+1
>
> > If there is an explanation for the differing files, you have my +1 :-)
>
> Mark
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
--
http://people.apache.org/~britter/
http://www.systemoutprintln.de/
http://twitter.com/BenediktRitter
http://github.com/britter
Re: [VOTE] Release Apache Commons DBCP 2.0 based on RC1
Posted by Mark Thomas <ma...@apache.org>.
On 28/02/2014 09:59, Benedikt Ritter wrote:
> I've found one strange thing. When comparing the contents of the src.tar.gz
> with the tag I get the following output:
>
> bene@localhost:~/workspace/apache/release-tools/dbcp2$ diff -q
> commons-dbcp2-2.0-src DBCP_2_0_RC1/
> Only in DBCP_2_0_RC1/: .svn
> Files commons-dbcp2-2.0-src/LICENSE.txt and DBCP_2_0_RC1/LICENSE.txt differ
> Files commons-dbcp2-2.0-src/NOTICE.txt and DBCP_2_0_RC1/NOTICE.txt differ
> Files commons-dbcp2-2.0-src/README.txt and DBCP_2_0_RC1/README.txt differ
> Files commons-dbcp2-2.0-src/build.properties.sample and
> DBCP_2_0_RC1/build.properties.sample differ
> Files commons-dbcp2-2.0-src/build.xml and DBCP_2_0_RC1/build.xml differ
> Files commons-dbcp2-2.0-src/checkstyle.xml and DBCP_2_0_RC1/checkstyle.xml
> differ
> Only in DBCP_2_0_RC1/: doap_dbcp.rdf
> Common subdirectories: commons-dbcp2-2.0-src/doc and DBCP_2_0_RC1/doc
> Files commons-dbcp2-2.0-src/findbugs-exclude-filter.xml and
> DBCP_2_0_RC1/findbugs-exclude-filter.xml differ
> Files commons-dbcp2-2.0-src/pom.xml and DBCP_2_0_RC1/pom.xml differ
> Common subdirectories: commons-dbcp2-2.0-src/src and DBCP_2_0_RC1/src
> Files commons-dbcp2-2.0-src/test-jar.xml and DBCP_2_0_RC1/test-jar.xml
> differ
>
> And for all the differing files the result is:
>
> bene@localhost:~/workspace/apache/release-tools/dbcp2$ diff
> commons-dbcp2-2.0-src/LICENSE.txt DBCP_2_0_RC1/LICENSE.txt
> 202c202
> < limitations under the License.
> \ No newline at end of file
> ---
>> limitations under the License.
>
> Can this be caused by the SVN checkout? I don't understand this.
It isn't the svn checkout, it is the Maven assembly plug-in. I added the
lineEnding option to ensure files in the zip has crlf endings and those
in the tar.gz had lf endings. That process appears to trim some line
endings.
> If there is an explanation for the differing files, you have my +1 :-)
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [VOTE] Release Apache Commons DBCP 2.0 based on RC1
Posted by Benedikt Ritter <br...@apache.org>.
Hello Mark,
the build works fine from sources in my env:
Apache Maven 3.2.1 (ea8b2b07643dbb1b84b6d16e1f08391b666bc1e9;
2014-02-14T18:37:52+01:00)
Maven home: /usr/local/Cellar/maven/3.2.1/libexec
Java version: 1.7.0_45, vendor: Oracle Corporation
Java home:
/Library/Java/JavaVirtualMachines/jdk1.7.0_45.jdk/Contents/Home/jre
Default locale: de_DE, platform encoding: UTF-8
OS name: "mac os x", version: "10.9.2", arch: "x86_64", family: "mac"
I've found one strange thing. When comparing the contents of the src.tar.gz
with the tag I get the following output:
bene@localhost:~/workspace/apache/release-tools/dbcp2$ diff -q
commons-dbcp2-2.0-src DBCP_2_0_RC1/
Only in DBCP_2_0_RC1/: .svn
Files commons-dbcp2-2.0-src/LICENSE.txt and DBCP_2_0_RC1/LICENSE.txt differ
Files commons-dbcp2-2.0-src/NOTICE.txt and DBCP_2_0_RC1/NOTICE.txt differ
Files commons-dbcp2-2.0-src/README.txt and DBCP_2_0_RC1/README.txt differ
Files commons-dbcp2-2.0-src/build.properties.sample and
DBCP_2_0_RC1/build.properties.sample differ
Files commons-dbcp2-2.0-src/build.xml and DBCP_2_0_RC1/build.xml differ
Files commons-dbcp2-2.0-src/checkstyle.xml and DBCP_2_0_RC1/checkstyle.xml
differ
Only in DBCP_2_0_RC1/: doap_dbcp.rdf
Common subdirectories: commons-dbcp2-2.0-src/doc and DBCP_2_0_RC1/doc
Files commons-dbcp2-2.0-src/findbugs-exclude-filter.xml and
DBCP_2_0_RC1/findbugs-exclude-filter.xml differ
Files commons-dbcp2-2.0-src/pom.xml and DBCP_2_0_RC1/pom.xml differ
Common subdirectories: commons-dbcp2-2.0-src/src and DBCP_2_0_RC1/src
Files commons-dbcp2-2.0-src/test-jar.xml and DBCP_2_0_RC1/test-jar.xml
differ
And for all the differing files the result is:
bene@localhost:~/workspace/apache/release-tools/dbcp2$ diff
commons-dbcp2-2.0-src/LICENSE.txt DBCP_2_0_RC1/LICENSE.txt
202c202
< limitations under the License.
\ No newline at end of file
---
> limitations under the License.
Can this be caused by the SVN checkout? I don't understand this.
- The signs look good.
- Site looks good.
- Test coverage is very low (below 50% in some of the packages)
- Maybe we can add PMD and CPD after this release?
If there is an explanation for the differing files, you have my +1 :-)
Benedikt
2014-02-27 20:42 GMT+01:00 Mark Thomas <ma...@apache.org>:
> It has been a while since it was first suggested but we have reached the
> point where DBCP 2.0 is ready for release.
>
> The significant changes are:
> - switched to Pool 2 for better performance
> - added JMX support
>
> We have also fixed quite a few bugs
>
> DBCP 2.0 RC1 is available for review here:
> https://dist.apache.org/repos/dist/dev/commons/dbcp/
> (svn revision 4529)
>
> Maven artifacts are here:
>
> https://repository.apache.org/content/repositories/orgapachecommons-1011/
>
> Details of changes since 1.x are in the release notes and changelog:
> https://dist.apache.org/repos/dist/dev/commons/dbcp/RELEASE-NOTES.txt
>
> http://people.apache.org/~markt/dev/DBCP-2.0-RC1-site/changes-report.html
>
> The tag is here:
> http://svn.apache.org/viewvc/commons/proper/dbcp/tags/DBCP_2_0_RC1/
> (svn revision 1572625)
>
> Site:
> http://people.apache.org/~markt/dev/DBCP-2.0-RC1-site/index.html
> (NB Javadoc links won't work - they'll find fine when deployed)
>
> KEYS:
> http://www.apache.org/dist/commons/KEYS
>
> Please review the release candidate and vote.
> This vote will close no sooner that 72 hours from now.
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
--
http://people.apache.org/~britter/
http://www.systemoutprintln.de/
http://twitter.com/BenediktRitter
http://github.com/britter
Re: [VOTE] Release Apache Commons DBCP 2.0 based on RC1
Posted by Phil Steitz <ph...@gmail.com>.
Checked maven and ant builds on JDK 1.7.0_45, OSX. I had to update
the pool dependency in build.properties.sample, but this is not a
blocker (fixed in trunk).
Hashes and sigs are good.
Release notes, contents of zips, tarballs look good.
+1
Phil
On 2/27/14, 11:42 AM, Mark Thomas wrote:
> It has been a while since it was first suggested but we have reached the
> point where DBCP 2.0 is ready for release.
>
> The significant changes are:
> - switched to Pool 2 for better performance
> - added JMX support
>
> We have also fixed quite a few bugs
>
> DBCP 2.0 RC1 is available for review here:
> https://dist.apache.org/repos/dist/dev/commons/dbcp/
> (svn revision 4529)
>
> Maven artifacts are here:
> https://repository.apache.org/content/repositories/orgapachecommons-1011/
>
> Details of changes since 1.x are in the release notes and changelog:
> https://dist.apache.org/repos/dist/dev/commons/dbcp/RELEASE-NOTES.txt
> http://people.apache.org/~markt/dev/DBCP-2.0-RC1-site/changes-report.html
>
> The tag is here:
> http://svn.apache.org/viewvc/commons/proper/dbcp/tags/DBCP_2_0_RC1/
> (svn revision 1572625)
>
> Site:
> http://people.apache.org/~markt/dev/DBCP-2.0-RC1-site/index.html
> (NB Javadoc links won't work - they'll find fine when deployed)
>
> KEYS:
> http://www.apache.org/dist/commons/KEYS
>
> Please review the release candidate and vote.
> This vote will close no sooner that 72 hours from now.
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
[RESULT][VOTE] Release Apache Commons DBCP 2.0 based on RC1
Posted by Mark Thomas <ma...@apache.org>.
The following votes were cast:
Binding:
+1: ggregory, markt, britter, psteitz
No other votes were cast.
The vote therefore passes.
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [VOTE] Release Apache Commons DBCP 2.0 based on RC1
Posted by Mark Thomas <ma...@apache.org>.
On 27/02/2014 19:42, Mark Thomas wrote:
> It has been a while since it was first suggested but we have reached the
> point where DBCP 2.0 is ready for release.
+1
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org