You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Svet <no...@github.com> on 2017/03/18 16:40:16 UTC
[jclouds/jclouds-cli] Reference super features in assembly module
(#37)
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds-cli/pull/37
-- Commit Summary --
* Reference super features in assembly module
-- File Changes --
M assembly/pom.xml (60)
-- Patch Links --
https://github.com/jclouds/jclouds-cli/pull/37.patch
https://github.com/jclouds/jclouds-cli/pull/37.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-cli/pull/37
Re: [jclouds/jclouds-cli] Reference super features in assembly module
(#37)
Posted by Svet <no...@github.com>.
neykov commented on this pull request.
> </descriptors>
<features>
<feature>config</feature>
- <feature>jclouds</feature>
- <feature>jclouds-commands</feature>
- <feature>jclouds-compute</feature>
- <feature>jclouds-guice</feature>
`jclouds-guice`, `jclouds` is included by `jclouds-compute` and it is included by all the compute features. `jclouds-commands` is kept further below. It's like maven transitive features, don't need to mention them if we don't directly depend on them.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-cli/pull/37#discussion_r106787537
Re: [jclouds/jclouds-cli] Reference super features in assembly module
(#37)
Posted by Andrea Turli <no...@github.com>.
@neykov I assume this will work once we merge jclouds-karaf#98 right?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-cli/pull/37#issuecomment-287559924
Re: [jclouds/jclouds-cli] Reference super features in assembly module
(#37)
Posted by Andrew Phillips <no...@github.com>.
Closed #37.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-cli/pull/37#event-1006070188
Re: [jclouds/jclouds-cli] Reference super features in assembly module
(#37)
Posted by Ignasi Barrera <no...@github.com>.
As part of the recent Karaf fixes we already changed the assembly pom to reference the super-features. Can we close this PR?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-cli/pull/37#issuecomment-305091831
Re: [jclouds/jclouds-cli] Reference super features in assembly module
(#37)
Posted by Svet <no...@github.com>.
Correction on my comment above @andreaturli. This does require https://github.com/jclouds/jclouds-karaf/pull/98 to build successfully. And https://github.com/jclouds/jclouds-karaf/pull/99 is not needed, it's just good to have.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-cli/pull/37#issuecomment-287624286
Re: [jclouds/jclouds-cli] Reference super features in assembly module
(#37)
Posted by Svet <no...@github.com>.
@nacx you beat me to it. I'll give updating the commands a go.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-cli/pull/37#issuecomment-289388616
Re: [jclouds/jclouds-cli] Reference super features in assembly module
(#37)
Posted by Andrew Phillips <no...@github.com>.
Reopened #37.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-cli/pull/37#event-1006070207
Re: [jclouds/jclouds-cli] Reference super features in assembly module
(#37)
Posted by Svet <no...@github.com>.
Closed #37.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-cli/pull/37#event-1103788916
Re: [jclouds/jclouds-cli] Reference super features in assembly module
(#37)
Posted by Ignasi Barrera <no...@github.com>.
Nice catch @neykov! I'd say the CLI should always be aligned with this (which was upgraded in the refactor PR):
https://github.com/jclouds/jclouds-karaf/blob/master/pom.xml#L214
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-cli/pull/37#issuecomment-288092891
Re: [jclouds/jclouds-cli] Reference super features in assembly module
(#37)
Posted by Andrew Phillips <no...@github.com>.
demobox commented on this pull request.
> </descriptors>
<features>
<feature>config</feature>
- <feature>jclouds</feature>
- <feature>jclouds-commands</feature>
- <feature>jclouds-compute</feature>
- <feature>jclouds-guice</feature>
> It's like maven transitive features, don't need to mention them if we don't directly depend on them.
Thanks for clarifying. I suspected as much, but I think we may be specifying similar features elsewhere - not sure why, perhaps for clarity?
But it's a minor comment - just wondering what the most consistent approach for this refactoring is, that's all.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-cli/pull/37#discussion_r106825291
Re: [jclouds/jclouds-cli] Reference super features in assembly module
(#37)
Posted by Andrew Phillips <no...@github.com>.
Closing and reopening to trigger a rebuild
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-cli/pull/37#issuecomment-287663243
Re: [jclouds/jclouds-cli] Reference super features in assembly module
(#37)
Posted by Svet <no...@github.com>.
Tested successfully on top of both https://github.com/jclouds/jclouds-karaf/pull/100 and https://github.com/jclouds/jclouds-karaf/pull/99.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-cli/pull/37#issuecomment-287800676
Re: [jclouds/jclouds-cli] Reference super features in assembly module
(#37)
Posted by Andrew Phillips <no...@github.com>.
retest this please
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-cli/pull/37#issuecomment-287665192
Re: [jclouds/jclouds-cli] Reference super features in assembly module
(#37)
Posted by Andrew Phillips <no...@github.com>.
> Should we ping the dormant karaf guys in our mailing list, or ping the Apache Karaf dev@ list?
@nacx I suspect the Karaf dev@ list might be a better bet, specifically for finding suitable replacements/alternative approaches for those classes.
@neykov Thanks for having a go at updating the commands!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-cli/pull/37#issuecomment-289446456
Re: [jclouds/jclouds-cli] Reference super features in assembly module
(#37)
Posted by Andrew Phillips <no...@github.com>.
> 1 failing check
```
[ERROR] Failed to execute goal org.apache.karaf.tooling:features-maven-plugin:2.3.11:add-features-to-repo (add-features-to-repo) on project jclouds-cli-assembly: Error populating repository: Unable to find the feature 'jclouds-labs-all-compute' -> [Help 1]
```
I think this may be because the [jclouds-karaf build](https://jclouds.ci.cloudbees.com/job/jclouds-karaf/2124/) for the merge of jclouds/jclouds-karaf#98 is still running. Will try again once that's completed.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-cli/pull/37#issuecomment-287663806
Re: [jclouds/jclouds-cli] Reference super features in assembly module
(#37)
Posted by Andrea Turli <no...@github.com>.
lgtm
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-cli/pull/37#issuecomment-287603210
Re: [jclouds/jclouds-cli] Reference super features in assembly module
(#37)
Posted by Andrew Phillips <no...@github.com>.
demobox commented on this pull request.
> </descriptors>
<features>
<feature>config</feature>
- <feature>jclouds</feature>
- <feature>jclouds-commands</feature>
- <feature>jclouds-compute</feature>
- <feature>jclouds-guice</feature>
Do we need to keep these? They are not directly included by the macro features, from what I can see?
Even if they don't _need_ to be included, would it be clearer to keep them?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-cli/pull/37#pullrequestreview-27729307
Re: [jclouds/jclouds-cli] Reference super features in assembly module
(#37)
Posted by Andrew Phillips <no...@github.com>.
@neykov Thanks for taking care of this! One thing: since I suspect the tests for the CLI are not entirely conclusive, please package a distribution from this branch and test it locally.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-cli/pull/37#issuecomment-287560748
Re: [jclouds/jclouds-cli] Reference super features in assembly module
(#37)
Posted by Ignasi Barrera <no...@github.com>.
Looks like we need to bring this back to the features pom.xml in jclouds-karaf?
https://github.com/jclouds/jclouds-karaf/blob/2.0.x/feature/pom.xml#L34-L91
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-cli/pull/37#issuecomment-287683273
Re: [jclouds/jclouds-cli] Reference super features in assembly module
(#37)
Posted by Andrew Phillips <no...@github.com>.
> I've tried the distribution with bin/jclouds - it's working as expected.
Ah, great - thanks for the additional testing!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-cli/pull/37#issuecomment-287662250
Re: [jclouds/jclouds-cli] Reference super features in assembly module
(#37)
Posted by Svet <no...@github.com>.
@andreaturli This doesn't need `jclouds-karaf#98`. It's just for backwards compatibility.
@demobox I've tried the distribution with `bin/jclouds` - it's working as expected.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-cli/pull/37#issuecomment-287564428
Re: [jclouds/jclouds-cli] Reference super features in assembly module
(#37)
Posted by Andrew Phillips <no...@github.com>.
> Can't resolve bundle org.apache.jclouds.karaf:jclouds-karaf:cfg:shell:2.1.0-SNAPSHOT: Could not find artifact org.apache.jclouds.karaf:jclouds-karaf:cfg:shell:2.1.0-SNAPSHOT
Hm, so we are indeed publishing less to snapshots via the Jenkins build than we are during (I suspect) the release process. Compare [the 2.0.1 release](https://repository.apache.org/content/groups/public/org/apache/jclouds/karaf/jclouds-karaf/2.0.1/):
```
Parent Directory
jclouds-karaf-2.0.1-credentials.cfg Wed Feb 22 11:33:38 UTC 2017 823
...
jclouds-karaf-2.0.1-features.xml Wed Feb 22 11:33:35 UTC 2017 28458
...
jclouds-karaf-2.0.1-shell.cfg Wed Feb 22 11:33:39 UTC 2017 2270
...
jclouds-karaf-2.0.1.pom Wed Feb 22 11:33:31 UTC 2017 7502
...
```
with [2.1.0-SNAPSHOT](https://repository.apache.org/content/groups/snapshots/org/apache/jclouds/karaf/jclouds-karaf/2.1.0-SNAPSHOT/):
```
jclouds-karaf-2.1.0-20170320.011813-88-features.xml Mon Mar 20 01:18:14 UTC 2017 43203
...
jclouds-karaf-2.1.0-20170320.011813-88.pom Mon Mar 20 01:18:13 UTC 2017 1670
...
maven-metadata.xml Mon Mar 20 01:18:14 UTC 2017 832
maven-metadata.xml.md5 Mon Mar 20 01:46:47 UTC 2017 33
maven-metadata.xml.sha1 Mon Mar 20 01:46:47 UTC 2017 41
```
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-cli/pull/37#issuecomment-287666026
Re: [jclouds/jclouds-cli] Reference super features in assembly module
(#37)
Posted by Svet <no...@github.com>.
Nice find @demobox, @nacx - added it back in https://github.com/jclouds/jclouds-karaf/pull/100.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-cli/pull/37#issuecomment-287789846
Re: [jclouds/jclouds-cli] Reference super features in assembly module
(#37)
Posted by Ignasi Barrera <no...@github.com>.
I actually tried to upgrade the version of karaf in the CLI but all the Console classes used in the CLI runner are deprecated and I have not been able to find proper documentation for their replacement. I tried changing them for the classes I thought could do the same (^^) but no success. I got errors about console classes not being found, and others I don't fully understand.
@neykov @demobox You are more familiar with Karaf than me. Do you think you could have a look at this? Should we ping the dormant karaf guys in our mailing list, or ping the Apache Karaf dev@ list?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-cli/pull/37#issuecomment-289365566
Re: [jclouds/jclouds-cli] Reference super features in assembly module
(#37)
Posted by Andrew Phillips <no...@github.com>.
> 1 failing check
Hrm...now failing with the following?
```
[ERROR] Failed to execute goal org.apache.karaf.tooling:features-maven-plugin:2.3.11:add-features-to-repo (add-features-to-repo) on project jclouds-cli-assembly: Can't resolve bundle org.apache.jclouds.karaf:jclouds-karaf:cfg:shell:2.1.0-SNAPSHOT: Could not find artifact org.apache.jclouds.karaf:jclouds-karaf:cfg:shell:2.1.0-SNAPSHOT in cloudbees-private-snapshot-
```
/cc @neykov @andreaturli @nacx Any thoughts on where that might be coming from?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-cli/pull/37#issuecomment-287665477