You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/04/16 06:28:46 UTC
[GitHub] [flink] JingsongLi commented on a change in pull request #11726:
[FLINK-17128][table] Add isBounded to TableSinkFactory#Context
JingsongLi commented on a change in pull request #11726: [FLINK-17128][table] Add isBounded to TableSinkFactory#Context
URL: https://github.com/apache/flink/pull/11726#discussion_r409311341
##########
File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/factories/TableSinkFactory.java
##########
@@ -98,6 +98,11 @@
* {@code TableEnvironment} session configurations.
*/
ReadableConfig getConfiguration();
+
+ /**
+ * @return true if input of the sink is bounded, otherwise it is a unbounded input.
Review comment:
```
Now it depends on whether the {@link TableEnvironment} execution mode is batch.
In the future, the new sink interface will infer from input to source, see {@link Source#getBoundedness}.
```
What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services