[jira] [Closed] (JAMES-2854) Rework ConfigurationPerformer

["Tellier Benoit (Jira)" <se...@james.apache.org>]

     [ https://issues.apache.org/jira/browse/JAMES-2854?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tellier Benoit closed JAMES-2854.
---------------------------------
    Fix Version/s: 3.4.0
       Resolution: Fixed

https://github.com/linagora/james-project/pull/2575 fixed this

> Rework ConfigurationPerformer
> -----------------------------
>
>                 Key: JAMES-2854
>                 URL: https://issues.apache.org/jira/browse/JAMES-2854
>             Project: James Server
>          Issue Type: Improvement
>          Components: guice
>            Reporter: Tellier Benoit
>            Priority: Major
>             Fix For: 3.4.0
>
>
> I have currently several issues with Configuration Performer class in Guice:
>  - 1.  ConfigurationPerformer should be bound to a single startable
> Loops are supported by injection framework through stubbing. However, this
> does not play well with the "initialization will follow injection path"
> strategy: some modules might try to init against "not yet initialized" components
> that was stubbed by the init strategy.
>     
> The issue here is that multi-components configuration performers add additional complexity,
> and creates dependencies (init A & B at the same time) that lead to failures
> while modifying some injections.
>     
> Saying "1 startable = 1 performer" prevents us from this, and fits our usage.
>  - 2. ConfigurationPerformer::initModule should be able to throw Exception
>     
>      - Avoid unnecessary exception forwarding hurting exception readability
>      - This is our "most common" use case, and leveraging it correctly saves lines of code
>  - 3. ConfigurationPerformer name itself: Component initialization is not necessarily linked to configuration. This history inherited wording is confusing thus harmful...



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org