[GitHub] peng-yongsheng commented on a change in pull request #1086: Provide new trace query protocol

[GitBox <gi...@apache.org>]

peng-yongsheng commented on a change in pull request #1086: Provide new trace query protocol
URL: https://github.com/apache/incubator-skywalking/pull/1086#discussion_r182285070
 
 

 ##########
 File path: apm-protocol/apm-ui-protocol/src/main/resources/ui-graphql/trace.graphqls
 ##########
 @@ -52,16 +52,48 @@ enum QueryOrder {
 
 # The trace represents a distributed trace, includes all segments and spans.
 type Trace {
+  segments: [Segment!]!
+  # Segment IDs in refs may not exist in #segments list, because MQ batch process trace segments didn't share the same ID.
+  # UI should add visual node for non-exist segment.
+  refs: [SegmentRef!]!
+}
+
+type Segment {
 
 Review comment:
   Some attribute need explain, e.g. name, brief.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services