You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/06/05 10:39:26 UTC

[GitHub] [hadoop-ozone] bshashikant opened a new pull request #1026: HDDS-3330. TestDeleteWithSlowFollower is still flaky.

bshashikant opened a new pull request #1026:
URL: https://github.com/apache/hadoop-ozone/pull/1026


   ## What changes were proposed in this pull request?
   
   Increased the watch timeout so that key.close() succeeds on the same pipeline with majority commit. Added some precondition checks to validate the follower.
   
   ## What is the link to the Apache JIRA
   https://issues.apache.org/jira/browse/HDDS-3330
   
   ## How was this patch tested?
   manual running the test.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org

[GitHub] [hadoop-ozone] bshashikant commented on a change in pull request #1026: HDDS-3330. TestDeleteWithSlowFollower is still flaky.

Posted by GitBox <gi...@apache.org>.
bshashikant commented on a change in pull request #1026:
URL: https://github.com/apache/hadoop-ozone/pull/1026#discussion_r435987430



##########
File path: hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/client/rpc/TestDeleteWithSlowFollower.java
##########
@@ -221,7 +223,9 @@ public void testDeleteKeyWithSlowFollower() throws Exception {
     }
     Assert.assertNotNull(follower);
     Assert.assertNotNull(leader);
-    // shutdown the slow follower
+    //ensure that the chosen follower is still a follower
+    Assert.assertTrue(ContainerTestHelper.isRatisFollower(follower, pipeline));

Review comment:
       There are no failures being induced till this check so, follower should still be a follower. I would prefer to fail the test in that case.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org

[GitHub] [hadoop-ozone] bshashikant merged pull request #1026: HDDS-3330. TestDeleteWithSlowFollower is still flaky.

Posted by GitBox <gi...@apache.org>.
bshashikant merged pull request #1026:
URL: https://github.com/apache/hadoop-ozone/pull/1026


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org

[GitHub] [hadoop-ozone] bshashikant commented on pull request #1026: HDDS-3330. TestDeleteWithSlowFollower is still flaky.

Posted by GitBox <gi...@apache.org>.
bshashikant commented on pull request #1026:
URL: https://github.com/apache/hadoop-ozone/pull/1026#issuecomment-641004700


   Thanks @adoroszlai for the review. I have committed this.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org

[GitHub] [hadoop-ozone] adoroszlai commented on a change in pull request #1026: HDDS-3330. TestDeleteWithSlowFollower is still flaky.

Posted by GitBox <gi...@apache.org>.
adoroszlai commented on a change in pull request #1026:
URL: https://github.com/apache/hadoop-ozone/pull/1026#discussion_r435967401



##########
File path: hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/client/rpc/TestDeleteWithSlowFollower.java
##########
@@ -221,7 +223,9 @@ public void testDeleteKeyWithSlowFollower() throws Exception {
     }
     Assert.assertNotNull(follower);
     Assert.assertNotNull(leader);
-    // shutdown the slow follower
+    //ensure that the chosen follower is still a follower
+    Assert.assertTrue(ContainerTestHelper.isRatisFollower(follower, pipeline));

Review comment:
       Do we want to fail the test if `follower` is no longer a follower, or should we just ignore test result in that case?  If the latter, it may be better to change this to `Assume.assumeTrue`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org