You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2021/08/13 03:50:38 UTC
[GitHub] [calcite] wojustme opened a new pull request #2484: Fix `SubstitutionVisitor#getRexShuttle` bug, when meeting same rexnode.
wojustme opened a new pull request #2484:
URL: https://github.com/apache/calcite/pull/2484
…ng same rexnode.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] yanlin-Lynn commented on pull request #2484: [CALCITE-4734] CalcToCalcUnifyRule build shuttle error, when meeting more same rexnode in target.
Posted by GitBox <gi...@apache.org>.
yanlin-Lynn commented on pull request #2484:
URL: https://github.com/apache/calcite/pull/2484#issuecomment-903255441
Update the commit log please, we do not use something like "fix bug" in the commit log.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] NobiGo commented on pull request #2484: [CALCITE-4734] If there are duplicate RexNode in MutableCalc, SubstitutionVisitor should return right rebuild RexNode (xurenhe)
Posted by GitBox <gi...@apache.org>.
NobiGo commented on pull request #2484:
URL: https://github.com/apache/calcite/pull/2484#issuecomment-908807057
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] yanlin-Lynn commented on pull request #2484: [CALCITE-4734] If there are duplicate RexNode in MutableCalc, SubstitutionVisitor should return right rebuild RexNode (xurenhe)
Posted by GitBox <gi...@apache.org>.
yanlin-Lynn commented on pull request #2484:
URL: https://github.com/apache/calcite/pull/2484#issuecomment-908361668
LGTM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] NobiGo commented on pull request #2484: [CALCITE-4734] If there are duplicate RexNode in MutableCalc, SubstitutionVisitor should return right rebuild RexNode (xurenhe)
Posted by GitBox <gi...@apache.org>.
NobiGo commented on pull request #2484:
URL: https://github.com/apache/calcite/pull/2484#issuecomment-908807057
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] yanlin-Lynn commented on pull request #2484: [CALCITE-4734] If there are duplicate RexNode in MutableCalc, SubstitutionVisitor should return right rebuild RexNode (xurenhe)
Posted by GitBox <gi...@apache.org>.
yanlin-Lynn commented on pull request #2484:
URL: https://github.com/apache/calcite/pull/2484#issuecomment-908361668
LGTM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] yanlin-Lynn merged pull request #2484: [CALCITE-4734] If there are duplicate RexNode in MutableCalc, SubstitutionVisitor should return right rebuild RexNode (xurenhe)
Posted by GitBox <gi...@apache.org>.
yanlin-Lynn merged pull request #2484:
URL: https://github.com/apache/calcite/pull/2484
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] wojustme commented on pull request #2484: [CALCITE-4734] CalcToCalcUnifyRule build shuttle error, when meeting more same rexnode in target.
Posted by GitBox <gi...@apache.org>.
wojustme commented on pull request #2484:
URL: https://github.com/apache/calcite/pull/2484#issuecomment-907737607
@yanlin-Lynn Thanks for your comment.
Please review this issue again, Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] xy2953396112 commented on pull request #2484: Fix `SubstitutionVisitor#getRexShuttle` bug, when meeting same rexnode.
Posted by GitBox <gi...@apache.org>.
xy2953396112 commented on pull request #2484:
URL: https://github.com/apache/calcite/pull/2484#issuecomment-898219571
LGTM~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] yanlin-Lynn merged pull request #2484: [CALCITE-4734] If there are duplicate RexNode in MutableCalc, SubstitutionVisitor should return right rebuild RexNode (xurenhe)
Posted by GitBox <gi...@apache.org>.
yanlin-Lynn merged pull request #2484:
URL: https://github.com/apache/calcite/pull/2484
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] yanlin-Lynn edited a comment on pull request #2484: [CALCITE-4734] CalcToCalcUnifyRule build shuttle error, when meeting more same rexnode in target.
Posted by GitBox <gi...@apache.org>.
yanlin-Lynn edited a comment on pull request #2484:
URL: https://github.com/apache/calcite/pull/2484#issuecomment-903255441
Update the commit log please, we do not use something like "fix bug" in the commit log. Just describe what you update shortly in the commit log. Add your name in the end ,and no "."
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org