You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "zhhyu7 (via GitHub)" <gi...@apache.org> on 2023/03/17 09:06:17 UTC
[GitHub] [nuttx] zhhyu7 opened a new pull request, #8837: icmpv6: add RDNSS field support for route advertise message
zhhyu7 opened a new pull request, #8837:
URL: https://github.com/apache/nuttx/pull/8837
## Summary
## Impact
## Testing
linux sim with radvd
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] acassis commented on pull request #8837: icmpv6: add RDNSS field support for route advertise message
Posted by "acassis (via GitHub)" <gi...@apache.org>.
acassis commented on PR #8837:
URL: https://github.com/apache/nuttx/pull/8837#issuecomment-1474337775
> > Summary
>
> > @zhhyu7 please include a log message just to describe why it is necessary/important
>
> @acassis I updated the summary, do you have any suggestions? Thank you.
@zhhyu7 it is good, but my suggestion was to use it in the commit log message, then it will keep in our git history. Take a look how @pussuw is doing. If you write it in the log message it will appear in the Summary as well.
BTW, to avoid delaying it lets merge! Please try this approach for next PRs :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] zhhyu7 commented on pull request #8837: icmpv6: add RDNSS field support for route advertise message
Posted by "zhhyu7 (via GitHub)" <gi...@apache.org>.
zhhyu7 commented on PR #8837:
URL: https://github.com/apache/nuttx/pull/8837#issuecomment-1473996382
> Summary
> @zhhyu7 please include a log message just to describe why it is necessary/important
@acassis I updated the summary, do you have any suggestions? Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] acassis commented on pull request #8837: icmpv6: add RDNSS field support for route advertise message
Posted by "acassis (via GitHub)" <gi...@apache.org>.
acassis commented on PR #8837:
URL: https://github.com/apache/nuttx/pull/8837#issuecomment-1473953065
@zhhyu7 please include a log message just to describe why it is necessary/important
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] acassis merged pull request #8837: icmpv6: add RDNSS field support for route advertise message
Posted by "acassis (via GitHub)" <gi...@apache.org>.
acassis merged PR #8837:
URL: https://github.com/apache/nuttx/pull/8837
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org