You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by co...@apache.org on 2020/07/16 10:09:25 UTC

[camel] branch master updated: Replacing toLowerCase().equals with equalsIgnoreCase

This is an automated email from the ASF dual-hosted git repository.

coheigea pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/camel.git


The following commit(s) were added to refs/heads/master by this push:
     new e17fe1d  Replacing toLowerCase().equals with equalsIgnoreCase
e17fe1d is described below

commit e17fe1d1f1794bc37e84ab4f7a3fa099d70bb0bf
Author: Colm O hEigeartaigh <co...@apache.org>
AuthorDate: Thu Jul 16 11:08:40 2020 +0100

    Replacing toLowerCase().equals with equalsIgnoreCase
---
 .../java/org/apache/camel/maven/config/ConnectorConfigField.java    | 2 +-
 .../main/java/org/apache/camel/http/common/DefaultHttpBinding.java  | 2 +-
 .../java/org/apache/camel/component/http/HttpPollingConsumer.java   | 2 +-
 .../src/main/java/org/apache/camel/component/http/HttpProducer.java | 2 +-
 .../apache/camel/component/netty/http/DefaultNettyHttpBinding.java  | 6 +++---
 5 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/components/camel-debezium-common/camel-debezium-maven-plugin/src/main/java/org/apache/camel/maven/config/ConnectorConfigField.java b/components/camel-debezium-common/camel-debezium-maven-plugin/src/main/java/org/apache/camel/maven/config/ConnectorConfigField.java
index 8faaeff..1cc0da0 100644
--- a/components/camel-debezium-common/camel-debezium-maven-plugin/src/main/java/org/apache/camel/maven/config/ConnectorConfigField.java
+++ b/components/camel-debezium-common/camel-debezium-maven-plugin/src/main/java/org/apache/camel/maven/config/ConnectorConfigField.java
@@ -98,7 +98,7 @@ public class ConnectorConfigField {
 
     private boolean isMillSecondsInTheFieldName(final String name) {
         final String[] parts = name.split("\\.");
-        return parts.length > 0 && parts[parts.length - 1].toLowerCase().equals("ms");
+        return parts.length > 0 && parts[parts.length - 1].equalsIgnoreCase("ms");
     }
 
     private String getSetterMethodName(final String name) {
diff --git a/components/camel-http-common/src/main/java/org/apache/camel/http/common/DefaultHttpBinding.java b/components/camel-http-common/src/main/java/org/apache/camel/http/common/DefaultHttpBinding.java
index 9f95035..56d0c6f 100644
--- a/components/camel-http-common/src/main/java/org/apache/camel/http/common/DefaultHttpBinding.java
+++ b/components/camel-http-common/src/main/java/org/apache/camel/http/common/DefaultHttpBinding.java
@@ -164,7 +164,7 @@ public class DefaultHttpBinding implements HttpBinding {
             // use http helper to extract parameter value as it may contain multiple values
             Object extracted = HttpHelper.extractHttpParameterValue(value);
             // mapping the content-type
-            if (name.toLowerCase().equals("content-type")) {
+            if (name.equalsIgnoreCase("content-type")) {
                 name = Exchange.CONTENT_TYPE;
             }
             if (headerFilterStrategy != null
diff --git a/components/camel-http/src/main/java/org/apache/camel/component/http/HttpPollingConsumer.java b/components/camel-http/src/main/java/org/apache/camel/component/http/HttpPollingConsumer.java
index bf2fbc8..c7ef6a5 100644
--- a/components/camel-http/src/main/java/org/apache/camel/component/http/HttpPollingConsumer.java
+++ b/components/camel-http/src/main/java/org/apache/camel/component/http/HttpPollingConsumer.java
@@ -102,7 +102,7 @@ public class HttpPollingConsumer extends PollingConsumerSupport {
             for (Header header : headers) {
                 String name = header.getName();
                 // mapping the content-type
-                if (name.toLowerCase().equals("content-type")) {
+                if (name.equalsIgnoreCase("content-type")) {
                     name = Exchange.CONTENT_TYPE;
                 }
                 String value = header.getValue();
diff --git a/components/camel-http/src/main/java/org/apache/camel/component/http/HttpProducer.java b/components/camel-http/src/main/java/org/apache/camel/component/http/HttpProducer.java
index b688a5e..df81514 100644
--- a/components/camel-http/src/main/java/org/apache/camel/component/http/HttpProducer.java
+++ b/components/camel-http/src/main/java/org/apache/camel/component/http/HttpProducer.java
@@ -263,7 +263,7 @@ public class HttpProducer extends DefaultProducer {
             String name = header.getName();
             String value = header.getValue();
             m.computeIfAbsent(name, k -> new ArrayList<>()).add(value);
-            if (name.toLowerCase().equals("content-type")) {
+            if (name.equalsIgnoreCase("content-type")) {
                 name = Exchange.CONTENT_TYPE;
                 exchange.setProperty(Exchange.CHARSET_NAME, IOHelper.getCharsetNameFromContentType(value));
             }
diff --git a/components/camel-netty-http/src/main/java/org/apache/camel/component/netty/http/DefaultNettyHttpBinding.java b/components/camel-netty-http/src/main/java/org/apache/camel/component/netty/http/DefaultNettyHttpBinding.java
index 20d18cf..5325275 100644
--- a/components/camel-netty-http/src/main/java/org/apache/camel/component/netty/http/DefaultNettyHttpBinding.java
+++ b/components/camel-netty-http/src/main/java/org/apache/camel/component/netty/http/DefaultNettyHttpBinding.java
@@ -191,11 +191,11 @@ public class DefaultNettyHttpBinding implements NettyHttpBinding, Cloneable {
 
         for (String name : request.headers().names()) {
             // mapping the content-type
-            if (name.toLowerCase(Locale.US).equals("content-type")) {
+            if (name.equalsIgnoreCase("content-type")) {
                 name = Exchange.CONTENT_TYPE;
             }
 
-            if (name.toLowerCase(Locale.US).equals("authorization")) {
+            if (name.equalsIgnoreCase("authorization")) {
                 String value = request.headers().get(name);
                 // store a special header that this request was authenticated using HTTP Basic
                 if (value != null && value.trim().startsWith("Basic")) {
@@ -350,7 +350,7 @@ public class DefaultNettyHttpBinding implements NettyHttpBinding, Cloneable {
 
         for (String name : response.headers().names()) {
             // mapping the content-type
-            if (name.toLowerCase().equals("content-type")) {
+            if (name.equalsIgnoreCase("content-type")) {
                 name = Exchange.CONTENT_TYPE;
             }
             // add the headers one by one, and use the header filter strategy