You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/09/10 15:43:15 UTC

[GitHub] [pulsar] michaeljmarshall commented on a change in pull request #11973: [testclient] Improve parameter checking in pulsar-perf

michaeljmarshall commented on a change in pull request #11973:
URL: https://github.com/apache/pulsar/pull/11973#discussion_r706280716



##########
File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/ClientBuilderImpl.java
##########
@@ -164,6 +167,7 @@ public ClientBuilder listenerThreads(int numListenerThreads) {
 
     @Override
     public ClientBuilder connectionsPerBroker(int connectionsPerBroker) {
+        checkArgument(connectionsPerBroker >= 0, "connectionsPerBroker needs to be >= 0");

Review comment:
       Per the java doc on the `ClientBuilder` interface, the value must be greater than 0.
   ```suggestion
           checkArgument(connectionsPerBroker > 0, "connectionsPerBroker needs to be > 0");
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org