You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@libcloud.apache.org by aki-k <gi...@git.apache.org> on 2017/09/06 12:21:14 UTC

[GitHub] libcloud pull request #1104: [LIBCLOUD-943] Add the option to Azure ARM ex_c...

GitHub user aki-k opened a pull request:

    https://github.com/apache/libcloud/pull/1104

    [LIBCLOUD-943] Add the option to Azure ARM ex_create_network_interfac…

    ### [LIBCLOUD-943] Add the option to Azure ARM ex_create_network_interface to create a static IP address
    
    ### Description
    
    https://issues.apache.org/jira/browse/LIBCLOUD-943
    
    Azure ARM driver's ex_create_network_interface is missing the option to create
    a static IP address. "privateIPAllocationMethod" is set to "Dynamic" in the "data" 
    dictionary. This change adds the option to create the network interface with a 
    static IP address.
    
    The value for the static IP address is defined with private_ip_address="n.n.n.n" in the 
    ex_create_network_interface call.
    
    ### Status
    
    - done, ready for review
    
    ### Checklist (tick everything that applies)
    
    - [x] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide) (required, can be done after the PR checks)
    - [x] Documentation
    - [ ] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
    - [ ] [ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes) (required for bigger changes)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/aki-k/libcloud LIBCLOUD-943-ex_create_network_interface-private_ip_allocation_method-static

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/libcloud/pull/1104.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1104
    
----
commit 2f22dbea6f36eef4e2608a731446d7854a4ca197
Author: Aki Ketolainen <ak...@siroic.com>
Date:   2017-09-06T12:04:05Z

    [LIBCLOUD-943] Add the option to Azure ARM ex_create_network_interface to create a static IP address

----


---