[GitHub] [calcite] asereda-gs commented on a change in pull request #2657: [CALCITE-4860] In Elasticsearch adapter, support NULLS FIRST and NULLS LAST query

[GitBox <gi...@apache.org>]

asereda-gs commented on a change in pull request #2657:
URL: https://github.com/apache/calcite/pull/2657#discussion_r781224269



##########
File path: elasticsearch/src/test/java/org/apache/calcite/adapter/elasticsearch/AggregationTest.java
##########
@@ -400,6 +400,21 @@ public static void setupInstance() throws Exception {
             "aggregations:{'v1.max.field': 'val1'",
             "'v2.min.field': 'val2'}"))
         .returnsUnordered("v1=7; v2=5");
+  }
+
+  @Test void testNullsSort() {

Review comment:
       Hi @ILuffZhe,
   
   I agree with Stamatis that you should validate actual query similarly to how it is done in `ElasticSearchAdapterTest`.
   
   Perhaps, you can create separate class `SortTest` (or `OrderTest`) to validate output as well as actual queries ? For examples look at `BooleanLogicTest` or `AggregationTest`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org