You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/10/28 13:47:18 UTC
[GitHub] [tvm] mbaret opened a new pull request #9387: [ETHOSU] Add early simplify to fix LoopPartition
mbaret opened a new pull request #9387:
URL: https://github.com/apache/tvm/pull/9387
Certain loops aren't correctly partitioned if the loop condition hasn't been simplified. This can happen when a copy loop is split by a non-factor. To fix this, an additional simplify pass is added to the TIR pipeline prior to LoopPartition.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] mbaret commented on pull request #9387: [ETHOSU] Add early simplify to fix LoopPartition
Posted by GitBox <gi...@apache.org>.
mbaret commented on pull request #9387:
URL: https://github.com/apache/tvm/pull/9387#issuecomment-953862317
cc @manupa-arm @ekalda @NicolaLancellotti
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] manupa-arm commented on pull request #9387: [ETHOSU] Add early simplify to fix LoopPartition
Posted by GitBox <gi...@apache.org>.
manupa-arm commented on pull request #9387:
URL: https://github.com/apache/tvm/pull/9387#issuecomment-954765888
Thanks for the PR! @mbaret .
nit : the TVMScript test input is formatted with black. Is that expected ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] ekalda commented on pull request #9387: [ETHOSU] Add early simplify to fix LoopPartition
Posted by GitBox <gi...@apache.org>.
ekalda commented on pull request #9387:
URL: https://github.com/apache/tvm/pull/9387#issuecomment-954596661
Just for enlightenment, what's a "non-factor" and what does the Simplify pass do to help us? Otherwise, LGTM!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] leandron merged pull request #9387: [ETHOSU] Add early simplify to fix LoopPartition
Posted by GitBox <gi...@apache.org>.
leandron merged pull request #9387:
URL: https://github.com/apache/tvm/pull/9387
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] mbaret commented on pull request #9387: [ETHOSU] Add early simplify to fix LoopPartition
Posted by GitBox <gi...@apache.org>.
mbaret commented on pull request #9387:
URL: https://github.com/apache/tvm/pull/9387#issuecomment-954863523
Good spot, forgot the fmt off :) I've fixed that now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] mbaret commented on pull request #9387: [ETHOSU] Add early simplify to fix LoopPartition
Posted by GitBox <gi...@apache.org>.
mbaret commented on pull request #9387:
URL: https://github.com/apache/tvm/pull/9387#issuecomment-954608030
A non-factor split would be one where, for instance, we want to split an axis of length 16 into stripes of length 7, so we'd get two stripes of 7 plus a residual of 2. This contrasts with a factor split which would be something like 8. In handling the edge case behaviour, some 'if' statements get inserted into TIR, and for I reason I don't fully understand these confuse LoopPartition unless their condition is simplified with the Simplify pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org