[GitHub] [tvm-rfcs] mbs-octoml commented on pull request #45: [RELAY][AST] Add virtual device as a first class field to Relay expressions

[GitBox <gi...@apache.org>]

mbs-octoml commented on pull request #45:
URL: https://github.com/apache/tvm-rfcs/pull/45#issuecomment-984973910


   Thanks Lily, LGTM.
   
   Let me apologize for getting us into the current on_device + function attributes mess your proposal gets us out of. It seemed like a workable approach at the time which would not require both an AST change *and* careful treatment of AST node copies. But in retrospect the on_device + function attributes approach has caused at least four bugs due to the fragility of maintaining its annotation invariant.
   
   I'm hoping the experience we gain from adding virtual_device_ will inform improvements to checked_type_. In particular getting us out of the need to rerun InferType after every xform (and sometimes in strict succession). But one step at a time.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org