[jira] [Resolved] (GIRAPH-269) TestGraphPartitioner is broken and probably not robust

["Dionysios Logothetis (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/GIRAPH-269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dionysios Logothetis resolved GIRAPH-269.
-----------------------------------------
    Resolution: Not A Problem

> TestGraphPartitioner is broken and probably not robust
> ------------------------------------------------------
>
>                 Key: GIRAPH-269
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-269
>             Project: Giraph
>          Issue Type: Bug
>            Reporter: Alessandro Presta
>            Priority: Major
>
> TestGraphPartitioner (distributed-mode only) currently fails with:
> {code}
> testPartitioners(org.apache.giraph.TestGraphPartitioner)  Time elapsed: 65.195 sec  <<< FAILURE!
> java.lang.AssertionError: expected:<123> but was:<120>
> 	at org.junit.Assert.fail(Assert.java:58)
> 	at org.junit.Assert.failNotEquals(Assert.java:259)
> 	at org.junit.Assert.assertEquals(Assert.java:80)
> 	at org.junit.Assert.assertEquals(Assert.java:88)
> 	at org.apache.giraph.TestGraphPartitioner.verifyOutput(TestGraphPartitioner.java:59)
> 	at org.apache.giraph.TestGraphPartitioner.testPartitioners(TestGraphPartitioner.java:96)
> {code}
> This is most likely due to the serialization changes that came with GIRAPH-244.
> The test isn't commented so I can't figure out how we came up with 123 as the correct number of bytes, but if that depends on the serialization format, then it's not a robust test.
> We should replace the check with something that doesn't depend on bytes count, or, if impossible, remove the test case.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)