You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@poi.apache.org by ce...@apache.org on 2016/11/07 21:32:12 UTC

svn commit: r1768589 - in /poi/trunk/src/ooxml: java/org/apache/poi/util/ java/org/apache/poi/xssf/usermodel/ testcases/org/apache/poi/xssf/usermodel/

Author: centic
Date: Mon Nov  7 21:32:12 2016
New Revision: 1768589

URL: http://svn.apache.org/viewvc?rev=1768589&view=rev
Log:
Adjust imports, fix some Javadoc issues and ignore deprecation warnings in tests
Exclude some more non-tests in OOXMLLite

Modified:
    poi/trunk/src/ooxml/java/org/apache/poi/util/OOXMLLite.java
    poi/trunk/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFSheet.java
    poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFBugs.java
    poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFRichTextString.java

Modified: poi/trunk/src/ooxml/java/org/apache/poi/util/OOXMLLite.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/java/org/apache/poi/util/OOXMLLite.java?rev=1768589&r1=1768588&r2=1768589&view=diff
==============================================================================
--- poi/trunk/src/ooxml/java/org/apache/poi/util/OOXMLLite.java (original)
+++ poi/trunk/src/ooxml/java/org/apache/poi/util/OOXMLLite.java Mon Nov  7 21:32:12 2016
@@ -104,6 +104,8 @@ public final class OOXMLLite {
                 "TestDataSamples",
                 "All.+Tests",
                 "ZipFileAssert",
+                "AesZipFileZipEntrySource",
+                "TempFileRecordingSXSSFWorkbookWithCustomZipEntrySource",
                 "PkiTestUtils",
                 "TestCellFormatPart\\$\\d",
                 "TestSignatureInfo\\$\\d",

Modified: poi/trunk/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFSheet.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFSheet.java?rev=1768589&r1=1768588&r2=1768589&view=diff
==============================================================================
--- poi/trunk/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFSheet.java (original)
+++ poi/trunk/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFSheet.java Mon Nov  7 21:32:12 2016
@@ -381,7 +381,7 @@ public class XSSFSheet extends POIXMLDoc
     /**
      * Verify that the candidate region does not intersect with an existing multi-cell array formula in this sheet
      *
-     * @param region
+     * @param region a region that is validated.
      * @throws IllegalStateException if candidate region intersects an existing array formula in this sheet
      */
     private void validateArrayFormulas(CellRangeAddress region) {
@@ -4217,10 +4217,9 @@ public class XSSFSheet extends POIXMLDoc
     /**
      * Create a pivot table using the AreaReference or named/table range on sourceSheet, at the given position.
      * If the source reference contains a sheet name, it must match the sourceSheet.
-     * @param sourceRef location of pivot data - mutually exclusive with SourceName
-     * @param sourceName range or table name for pivot data - mutually exclusive with SourceRef
      * @param position A reference to the top left cell where the pivot table will start
      * @param sourceSheet The sheet containing the source data, if the source reference doesn't contain a sheet name
+     * @param refConfig A reference to the pivot table configurator
      * @throws IllegalArgumentException if source references a sheet different than sourceSheet
      * @return The pivot table
      */

Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFBugs.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFBugs.java?rev=1768589&r1=1768588&r2=1768589&view=diff
==============================================================================
--- poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFBugs.java (original)
+++ poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFBugs.java Mon Nov  7 21:32:12 2016
@@ -85,6 +85,7 @@ import org.openxmlformats.schemas.spread
 import org.openxmlformats.schemas.spreadsheetml.x2006.main.CTWorksheet;
 import org.openxmlformats.schemas.spreadsheetml.x2006.main.impl.CTFontImpl;
 
+@SuppressWarnings("deprecation")
 public final class TestXSSFBugs extends BaseTestBugzillaIssues {
     public TestXSSFBugs() {
         super(XSSFITestDataProvider.instance);
@@ -135,7 +136,6 @@ public final class TestXSSFBugs extends
 
     /**
      * We should carry vba macros over after save
-     * @throws InvalidFormatException 
      */
     @Test
     public void bug45431() throws IOException, InvalidFormatException {
@@ -1824,7 +1824,6 @@ public final class TestXSSFBugs extends
     /**
      * New hyperlink with no initial cell reference, still need
      *  to be able to change it
-     * @throws IOException
      */
     @Test
     public void testBug56527() throws IOException {
@@ -2251,7 +2250,6 @@ public final class TestXSSFBugs extends
      * Expected:
 
      * [  0][  2][  4]
-     * @throws IOException
      */
     @Test
     public void testBug56820_Formula1() throws IOException {
@@ -2282,7 +2280,6 @@ public final class TestXSSFBugs extends
      * [  0] <- number
      * [  2] <- formula
      * [  4] <- formula
-     * @throws IOException
      */
     @Test
     public void testBug56820_Formula2() throws IOException {

Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFRichTextString.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFRichTextString.java?rev=1768589&r1=1768588&r2=1768589&view=diff
==============================================================================
--- poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFRichTextString.java (original)
+++ poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFRichTextString.java Mon Nov  7 21:32:12 2016
@@ -17,22 +17,20 @@
 
 package org.apache.poi.xssf.usermodel;
 
-import java.io.IOException;
-import java.util.TreeMap;
-
 import junit.framework.TestCase;
-
 import org.apache.poi.ss.usermodel.Cell;
 import org.apache.poi.ss.usermodel.Row;
 import org.apache.poi.ss.usermodel.Sheet;
 import org.apache.poi.xssf.XSSFTestDataSamples;
 import org.apache.poi.xssf.model.StylesTable;
-import org.junit.Test;
 import org.openxmlformats.schemas.spreadsheetml.x2006.main.CTFont;
 import org.openxmlformats.schemas.spreadsheetml.x2006.main.CTRPrElt;
 import org.openxmlformats.schemas.spreadsheetml.x2006.main.CTRst;
 import org.openxmlformats.schemas.spreadsheetml.x2006.main.STXstring;
 
+import java.io.IOException;
+import java.util.TreeMap;
+
 /**
  * Tests functionality of the XSSFRichTextRun object
  *



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@poi.apache.org
For additional commands, e-mail: commits-help@poi.apache.org