You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Matt Benson (JIRA)" <ji...@apache.org> on 2009/12/30 00:14:29 UTC

[jira] Resolved: (COLLECTIONS-343) Functor singleton classes do not implement singleton pattern correctly

     [ https://issues.apache.org/jira/browse/COLLECTIONS-343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Matt Benson resolved COLLECTIONS-343.
-------------------------------------

    Resolution: Fixed

! /Users/mbenson/oss/asf/commons/trunks-proper/collections> svn commit -m "[COLLECTIONS-343] applied patch to preserve singleton integrity with readResolve" src pom.xml 
Sending        pom.xml
Sending        src/java/org/apache/commons/collections/functors/CloneTransformer.java
Sending        src/java/org/apache/commons/collections/functors/ExceptionClosure.java
Sending        src/java/org/apache/commons/collections/functors/ExceptionFactory.java
Sending        src/java/org/apache/commons/collections/functors/ExceptionPredicate.java
Sending        src/java/org/apache/commons/collections/functors/ExceptionTransformer.java
Sending        src/java/org/apache/commons/collections/functors/FalsePredicate.java
Sending        src/java/org/apache/commons/collections/functors/NOPClosure.java
Sending        src/java/org/apache/commons/collections/functors/NOPTransformer.java
Sending        src/java/org/apache/commons/collections/functors/NotNullPredicate.java
Sending        src/java/org/apache/commons/collections/functors/NullPredicate.java
Sending        src/java/org/apache/commons/collections/functors/StringValueTransformer.java
Sending        src/java/org/apache/commons/collections/functors/TruePredicate.java
Sending        src/test/org/apache/commons/collections/TestClosureUtils.java
Sending        src/test/org/apache/commons/collections/TestFactoryUtils.java
Sending        src/test/org/apache/commons/collections/TestPredicateUtils.java
Sending        src/test/org/apache/commons/collections/TestTransformerUtils.java
Adding         src/test/org/apache/commons/collections/TestUtils.java
Transmitting file data ..................
Committed revision 894507.


> Functor singleton classes do not implement singleton pattern correctly
> ----------------------------------------------------------------------
>
>                 Key: COLLECTIONS-343
>                 URL: https://issues.apache.org/jira/browse/COLLECTIONS-343
>             Project: Commons Collections
>          Issue Type: Bug
>          Components: Functor
>            Reporter: Goran Hacek
>             Fix For: 4.0
>
>         Attachments: fix_functor_singletones.patch
>
>
> All classes in package "org.apache.commons.collections.functors" that advertise that they have singleton instance actually cannot guarantee that.  Because of serialization support multiple instances of those classes can exist at runtime.
> Following classes are making this false claim:
> * CloneTransformer
> * ExceptionClosure
> * ExceptionFactory
> * ExceptionPredicate
> * ExceptionTransformer
> * FalsePredicate
> * NOPClosure
> * NOPTransformer
> * NotNullPredicate
> * NullPredicate
> * StringValueTransformer
> * TruePredicate

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.