You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "Taragolis (via GitHub)" <gi...@apache.org> on 2023/02/20 08:37:32 UTC

[GitHub] [airflow] Taragolis opened a new pull request, #29627: Clarify `service_config` in AWS Connection

Taragolis opened a new pull request, #29627:
URL: https://github.com/apache/airflow/pull/29627

   We add information about potential future implementation in `service_config` Extra AWS Connection config.
   The sample include information about S3, STS and EMR however we only implement bucket_name for S3.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] vincbeck commented on a diff in pull request #29627: Clarify `service_config` in AWS Connection

Posted by "vincbeck (via GitHub)" <gi...@apache.org>.
vincbeck commented on code in PR #29627:
URL: https://github.com/apache/airflow/pull/29627#discussion_r1113526645


##########
docs/apache-airflow-providers-amazon/connections/aws.rst:
##########
@@ -332,6 +317,29 @@ The following settings may be used within the ``assume_role_with_saml`` containe
     - https://pypi.org/project/requests-gssapi/
 
 
+.. _howto/connection:aws:per-service-configuration:
+
+Per service configuration
+^^^^^^^^^^^^^^^^^^^^^^^^^
+
+S3 Bucket configurations
+""""""""""""""""""""""""
+
+For use S3 Bucket name per connection in :class:`~airflow.providers.amazon.aws.hooks.s3.S3Hook` methods
+provide selected options in Connection Extra.

Review Comment:
   ```suggestion
   To use S3 bucket name per connection in :class:`~airflow.providers.amazon.aws.hooks.s3.S3Hook` methods,
   provide selected options in Connection Extra.
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] potiuk merged pull request #29627: Clarify `service_config` in AWS Connection

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #29627:
URL: https://github.com/apache/airflow/pull/29627


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org