[GitHub] [bookkeeper] StevenLuMT opened a new issue, #3502: BP-58: Change the API for org.apache.bookkeeper.stats.Counter

[GitBox <gi...@apache.org>]

StevenLuMT opened a new issue, #3502:
URL: https://github.com/apache/bookkeeper/issues/3502

   This is the master ticket for tracking BP-58 :
   
   ### Motivation
   
   The latency of the OpStatsLogger.registerSuccessfulEvent calculation is to convert the time to milliseconds
   but Counter.add nothing to do
   so when using Counter for latency statistics, the time unit and OpStatsLogger are not unified, which is easy to be misleading.
   then we unified latency metric unit
   
   ### Proposal
   We already have the Counter metric for counting , we just need to refactor it and expose it as a public method.
   My idea is to change the API of org.apache.bookkeeper.stats.Counter
   
   when using Counter for count metric, use Counter.addCount,intead of old API(Counter.add)
   when using Counter for latency metric, use Counter.addLatency
   
   ### Release
   because it change the API,so we don't cherry pick this into released branches
   so it should go into a major release, like Release-4.16, then we can update its implementation in other projects, like pulsar
   
   Proposal PR - #3501 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bookkeeper] StevenLuMT closed issue #3502: BP-58: Change the API for org.apache.bookkeeper.stats.Counter

[GitBox <gi...@apache.org>]

StevenLuMT closed issue #3502: BP-58: Change the API for org.apache.bookkeeper.stats.Counter
URL: https://github.com/apache/bookkeeper/issues/3502


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org