[GitHub] rhtyd opened a new pull request #2926: network: on rolling restart force stop old routers

[GitBox <gi...@apache.org>]

rhtyd opened a new pull request #2926: network: on rolling restart force stop old routers
URL: https://github.com/apache/cloudstack/pull/2926
 
 
   This force stops old VRs when performing rolling restart with
   cleanup=true. This will ensure that VRs are powered off quickly than
   wait longer for the normal ACPI shutdown. During testing, it was found
   on VMware where VM stops are slow compared to XenServer and KVM.
   
   This could likely fix #2880 /cc @resmo 
   
   ## Types of changes
   <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [x] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ## How Has This Been Tested?
   
   Restart an isolated network or VPC with cleanup=true, see actions in vCenter. With this changes, it should now refer to powering off the VR.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services