You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "LucaCappelletti94 (via GitHub)" <gi...@apache.org> on 2026/10/13 19:23:28 UTC
[PR] Assert exact errors in negative tests (2/4): common and parser unit tests [datafusion-sqlparser-rs]
LucaCappelletti94 opened a new pull request, #2629:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/2629
Same change as #2628. The pipe operator negative cases become a table.
The pinned error for `SELECT * FROM users |> JOIN ON users.id = orders.user_id` is wrong today because the parser takes `ON` as a table name, which stresses again the importance of not allowing simply `is_err()` otherwise we risk this kind of test rot.
I will fix that in a separate PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Assert exact errors in negative tests (2/4): common and parser unit tests [datafusion-sqlparser-rs]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #2629:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/2629#issuecomment-6155461248
## [Codecov](https://app.codecov.io/gh/apache/datafusion-sqlparser-rs/pull/2629?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 81.17%. Comparing base ([`dacdbc9`](https://app.codecov.io/gh/apache/datafusion-sqlparser-rs/commit/dacdbc99cd16c335fccd353ba41f6c18a7cd73b8?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`7437efa`](https://app.codecov.io/gh/apache/datafusion-sqlparser-rs/commit/7437efaf0ddc67272b8346d94a61fcde03f67797?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #2629 +/- ##
==========================================
+ Coverage 81.16% 81.17% +0.01%
==========================================
Files 42 42
Lines 33769 33791 +22
Branches 33769 33791 +22
==========================================
+ Hits 27408 27430 +22
Misses 2797 2797
Partials 3564 3564
```
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/datafusion-sqlparser-rs/pull/2629?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Assert exact errors in negative tests (2/4): common and parser unit tests [datafusion-sqlparser-rs]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #2629:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/2629
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Assert exact errors in negative tests (2/4): common and parser unit tests [datafusion-sqlparser-rs]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #2629:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/2629#issuecomment-6155418974
<!-- dialect-labeler -->
No dialect label was applied because the title does not name a SQL dialect.
If this change targets one or more dialects, edit the title to `<Dialect>[, <Dialect>]: <description>`, add a `Dialects: <Dialect>[, <Dialect>]` line to the description, or reply with one. Reply `Dialects: none` if the change is dialect-agnostic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org