You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Benedict Elliott Smith (Jira)" <ji...@apache.org> on 2020/01/02 11:34:00 UTC
[jira] [Commented] (CASSANDRA-13840) GraphiteReporter stops
reporting from Memory concurrent access
[ https://issues.apache.org/jira/browse/CASSANDRA-13840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17006741#comment-17006741 ]
Benedict Elliott Smith commented on CASSANDRA-13840:
----------------------------------------------------
I think rather than simply remove the assertion, I think we should first verify that anywhere the assertion is imposing a correctness check has the assertion propagated to them. For instance, {{MemoryInputSteam.reBuffer}}, looks to be such a place.
> GraphiteReporter stops reporting from Memory concurrent access
> --------------------------------------------------------------
>
> Key: CASSANDRA-13840
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13840
> Project: Cassandra
> Issue Type: Bug
> Components: Legacy/Observability
> Reporter: Michael Semb Wever
> Assignee: Michael Semb Wever
> Priority: Normal
> Fix For: 2.1.x
>
>
> Gauges in the GraphiteReporter can, when getting compression offheap size, trip over the assertion in {{Memory.size()}}. As the GraphiteReporter only handles Exceptions this crashes the reporter and it sends no more metrics.
> [~benedict] described it [here|https://issues.apache.org/jira/browse/CASSANDRA-9625?focusedCommentId=14711914&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14711914] and [~jbellis] confirmed that it's now ok to remove the assertion.
> {noformat}
> java.lang.AssertionError: null
> at org.apache.cassandra.io.util.Memory.size(Memory.java:359) ~[apache-cassandra-2.1.12.jar:2.1.12]
> at org.apache.cassandra.io.compress.CompressionMetadata.offHeapSize(CompressionMetadata.java:167) ~[apache-cassandra-2.1.12.jar:2.1.12]
> at org.apache.cassandra.io.sstable.SSTableReader.getCompressionMetadataOffHeapSize(SSTableReader.java:1315) ~[apache-cassandra-2.1.12.jar:2.1.12]
> at org.apache.cassandra.metrics.ColumnFamilyMetrics$30.value(ColumnFamilyMetrics.java:573) ~[apache-cassandra-2.1.12.jar:2.1.12]
> at org.apache.cassandra.metrics.ColumnFamilyMetrics$30.value(ColumnFamilyMetrics.java:568) ~[apache-cassandra-2.1.12.jar:2.1.12]
> at com.yammer.metrics.reporting.GraphiteReporter.processGauge(GraphiteReporter.java:309) ~[metrics-graphite-2.2.0.jar:na]
> at com.yammer.metrics.reporting.GraphiteReporter.processGauge(GraphiteReporter.java:26) ~[metrics-graphite-2.2.0.jar:na]
> at com.yammer.metrics.core.Gauge.processWith(Gauge.java:28) ~[metrics-core-2.2.0.jar:na]
> at com.yammer.metrics.reporting.GraphiteReporter.printRegularMetrics(GraphiteReporter.java:251) ~[metrics-graphite-2.2.0.jar:na]
> at com.yammer.metrics.reporting.GraphiteReporter.run(GraphiteReporter.java:216) ~[metrics-graphite-2.2.0.jar:na]
> at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) [na:1.8.0_101]
> at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308) [na:1.8.0_101]
> at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180) [na:1.8.0_101]
> at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:294) [na:1.8.0_101]
> at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) [na:1.8.0_101]
> at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) [na:1.8.0_101]
> at java.lang.Thread.run(Thread.java:745) [na:1.8.0_101]
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org