You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2012/10/24 06:55:06 UTC
Review Request: Test refactorings (see description).
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7718/
-----------------------------------------------------------
Review request for mesos, Vinod Kone and Ben Mahler.
Description
-------
(1) Added tests::Flags (so they can be accessed by other tests).
(2) Updated "external" tests to print out to stdout/stderr when
'verbose' is specified (no longer creating test_output).
(3) Updated everything to be in the 'tests' namespace instead of the
'test' namespace.
(4) s/SampleFrameworks/ExamplesTest/g
Diffs
-----
src/Makefile.am cf9364ea0418ec30a75b1774f32bda8de6e031ac
src/launcher/executor.cpp 2bbe046cb12d8dc4c33c18df2c0dccb406514404
src/tests/allocator_tests.cpp ed52ff61b1820cb3f5f7f2ae421fb3f84a85939a
src/tests/allocator_zookeeper_tests.cpp bd408c22df5edc3684791e509ce1a4c210553922
src/tests/cgroups_isolation_tests.cpp 16b029675ba11030d313b93afa30c84cfef5e14d
src/tests/configurator_tests.cpp d24fc263dffcddac34155e5b6374227e77741ddf
src/tests/examples_tests.cpp PRE-CREATION
src/tests/exception_tests.cpp f99c92045c68676991fec61f7613c804eaffaad6
src/tests/external.hpp PRE-CREATION
src/tests/external.cpp PRE-CREATION
src/tests/external/ExamplesTest/CppFramework.sh PRE-CREATION
src/tests/external/ExamplesTest/JavaExceptionFramework.sh PRE-CREATION
src/tests/external/ExamplesTest/JavaFramework.sh PRE-CREATION
src/tests/external/ExamplesTest/NoExecutorFramework.sh PRE-CREATION
src/tests/external/ExamplesTest/PythonFramework.sh PRE-CREATION
src/tests/external/SampleFrameworks/CppFramework.sh f0d1cebcf05051962e0fe06742b5c18829ec7660
src/tests/external/SampleFrameworks/JavaExceptionFramework.sh 02a8798fb4c0fcf920a1ea5747ee27c6d86b43f9
src/tests/external/SampleFrameworks/JavaFramework.sh c77112d78f7e1d5ff7dde4cc66407b2699069a4b
src/tests/external/SampleFrameworks/NoExecutorFramework.sh 41866008fa938c310465057cc5061e62b079a571
src/tests/external/SampleFrameworks/PythonFramework.sh cecd8af409718de0c6ae3e4313fdaa74a1903f46
src/tests/external_test.hpp 86f91b3a542d133640861efc36dfb1bf73bfc638
src/tests/external_tests.cpp 6d9c59b2ddf5f4b53d3611c03bdeae3ffb449d88
src/tests/fault_tolerance_tests.cpp 558bf41ab6f4ba319ec3b23f3347f98e235260f9
src/tests/files_tests.cpp 4ae1933bda4cf4c96196843848072f0f7d2b2b65
src/tests/flags.hpp PRE-CREATION
src/tests/gc_tests.cpp 1de240579a1cc6af8738d2ffb5da1b3e01c4b19e
src/tests/killtree_tests.cpp 32478fe5089b79157df4d2505ccc232bb7170010
src/tests/log_tests.cpp 26aa9dda5e95f3235fff83970978fe79247ada3e
src/tests/logging_tests.cpp b6d5a3c51b217bd0abda99b2fd4a3e583b066d4e
src/tests/lxc_isolation_tests.cpp 59a22a107302bd8b520abadc9990aea43597dcd4
src/tests/main.cpp 59c727974e91884c1b8b253f3a884520d24c2380
src/tests/master_detector_tests.cpp fb32af8130d3f359eecba5389c2e42c247d6b70e
src/tests/master_tests.cpp 37e97e0a58a0128579f155183b7e769ab4e1b452
src/tests/resource_offers_tests.cpp c50da38508694f956ad104fb160896eb9b9d5fea
src/tests/sample_frameworks_tests.cpp 54cacd7cdd2851b8a5cbc5a416788567d7aa0eda
src/tests/slave_state_tests.cpp 0e232ff3ed773f3bdccc05e716b66d106d80fb2f
src/tests/state_tests.cpp 0b4aac28f087ad4032fb37f536fb90cd0649e500
src/tests/utils.hpp 4066c02b23db15310104955465c4e4afd7bcad5b
src/tests/utils.cpp e7cda40849dfb194b0b5ccbc0b8d05dc755f4d50
src/tests/zookeeper_test.hpp PRE-CREATION
src/tests/zookeeper_test.cpp PRE-CREATION
src/tests/zookeeper_test_server.hpp PRE-CREATION
src/tests/zookeeper_test_server.cpp PRE-CREATION
src/tests/zookeeper_tests.cpp 4415a33b94dd6ca360a7dd3ca49f4c29ee25f5e8
Diff: https://reviews.apache.org/r/7718/diff/
Testing
-------
make check
Thanks,
Benjamin Hindman
Re: Review Request: Test refactorings (see description).
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7718/#review12729
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On Oct. 24, 2012, 4:55 a.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7718/
> -----------------------------------------------------------
>
> (Updated Oct. 24, 2012, 4:55 a.m.)
>
>
> Review request for mesos, Vinod Kone and Ben Mahler.
>
>
> Description
> -------
>
> (1) Added tests::Flags (so they can be accessed by other tests).
>
> (2) Updated "external" tests to print out to stdout/stderr when
> 'verbose' is specified (no longer creating test_output).
>
> (3) Updated everything to be in the 'tests' namespace instead of the
> 'test' namespace.
>
> (4) s/SampleFrameworks/ExamplesTest/g
>
>
> Diffs
> -----
>
> src/Makefile.am cf9364ea0418ec30a75b1774f32bda8de6e031ac
> src/launcher/executor.cpp 2bbe046cb12d8dc4c33c18df2c0dccb406514404
> src/tests/allocator_tests.cpp ed52ff61b1820cb3f5f7f2ae421fb3f84a85939a
> src/tests/allocator_zookeeper_tests.cpp bd408c22df5edc3684791e509ce1a4c210553922
> src/tests/cgroups_isolation_tests.cpp 16b029675ba11030d313b93afa30c84cfef5e14d
> src/tests/configurator_tests.cpp d24fc263dffcddac34155e5b6374227e77741ddf
> src/tests/examples_tests.cpp PRE-CREATION
> src/tests/exception_tests.cpp f99c92045c68676991fec61f7613c804eaffaad6
> src/tests/external.hpp PRE-CREATION
> src/tests/external.cpp PRE-CREATION
> src/tests/external/ExamplesTest/CppFramework.sh PRE-CREATION
> src/tests/external/ExamplesTest/JavaExceptionFramework.sh PRE-CREATION
> src/tests/external/ExamplesTest/JavaFramework.sh PRE-CREATION
> src/tests/external/ExamplesTest/NoExecutorFramework.sh PRE-CREATION
> src/tests/external/ExamplesTest/PythonFramework.sh PRE-CREATION
> src/tests/external/SampleFrameworks/CppFramework.sh f0d1cebcf05051962e0fe06742b5c18829ec7660
> src/tests/external/SampleFrameworks/JavaExceptionFramework.sh 02a8798fb4c0fcf920a1ea5747ee27c6d86b43f9
> src/tests/external/SampleFrameworks/JavaFramework.sh c77112d78f7e1d5ff7dde4cc66407b2699069a4b
> src/tests/external/SampleFrameworks/NoExecutorFramework.sh 41866008fa938c310465057cc5061e62b079a571
> src/tests/external/SampleFrameworks/PythonFramework.sh cecd8af409718de0c6ae3e4313fdaa74a1903f46
> src/tests/external_test.hpp 86f91b3a542d133640861efc36dfb1bf73bfc638
> src/tests/external_tests.cpp 6d9c59b2ddf5f4b53d3611c03bdeae3ffb449d88
> src/tests/fault_tolerance_tests.cpp 558bf41ab6f4ba319ec3b23f3347f98e235260f9
> src/tests/files_tests.cpp 4ae1933bda4cf4c96196843848072f0f7d2b2b65
> src/tests/flags.hpp PRE-CREATION
> src/tests/gc_tests.cpp 1de240579a1cc6af8738d2ffb5da1b3e01c4b19e
> src/tests/killtree_tests.cpp 32478fe5089b79157df4d2505ccc232bb7170010
> src/tests/log_tests.cpp 26aa9dda5e95f3235fff83970978fe79247ada3e
> src/tests/logging_tests.cpp b6d5a3c51b217bd0abda99b2fd4a3e583b066d4e
> src/tests/lxc_isolation_tests.cpp 59a22a107302bd8b520abadc9990aea43597dcd4
> src/tests/main.cpp 59c727974e91884c1b8b253f3a884520d24c2380
> src/tests/master_detector_tests.cpp fb32af8130d3f359eecba5389c2e42c247d6b70e
> src/tests/master_tests.cpp 37e97e0a58a0128579f155183b7e769ab4e1b452
> src/tests/resource_offers_tests.cpp c50da38508694f956ad104fb160896eb9b9d5fea
> src/tests/sample_frameworks_tests.cpp 54cacd7cdd2851b8a5cbc5a416788567d7aa0eda
> src/tests/slave_state_tests.cpp 0e232ff3ed773f3bdccc05e716b66d106d80fb2f
> src/tests/state_tests.cpp 0b4aac28f087ad4032fb37f536fb90cd0649e500
> src/tests/utils.hpp 4066c02b23db15310104955465c4e4afd7bcad5b
> src/tests/utils.cpp e7cda40849dfb194b0b5ccbc0b8d05dc755f4d50
> src/tests/zookeeper_test.hpp PRE-CREATION
> src/tests/zookeeper_test.cpp PRE-CREATION
> src/tests/zookeeper_test_server.hpp PRE-CREATION
> src/tests/zookeeper_test_server.cpp PRE-CREATION
> src/tests/zookeeper_tests.cpp 4415a33b94dd6ca360a7dd3ca49f4c29ee25f5e8
>
> Diff: https://reviews.apache.org/r/7718/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request: Test refactorings (see description).
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7718/#review12780
-----------------------------------------------------------
Ship it!
src/tests/external.cpp
<https://reviews.apache.org/r/7718/#comment27336>
Ditto with my last review:
(I still feel this convention is not maintainable, and at least let's align the comments on whitespace?)
- Ben Mahler
On Oct. 24, 2012, 4:55 a.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7718/
> -----------------------------------------------------------
>
> (Updated Oct. 24, 2012, 4:55 a.m.)
>
>
> Review request for mesos, Vinod Kone and Ben Mahler.
>
>
> Description
> -------
>
> (1) Added tests::Flags (so they can be accessed by other tests).
>
> (2) Updated "external" tests to print out to stdout/stderr when
> 'verbose' is specified (no longer creating test_output).
>
> (3) Updated everything to be in the 'tests' namespace instead of the
> 'test' namespace.
>
> (4) s/SampleFrameworks/ExamplesTest/g
>
>
> Diffs
> -----
>
> src/Makefile.am cf9364ea0418ec30a75b1774f32bda8de6e031ac
> src/launcher/executor.cpp 2bbe046cb12d8dc4c33c18df2c0dccb406514404
> src/tests/allocator_tests.cpp ed52ff61b1820cb3f5f7f2ae421fb3f84a85939a
> src/tests/allocator_zookeeper_tests.cpp bd408c22df5edc3684791e509ce1a4c210553922
> src/tests/cgroups_isolation_tests.cpp 16b029675ba11030d313b93afa30c84cfef5e14d
> src/tests/configurator_tests.cpp d24fc263dffcddac34155e5b6374227e77741ddf
> src/tests/examples_tests.cpp PRE-CREATION
> src/tests/exception_tests.cpp f99c92045c68676991fec61f7613c804eaffaad6
> src/tests/external.hpp PRE-CREATION
> src/tests/external.cpp PRE-CREATION
> src/tests/external/ExamplesTest/CppFramework.sh PRE-CREATION
> src/tests/external/ExamplesTest/JavaExceptionFramework.sh PRE-CREATION
> src/tests/external/ExamplesTest/JavaFramework.sh PRE-CREATION
> src/tests/external/ExamplesTest/NoExecutorFramework.sh PRE-CREATION
> src/tests/external/ExamplesTest/PythonFramework.sh PRE-CREATION
> src/tests/external/SampleFrameworks/CppFramework.sh f0d1cebcf05051962e0fe06742b5c18829ec7660
> src/tests/external/SampleFrameworks/JavaExceptionFramework.sh 02a8798fb4c0fcf920a1ea5747ee27c6d86b43f9
> src/tests/external/SampleFrameworks/JavaFramework.sh c77112d78f7e1d5ff7dde4cc66407b2699069a4b
> src/tests/external/SampleFrameworks/NoExecutorFramework.sh 41866008fa938c310465057cc5061e62b079a571
> src/tests/external/SampleFrameworks/PythonFramework.sh cecd8af409718de0c6ae3e4313fdaa74a1903f46
> src/tests/external_test.hpp 86f91b3a542d133640861efc36dfb1bf73bfc638
> src/tests/external_tests.cpp 6d9c59b2ddf5f4b53d3611c03bdeae3ffb449d88
> src/tests/fault_tolerance_tests.cpp 558bf41ab6f4ba319ec3b23f3347f98e235260f9
> src/tests/files_tests.cpp 4ae1933bda4cf4c96196843848072f0f7d2b2b65
> src/tests/flags.hpp PRE-CREATION
> src/tests/gc_tests.cpp 1de240579a1cc6af8738d2ffb5da1b3e01c4b19e
> src/tests/killtree_tests.cpp 32478fe5089b79157df4d2505ccc232bb7170010
> src/tests/log_tests.cpp 26aa9dda5e95f3235fff83970978fe79247ada3e
> src/tests/logging_tests.cpp b6d5a3c51b217bd0abda99b2fd4a3e583b066d4e
> src/tests/lxc_isolation_tests.cpp 59a22a107302bd8b520abadc9990aea43597dcd4
> src/tests/main.cpp 59c727974e91884c1b8b253f3a884520d24c2380
> src/tests/master_detector_tests.cpp fb32af8130d3f359eecba5389c2e42c247d6b70e
> src/tests/master_tests.cpp 37e97e0a58a0128579f155183b7e769ab4e1b452
> src/tests/resource_offers_tests.cpp c50da38508694f956ad104fb160896eb9b9d5fea
> src/tests/sample_frameworks_tests.cpp 54cacd7cdd2851b8a5cbc5a416788567d7aa0eda
> src/tests/slave_state_tests.cpp 0e232ff3ed773f3bdccc05e716b66d106d80fb2f
> src/tests/state_tests.cpp 0b4aac28f087ad4032fb37f536fb90cd0649e500
> src/tests/utils.hpp 4066c02b23db15310104955465c4e4afd7bcad5b
> src/tests/utils.cpp e7cda40849dfb194b0b5ccbc0b8d05dc755f4d50
> src/tests/zookeeper_test.hpp PRE-CREATION
> src/tests/zookeeper_test.cpp PRE-CREATION
> src/tests/zookeeper_test_server.hpp PRE-CREATION
> src/tests/zookeeper_test_server.cpp PRE-CREATION
> src/tests/zookeeper_tests.cpp 4415a33b94dd6ca360a7dd3ca49f4c29ee25f5e8
>
> Diff: https://reviews.apache.org/r/7718/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>