[GitHub] [maven-doxia-sitetools] michael-o commented on a diff in pull request #94: Use Maven Resolver

["michael-o (via GitHub)" <gi...@apache.org>]

michael-o commented on code in PR #94:
URL: https://github.com/apache/maven-doxia-sitetools/pull/94#discussion_r1136112139


##########
doxia-integration-tools/src/main/java/org/apache/maven/doxia/tools/DefaultSiteTool.java:
##########
@@ -128,36 +129,46 @@ public class DefaultSiteTool implements SiteTool {
     // Public methods
     // ----------------------------------------------------------------------
 
+    /** {@inheritDoc} */
     public Artifact getSkinArtifactFromRepository(
-            ArtifactRepository localRepository,
-            List<ArtifactRepository> remoteArtifactRepositories,
-            DecorationModel decoration)
+            RepositorySystemSession repoSession, List<ArtifactRepository> remoteArtifactRepositories, Skin skin)

Review Comment:
   Very good question. So this is basically old vs. new, right? Previously, in Maven Core namespace, now in Resolver. Looking at the impls it does use `RepositoryUtils`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org