You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2020/11/11 05:36:49 UTC
[GitHub] [nifi] ottobackwards opened a new pull request #4513: NIFI-7761 Allow HandleHttpRequest to add specified form data to FlowF…
ottobackwards opened a new pull request #4513:
URL: https://github.com/apache/nifi/pull/4513
[http_template.xml.zip](https://github.com/apache/nifi/files/5181358/http_template.xml.zip)
…ile attributes
To verify:
- add the attached template
- configure the HandleHttpRequest `Parameters to Attributes List` property to have `data1,DataTwo`
- Enable the context service
run the flow.
Observe the new attributes in the nifi-app.log
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
#### Description of PR
_Enables X functionality; fixes bug NIFI-YYYY._
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with **NIFI-XXXX** where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically `main`)?
- [x] Is your initial contribution a single, squashed commit? _Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not `squash` or use `--force` when pushing to allow for clean monitoring of changes._
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via `mvn -Pcontrib-check clean install` at the root `nifi` folder?
- [-] Have you written or updated unit tests to verify your changes?
- [x] Have you verified that the full build is successful on JDK 8?
- [-] Have you verified that the full build is successful on JDK 11?
- [-] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [-] If applicable, have you updated the `LICENSE` file, including the main `LICENSE` file under `nifi-assembly`?
- [-] If applicable, have you updated the `NOTICE` file, including the main `NOTICE` file found under `nifi-assembly`?
- [x] If adding new Properties, have you added `.displayName` in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/apache/nifi/4513)
<!-- Reviewable:end -->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] ottobackwards commented on pull request #4513: NIFI-7761 Allow HandleHttpRequest to add specified form data to FlowF…
Posted by GitBox <gi...@apache.org>.
ottobackwards commented on pull request #4513:
URL: https://github.com/apache/nifi/pull/4513#issuecomment-754240419
ok, should be set
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] ottobackwards commented on pull request #4513: NIFI-7761 Allow HandleHttpRequest to add specified form data to FlowF…
Posted by GitBox <gi...@apache.org>.
ottobackwards commented on pull request #4513:
URL: https://github.com/apache/nifi/pull/4513#issuecomment-732308802
I think there is only `ITestHandleHttpRequest`, which I took to be an integration test. I will add something there
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] joewitt commented on pull request #4513: NIFI-7761 Allow HandleHttpRequest to add specified form data to FlowF…
Posted by GitBox <gi...@apache.org>.
joewitt commented on pull request #4513:
URL: https://github.com/apache/nifi/pull/4513#issuecomment-732221327
@ottobackwards this processor doesn't have unit tests or this new thing is too difficult to have a unit test for?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] ottobackwards commented on pull request #4513: NIFI-7761 Allow HandleHttpRequest to add specified form data to FlowF…
Posted by GitBox <gi...@apache.org>.
ottobackwards commented on pull request #4513:
URL: https://github.com/apache/nifi/pull/4513#issuecomment-754007115
Happy New Year!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] joewitt commented on pull request #4513: NIFI-7761 Allow HandleHttpRequest to add specified form data to FlowF…
Posted by GitBox <gi...@apache.org>.
joewitt commented on pull request #4513:
URL: https://github.com/apache/nifi/pull/4513#issuecomment-754241916
cool that looks better. lets see if it builds
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] grego33 commented on pull request #4513: NIFI-7761 Allow HandleHttpRequest to add specified form data to FlowF…
Posted by GitBox <gi...@apache.org>.
grego33 commented on pull request #4513:
URL: https://github.com/apache/nifi/pull/4513#issuecomment-720715556
Checked this out and ran it locally today. Worked great! Thanks so much.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] ottobackwards commented on pull request #4513: NIFI-7761 Allow HandleHttpRequest to add specified form data to FlowF…
Posted by GitBox <gi...@apache.org>.
ottobackwards commented on pull request #4513:
URL: https://github.com/apache/nifi/pull/4513#issuecomment-732336116
Ok, added. I would like to say why I didn't do so at the start, but I've forgotten
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] asfgit closed pull request #4513: NIFI-7761 Allow HandleHttpRequest to add specified form data to FlowF…
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #4513:
URL: https://github.com/apache/nifi/pull/4513
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] ottobackwards commented on pull request #4513: NIFI-7761 Allow HandleHttpRequest to add specified form data to FlowF…
Posted by GitBox <gi...@apache.org>.
ottobackwards commented on pull request #4513:
URL: https://github.com/apache/nifi/pull/4513#issuecomment-721154421
Thanks @grego33, hopefully we can get some eyes on this soon
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] ottobackwards commented on pull request #4513: NIFI-7761 Allow HandleHttpRequest to add specified form data to FlowF…
Posted by GitBox <gi...@apache.org>.
ottobackwards commented on pull request #4513:
URL: https://github.com/apache/nifi/pull/4513#issuecomment-754233638
<img width="1057" alt="Screen Shot 2021-01-04 at 16 34 50" src="https://user-images.githubusercontent.com/1111551/103581840-c61b0b00-4eaa-11eb-95a8-f867eb663484.png">
???
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] joewitt commented on pull request #4513: NIFI-7761 Allow HandleHttpRequest to add specified form data to FlowF…
Posted by GitBox <gi...@apache.org>.
joewitt commented on pull request #4513:
URL: https://github.com/apache/nifi/pull/4513#issuecomment-754237132
This branch cannot be rebased due to conflicts
Rebasing the commits of this branch on top of the base branch cannot be performed automatically due to conflicts encountered while reapplying the individual commits from the head branch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] joewitt commented on pull request #4513: NIFI-7761 Allow HandleHttpRequest to add specified form data to FlowF…
Posted by GitBox <gi...@apache.org>.
joewitt commented on pull request #4513:
URL: https://github.com/apache/nifi/pull/4513#issuecomment-732465379
Understood - thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] ottobackwards commented on pull request #4513: NIFI-7761 Allow HandleHttpRequest to add specified form data to FlowF…
Posted by GitBox <gi...@apache.org>.
ottobackwards commented on pull request #4513:
URL: https://github.com/apache/nifi/pull/4513#issuecomment-754238275
sure thing!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] markap14 commented on pull request #4513: NIFI-7761 Allow HandleHttpRequest to add specified form data to FlowF…
Posted by GitBox <gi...@apache.org>.
markap14 commented on pull request #4513:
URL: https://github.com/apache/nifi/pull/4513#issuecomment-754210723
@ottobackwards changes look good to me. I'm a +1 on this, but it looks like it has some conflicts. Can you resolve and ping me? Then I'll be happy to merge. Happy new year!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] ottobackwards commented on pull request #4513: NIFI-7761 Allow HandleHttpRequest to add specified form data to FlowF…
Posted by GitBox <gi...@apache.org>.
ottobackwards commented on pull request #4513:
URL: https://github.com/apache/nifi/pull/4513#issuecomment-723047349
touch - mic tap - wave
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] ottobackwards commented on pull request #4513: NIFI-7761 Allow HandleHttpRequest to add specified form data to FlowF…
Posted by GitBox <gi...@apache.org>.
ottobackwards commented on pull request #4513:
URL: https://github.com/apache/nifi/pull/4513#issuecomment-700973299
touch
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] ottobackwards closed pull request #4513: NIFI-7761 Allow HandleHttpRequest to add specified form data to FlowF…
Posted by GitBox <gi...@apache.org>.
ottobackwards closed pull request #4513:
URL: https://github.com/apache/nifi/pull/4513
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] pvillard31 commented on pull request #4513: NIFI-7761 Allow HandleHttpRequest to add specified form data to FlowF…
Posted by GitBox <gi...@apache.org>.
pvillard31 commented on pull request #4513:
URL: https://github.com/apache/nifi/pull/4513#issuecomment-754494329
Merged to main based on previous comments. Thanks @ottobackwards @joewitt @markap14 @grego33
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] ottobackwards commented on pull request #4513: NIFI-7761 Allow HandleHttpRequest to add specified form data to FlowF…
Posted by GitBox <gi...@apache.org>.
ottobackwards commented on pull request #4513:
URL: https://github.com/apache/nifi/pull/4513#issuecomment-754256434
@joewitt, sorry for the confusion
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] grego33 commented on pull request #4513: NIFI-7761 Allow HandleHttpRequest to add specified form data to FlowF…
Posted by GitBox <gi...@apache.org>.
grego33 commented on pull request #4513:
URL: https://github.com/apache/nifi/pull/4513#issuecomment-701453900
I've not built and tested this but the code looks good. Very clear. I can see how simply specifying a comma-separated list of form names will result in http.param.XXX FlowFile attributes. This will be nice as it will even allow simplification of some flows to eliminate UpdateAttribute processors whose job is just to trim out unwanted attributes.
I'm happy to build/test as well. I should be able to do that this week. But wanted to give *some* response since I just realized you've been waiting for me for quite a while. Apologies about that - I didn't notice until your "touch" comment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] joewitt commented on pull request #4513: NIFI-7761 Allow HandleHttpRequest to add specified form data to FlowF…
Posted by GitBox <gi...@apache.org>.
joewitt commented on pull request #4513:
URL: https://github.com/apache/nifi/pull/4513#issuecomment-754237356
I think the merge thing done might have messed it up. You might want to rebase the two real commits to the latest main then force push without any merge commits.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org