You are viewing a plain text version of this content. The canonical link for it is here.
Posted to users@subversion.apache.org by dc...@danielcaldwell.com on 2007/05/23 05:43:49 UTC
Code Reviews
Does anyone have any good strategies for tracking code reviews with subversion? I'm thinking of tagging after every code review and comparing between tags, but that seems excessive, any suggestions? Thanks.
-Daniel
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@subversion.tigris.org
For additional commands, e-mail: users-help@subversion.tigris.org
Re: Code Reviews
Posted by Manuel Vacelet <ma...@gmail.com>.
On 5/23/07, dcaldwel@danielcaldwell.com <dc...@danielcaldwell.com> wrote:
>
> Does anyone have any good strategies for tracking code reviews with subversion? I'm thinking of tagging after every code review and comparing between tags, but that seems excessive, any suggestions? Thanks.
I don't use it yet but reviewboard seems really interesting:
http://www.chipx86.com/blog/?p=222
-- Manuel
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@subversion.tigris.org
For additional commands, e-mail: users-help@subversion.tigris.org
Re: User info
Posted by marc gonzalez-carnicer <ca...@gmail.com>.
if i understood you correctly, and assuming you are working
under linux, the 'id' command may be of help to you. if its
default output format does not suit you, you can pass some
options or use 'cut'.
2007/5/24, Geoffrey Devantier <Ge...@derivco.com>:
> Hi
>
> I have a little utility that is intended to be run from the root of a
> svn working folder. This utility automates some actions by issuing svn
> cmds via a command shell. While it is possible to use these commands
> natively in the context of the current user, I would like to retrieve
> the user login name in order to keep track of who is doing what. Does
> anyone have any idea as to how I can get this info?
>
> Thanks
> Geoff
> #############################################################################################
> The information transmitted is intended only for the person or entity to which it
> is addressed and may contain confidential and/or privileged material.
> Any review, retransmission, dissemination or other use of, or taking of any action
> in reliance upon, this information by persons or entities other than the intended
> recipient is prohibited. If you received this in error, please contact the sender and
> delete the material from any computer.
>
> Furthermore, the information contained in this message, and any attachments thereto, is
> for information purposes only and may contain the personal views and opinions of the
> author, which are not necessarily the views and opinions of the company.
> #############################################################################################
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: users-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: users-help@subversion.tigris.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@subversion.tigris.org
For additional commands, e-mail: users-help@subversion.tigris.org
Re: Re: User info
Posted by MikeW <mw...@yahoo.co.uk>.
Geoffrey Devantier <Geoffrey.Devantier <at> derivco.com> writes:
>
> The SVN login name may or may not be the same as the OS user name. I
> can't make that assumption. I am working under windows by the way.
>
Well, as per the PDF reference I gave, the svn username is definitely stored
in the file stored in dir: %APPDATA%\Subversion\auth\svn.simple
though you will have to parse it out a little.
Have a look !
MikeW
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@subversion.tigris.org
For additional commands, e-mail: users-help@subversion.tigris.org
RE: Re: User info
Posted by Geoffrey Devantier <Ge...@derivco.com>.
The SVN login name may or may not be the same as the OS user name. I
can't make that assumption. I am working under windows by the way.
-----Original Message-----
From: news [mailto:news@sea.gmane.org] On Behalf Of MikeW
Sent: Thursday, May 24, 2007 1:11 PM
To: users@subversion.tigris.org
Subject: Re: User info
Geoffrey Devantier <Geoffrey.Devantier <at> derivco.com> writes:
>
> Hi
>
> I have a little utility that is intended to be run from the root of a
> svn working folder. This utility automates some actions by issuing svn
> cmds via a command shell. While it is possible to use these commands
> natively in the context of the current user, I would like to retrieve
> the user login name in order to keep track of who is doing what. Does
> anyone have any idea as to how I can get this info?
>
> Thanks
> Geoff
>
Linux: $USER
Windows: $USERNAME
Or is the svn login name different from the OS login name ?
Also see svn-book.pdf section Client Credentials Caching:
>>
By default, whenever the command-line client successfully responds
to a server's authentication challenge, it saves the credentials in the
user's
private runtime configuration area (~/.subversion/auth/ on Unix-like
systems or
%APPDATA%/Subversion/auth/ on Windows
<<
Regards,
MikeW
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@subversion.tigris.org
For additional commands, e-mail: users-help@subversion.tigris.org
#############################################################################################
The information transmitted is intended only for the person or entity to which it
is addressed and may contain confidential and/or privileged material.
Any review, retransmission, dissemination or other use of, or taking of any action
in reliance upon, this information by persons or entities other than the intended
recipient is prohibited. If you received this in error, please contact the sender and
delete the material from any computer.
Furthermore, the information contained in this message, and any attachments thereto, is
for information purposes only and may contain the personal views and opinions of the
author, which are not necessarily the views and opinions of the company.
#############################################################################################
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@subversion.tigris.org
For additional commands, e-mail: users-help@subversion.tigris.org
Re: User info
Posted by MikeW <mw...@yahoo.co.uk>.
Geoffrey Devantier <Geoffrey.Devantier <at> derivco.com> writes:
>
> Hi
>
> I have a little utility that is intended to be run from the root of a
> svn working folder. This utility automates some actions by issuing svn
> cmds via a command shell. While it is possible to use these commands
> natively in the context of the current user, I would like to retrieve
> the user login name in order to keep track of who is doing what. Does
> anyone have any idea as to how I can get this info?
>
> Thanks
> Geoff
>
Linux: $USER
Windows: $USERNAME
Or is the svn login name different from the OS login name ?
Also see svn-book.pdf section Client Credentials Caching:
>>
By default, whenever the command-line client successfully responds
to a server's authentication challenge, it saves the credentials in the user's
private runtime configuration area (~/.subversion/auth/ on Unix-like systems or
%APPDATA%/Subversion/auth/ on Windows
<<
Regards,
MikeW
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@subversion.tigris.org
For additional commands, e-mail: users-help@subversion.tigris.org
User info
Posted by Geoffrey Devantier <Ge...@derivco.com>.
Hi
I have a little utility that is intended to be run from the root of a
svn working folder. This utility automates some actions by issuing svn
cmds via a command shell. While it is possible to use these commands
natively in the context of the current user, I would like to retrieve
the user login name in order to keep track of who is doing what. Does
anyone have any idea as to how I can get this info?
Thanks
Geoff
#############################################################################################
The information transmitted is intended only for the person or entity to which it
is addressed and may contain confidential and/or privileged material.
Any review, retransmission, dissemination or other use of, or taking of any action
in reliance upon, this information by persons or entities other than the intended
recipient is prohibited. If you received this in error, please contact the sender and
delete the material from any computer.
Furthermore, the information contained in this message, and any attachments thereto, is
for information purposes only and may contain the personal views and opinions of the
author, which are not necessarily the views and opinions of the company.
#############################################################################################
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@subversion.tigris.org
For additional commands, e-mail: users-help@subversion.tigris.org
Re: Code Reviews
Posted by MikeW <mw...@yahoo.co.uk>.
<dcaldwel <at> danielcaldwell.com> writes:
>
>
> Does anyone have any good strategies for tracking code reviews with
subversion? I'm thinking of tagging
> after every code review and comparing between tags, but that seems excessive,
any suggestions? Thanks.
>
> -Daniel
>
Depends on how exactly you want to use it - after every bug fix changeset ?
One approach would be to use properties, which could then be set with the
identifier of the reviewer & timestamp, by a script of some kind.
You might consider tying your defect reporting mechanism into the system
to ensure that 'fixed' defects were flagged as crosschecked by a reviewer.
I saw one approach in which the reviewer used a web-based tool
which picked up the files concerned and allowed the reviewer
to add a status (OK; needs rework; rework at next rev) and notes to each file.
The 'fix' only got a green light in the tool once all files got
the OK status.
Regards,
MikeW
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@subversion.tigris.org
For additional commands, e-mail: users-help@subversion.tigris.org
RE: Code Reviews
Posted by Olivier Dagenais <ol...@formark.com>.
> Does anyone have any good strategies for tracking code reviews with
> subversion? I'm thinking of tagging after every code review and
> comparing between tags, but that seems excessive, any suggestions?
We're doing something similar to what Michael suggested, except it's a lot simpler to move from "draft" to "live" (to use his terms) when you use the built-in "merge" features of Subversion. This approach is called "feature branches" in the Subversion documentation: http://svnbook.red-bean.com/en/1.1/ch04s04.html#svn-ch-4-sect-4.4.2
When a contributor is done with their feature/task, they post the path to the branch and which revisions are involved. The committer will take a look at the commits in the branch and then double-check the result of merging the branch back into the trunk.
Note that, as suggested in the documentation, there's overhead in branching. We work around that by having contributors only branch when there are file operations to be performed, otherwise they can submit a patch against the trunk. Karl recently reminded us how easy it is to switch from one to another (when you realize your changes are no longer a simple patch): http://svn.haxx.se/users/archive-2007-05/0739.shtml
HTH,
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
Olivier Dagenais
Software Engineering / Génie logiciel
Formark - Combine the Best of SharePoint® and Livelink®
Phone: 613-599-5173 ext 238
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
Make sure you don't miss anything: subscribe to the Formark Newsletter:
http://www.formark.com/support/register/index.asp
Re: Code Reviews
Posted by Michael Wechner <mi...@wyona.com>.
dcaldwel@danielcaldwell.com wrote:
>Does anyone have any good strategies for tracking code reviews with subversion? I'm thinking of tagging after every code review and comparing between tags, but that seems excessive, any suggestions?
>
well, I was looking for something similar
http://svn.haxx.se/users/archive-2007-05/0205.shtml
and also made a suggestion about a draft and live branch.
HTH
Michael
> Thanks.
>
>-Daniel
>
>
>---------------------------------------------------------------------
>To unsubscribe, e-mail: users-unsubscribe@subversion.tigris.org
>For additional commands, e-mail: users-help@subversion.tigris.org
>
>
>
>
--
Michael Wechner
Wyona - Open Source Content Management - Apache Lenya
http://www.wyona.com http://lenya.apache.org
michael.wechner@wyona.com michi@apache.org
+41 44 272 91 61
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@subversion.tigris.org
For additional commands, e-mail: users-help@subversion.tigris.org
Re: Code Reviews
Posted by Karl Fogel <kf...@red-bean.com>.
<dc...@danielcaldwell.com> writes:
> Does anyone have any good strategies for tracking code reviews with
> subversion? I'm thinking of tagging after every code review and
> comparing between tags, but that seems excessive, any suggestions?
See http://code.google.com/p/gvn/
-Karl
--
Subversion support & consulting <> http://producingoss.com/consulting.html
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@subversion.tigris.org
For additional commands, e-mail: users-help@subversion.tigris.org
Re: Code Reviews
Posted by Rene Medellin <me...@yahoo.com>.
We use Crucible from Cenqua:
http://www.cenqua.com/crucible/
Still relatively new but works pretty well so far.
- Rene
--- dcaldwel@danielcaldwell.com wrote:
>
> Does anyone have any good strategies for tracking
> code reviews with subversion? I'm thinking of
> tagging after every code review and comparing
> between tags, but that seems excessive, any
> suggestions? Thanks.
>
> -Daniel
>
>
>
---------------------------------------------------------------------
> To unsubscribe, e-mail:
> users-unsubscribe@subversion.tigris.org
> For additional commands, e-mail:
> users-help@subversion.tigris.org
>
>
____________________________________________________________________________________You snooze, you lose. Get messages ASAP with AutoCheck
in the all-new Yahoo! Mail Beta.
http://advision.webevents.yahoo.com/mailbeta/newmail_html.html
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@subversion.tigris.org
For additional commands, e-mail: users-help@subversion.tigris.org