You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/06/24 05:13:07 UTC
[GitHub] [cloudstack] utchoang opened a new pull request #5151: [WIP] UI: Upgrade to Vue3 library
utchoang opened a new pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151
### Description
To Fixes https://github.com/apache/cloudstack/issues/5093
This PR to migrate Vue and And library:
- Vue 2 -> Vue 3
- And 1.7.x -> And 2.x.x
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #5151: [WIP] UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-909033344
@utchoang please discuss on dev@, if this ends up rewriting the whole UI - we may want to discuss some other strategy to do it (for ex. use some automated tool or in phases?) and start with just the bare minimum just to upgrade the dependency library from 2.x to 3.x (https://v3.vuejs.org/guide/migration/introduction.html) cc @davidjumani @shwstppr @Pearl1594
Also it seems 2.x continues to be maintained so we're also not in a hurry for that - https://github.com/vuejs/vue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5151: [WIP] UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-915934143
@rhtyd a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-926331734
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #5151: [WIP] UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-915933633
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1034660365
@davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1034571216
@davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1041112253
@davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1041063587
@utchoang Can you please address the issues and resolve the conflicts? Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1047420066
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1048450615
@utchoang There are still conflicts. Can you please fix them ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1048515535
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1050519937
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1053990586
@davidjumani a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1054041718
@rohityadavcloud a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-972635362
Ping @utchoang is this ready for merging, can you also bump/upgrade all the UI dependencies. It's usually a better idea to get significant changes in during start of a new major release branch (4.17) cc @davidjumani @Pearl1594 @shwstppr
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-972680582
@rhtyd Yes, but need to testing it more closely.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-985276921
@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang edited a comment on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
utchoang edited a comment on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1020969019
@Pearl1594
- As for the menu, I have edited it a bit and you can check if it works more smoothly.
- According to the step you mentioned, in the old version, it worked like that. If you want I will edit it to make it work as expected.
- Regarding v-model: value="xxxx" according to my test, it only applies to form: inputs, select,... And v-model="xxxx" is still working fine for other components so I think there is no need to replace it. You can check and if it needs to be changed let me know. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1020969019
@Pearl1594
- As for the menu, I have edited it a bit and you can check if it works more smoothly.
- According to the step you mentioned, in the old version, it worked like that. If you want I will edit it to make it work as expected.
- Regarding v-model: value = "xxxx" according to my test, it only applies to form: inputs, select,... And v-model="xxxx" is still working fine for other components so I think there is no need to replace it. You can check and if it needs to be changed let me know. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1008606998
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-928903885
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1004183514
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1004255128
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 2072
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #5151: [WIP] UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-925583639
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1012946985
Thanks @utchoang
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1020969019
@Pearl1594
- As for the menu, I have edited it a bit and you can check if it works more smoothly.
- According to the step you mentioned, in the old version, it worked like that. If you want I will edit it to make it work as expected.
- Regarding v-model: value = "xxxx" according to my test, it only applies to form: inputs, select,... And v-model="xxxx" is still working fine for other components so I think there is no need to replace it. You can check and if it needs to be changed let me know. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1048480975
@davidjumani a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1048545023
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 2695
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1046666195
@davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1046862959
Ping for review @rohityadavcloud
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang edited a comment on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
utchoang edited a comment on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1053853236
@rohityadavcloud As for the columns dropdown/list, I think to switch to https://www.antdv.com/components/drawer/. What do you think? cc @davidjumani
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1053883780
@rohityadavcloud cc @davidjumani What do you think if I will combine `filter by` with `columns` as shown below?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1053904209
>
+1 from my side
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1053920474
@davidjumani Do you mean like this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1050520153
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1050819283
Overall LGTM but there are still issues;
1. The settings button (blue) is misleading, click this and clicking on save is misleading - this doesn't save the theme or UI properties in the mgmt server but only for rootadmin in the browser. Do we have this for users too? I think users shouldn't be able to see this, and click on save can download a properties/json file that gives hint to the admin they need to do something with it. What do you think @utchoang @davidjumani @Pearl1594 @nvazquez ?
<img width="1221" alt="Screenshot 2022-02-25 at 5 56 25 PM" src="https://user-images.githubusercontent.com/95203/155715997-96f101e5-cc4e-4c82-b8ab-ac3b94acb6a5.png">
2. The metrics button/slides causes a mess in most screens - I think the table don't have a horizontal scroll bar which is causing this - pl compare with the 4.16 UI:
<img width="1218" alt="Screenshot 2022-02-25 at 5 58 10 PM" src="https://user-images.githubusercontent.com/95203/155716181-a981f210-1a42-4a86-919c-dd042116811e.png">
3. Check all basic UI elements, for ex. the adv search bar for volumes doesn't load up (probably some bug). The adv search option do show up in 4.16 UI:
<img width="921" alt="Screenshot 2022-02-25 at 6 00 29 PM" src="https://user-images.githubusercontent.com/95203/155716282-c831a46a-e32b-4b61-96da-64038b921834.png">
4. Suggestion -> can we replace the columns dropdown/UI element with a button somewhere on the table or as an icon - this takes up too much space and messes up the UI view on smaller 13-14" laptops/screens. May be the search bar width can be reduced to compensate for that?
<img width="964" alt="Screenshot 2022-02-25 at 6 01 20 PM" src="https://user-images.githubusercontent.com/95203/155716352-c45ace1a-83e9-4091-a2c1-4c84b68017ff.png">
A full test of UI is necessary to check if any of the actions fail. cc @NuxRo @borisstoyanov @vladimirpetrov @nvazquez
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1055007906
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1007877950
@utchoang can you fix the conflict and advise if you've completed testing on your side, is this now ready for our testing and review yet? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1034587819
@davidjumani a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1031114821
@rohityadavcloud a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1034726874
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 2567
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1041109108
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1062783782
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1062536472
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1062497216
Hi @utchoang I see the following error on the package building job, can you please address?
````
- Building for production...
ERROR Failed to compile with 1 error2:27:32 AM
error in ./src/components/header/UserMenu.vue
Module Error (from ./node_modules/@vue/cli-service/node_modules/vue-loader-v16/dist/index.js):
VueCompilerError: Element is missing end tag.
at /jenkins/workspace/acs-centos7-pkg-builder/dist/rpmbuild/BUILD/cloudstack-4.17.0.0-SNAPSHOT/ui/src/components/header/UserMenu.vue:36:11
34 | </a-avatar>
35 | <a-avatar v-else class="user-menu-avatar avatar" size="small" :style="{ backgroundColor: '#1890ff', color: 'white' }">
36 | <template #icon><user-outlined />
| ^
37 | </a-avatar>
38 | <span>{{ nickname() }}</span>
````
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1062796175
@davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1056648529
@rohityadavcloud a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1056647719
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1062784631
@davidjumani a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1061944862
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5151: [WIP] UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-925583639
UI build: :heavy_multiplication_x:
(SL-JID-688)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1038615164
@davidjumani a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1038523816
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1041325387
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1034587152
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1034570654
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani edited a comment on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
davidjumani edited a comment on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1034684433
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1046665426
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1047664787
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1048480547
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1048484018
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5151 (SL-JID-1179)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1048662552
@davidjumani a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1048662052
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-988391139
@davidjumani Yes, I am also doing manual testing of the functions, you can review it now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-981449717
Sure @utchoang can you finish a round of testing on your side and advise us when this is ready for review/testing. Pl also check and upgrade any other dependencies. Happy to have a few of us do a round of testing, this these are major changes it would make sense to merge this PR earlier towards 4.17 so we've at least a quarter to stabilise the main branch. cc @shwstppr @Pearl1594 @davidjumani @svenvogel @borisstoyanov @vladimirpetrov
For testing you can execute a full test plan, for example from here https://github.com/apache/cloudstack-primate/blob/master/.github/ISSUE_TEMPLATE/test_full_plan.md
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1050537421
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 2712
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1050763429
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1050764029
@rohityadavcloud a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1050772699
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5151 (SL-JID-1188)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1050881011
Thanks @NuxRo @davidjumani @rohityadavcloud for testing
@utchoang can you please check @rohityadavcloud's comments? We'll continue the testing after that. Thanks for your work
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang removed a comment on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
utchoang removed a comment on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-982366414
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-982366666
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-985279453
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5151 (SL-JID-878)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1017300259
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang edited a comment on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
utchoang edited a comment on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1020969019
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on a change in pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on a change in pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#discussion_r791382666
##########
File path: ui/src/components/menu/SMenu.vue
##########
@@ -0,0 +1,155 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+<template>
Review comment:
Has this component been created as a replacement to menu.js? If so, should we remove that file?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang commented on a change in pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
utchoang commented on a change in pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#discussion_r791499265
##########
File path: ui/src/components/header/TranslationMenu.vue
##########
@@ -18,36 +18,35 @@
<template>
<a-dropdown>
<span class="action ant-dropdown-link translation-menu">
- <font-awesome-icon :icon="['fas', 'language']" size="lg" />
+ <TranslationOutlined />
</span>
- <a-menu
- slot="overlay"
- :selectedKeys="[language]"
- @click="onClick">
- <a-menu-item key="en" value="enUS">English</a-menu-item>
- <a-menu-item key="hi" value="hi">हिन्दी</a-menu-item>
- <a-menu-item key="ja_JP" value="jpJP">日本語</a-menu-item>
- <a-menu-item key="ko_KR" value="koKR">한국어</a-menu-item>
- <a-menu-item key="zh_CN" value="zhCN">简体中文</a-menu-item>
- <a-menu-item key="ar" value="arEG">Arabic</a-menu-item>
- <a-menu-item key="ca" value="caES">Catalan</a-menu-item>
- <a-menu-item key="de_DE" value="deDE">Deutsch</a-menu-item>
- <a-menu-item key="es" value="esES">Español</a-menu-item>
- <a-menu-item key="fr_FR" value="frFR">Français</a-menu-item>
- <a-menu-item key="it_IT" value="itIT">Italiano</a-menu-item>
- <a-menu-item key="hu" value="huHU">Magyar</a-menu-item>
- <a-menu-item key="nl_NL" value="nlNL">Nederlands</a-menu-item>
- <a-menu-item key="nb_NO" value="nbNO">Norsk</a-menu-item>
- <a-menu-item key="pl" value="plPL">Polish</a-menu-item>
- <a-menu-item key="pt_BR" value="ptBR">Português brasileiro</a-menu-item>
- <a-menu-item key="ru_RU" value="ruRU">Русский</a-menu-item>
- <a-menu-item key="el_GR" value="elGR">Ελληνικά</a-menu-item>
Review comment:
added
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5151: [WIP] UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-925626020
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5151 (SL-JID-689)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang removed a comment on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
utchoang removed a comment on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-926286468
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-928907577
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5151 (SL-JID-703)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #5151: [WIP] UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-909033344
@utchoang please discuss on dev@, if this ends up rewriting the whole UI - we may want to discuss some other strategy to do it (for ex. use some automated tool or in phases?) and start with just the bare minimum just to upgrade the dependency library from 2.x to 3.x (https://v3.vuejs.org/guide/migration/introduction.html) cc @davidjumani @shwstppr @Pearl1594
Also it seems 2.x continues to be maintained so we're also not in a hurry for that - https://github.com/vuejs/vue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1017301046
@Pearl1594 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1055005111
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5151 (SL-JID-1199)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1056498739
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 2740
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1062543556
@davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1062540731
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1062791264
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5151 (SL-JID-1230)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang removed a comment on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
utchoang removed a comment on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-982304822
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang edited a comment on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
utchoang edited a comment on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1020969019
@Pearl1594
- As for the menu, I have edited it a bit and you can check if it works more smoothly. I don't know about this part, but when the menu is opened in the list screen, it will lag. Looking for a fix.
- According to the step you mentioned, in the old version, it worked like that. If you want I will edit it to make it work as expected.
- Regarding v-model: value="xxxx" according to my test, it only applies to form: inputs, select,... And v-model="xxxx" is still working fine for other components so I think there is no need to replace it. You can check and if it needs to be changed let me know. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1031114495
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1038639323
@davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1038638139
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1038698439
@davidjumani When I test on Firefox (version 97.0) the fonts are the same in QA and PR 5151. However, fonts are also different from your images. Could it be the browser?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang removed a comment on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
utchoang removed a comment on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1003266090
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1004182816
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5151 (SL-JID-968)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1012406064
Sorry looks like there are still conflicts @utchoang
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-928903731
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-928903885
@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-935392493
Thanks @utchoang I'll test / review once 416 is out
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5151: [WIP] UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-915938163
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5151 (SL-JID-619)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang commented on a change in pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
utchoang commented on a change in pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#discussion_r791499265
##########
File path: ui/src/components/header/TranslationMenu.vue
##########
@@ -18,36 +18,35 @@
<template>
<a-dropdown>
<span class="action ant-dropdown-link translation-menu">
- <font-awesome-icon :icon="['fas', 'language']" size="lg" />
+ <TranslationOutlined />
</span>
- <a-menu
- slot="overlay"
- :selectedKeys="[language]"
- @click="onClick">
- <a-menu-item key="en" value="enUS">English</a-menu-item>
- <a-menu-item key="hi" value="hi">हिन्दी</a-menu-item>
- <a-menu-item key="ja_JP" value="jpJP">日本語</a-menu-item>
- <a-menu-item key="ko_KR" value="koKR">한국어</a-menu-item>
- <a-menu-item key="zh_CN" value="zhCN">简体中文</a-menu-item>
- <a-menu-item key="ar" value="arEG">Arabic</a-menu-item>
- <a-menu-item key="ca" value="caES">Catalan</a-menu-item>
- <a-menu-item key="de_DE" value="deDE">Deutsch</a-menu-item>
- <a-menu-item key="es" value="esES">Español</a-menu-item>
- <a-menu-item key="fr_FR" value="frFR">Français</a-menu-item>
- <a-menu-item key="it_IT" value="itIT">Italiano</a-menu-item>
- <a-menu-item key="hu" value="huHU">Magyar</a-menu-item>
- <a-menu-item key="nl_NL" value="nlNL">Nederlands</a-menu-item>
- <a-menu-item key="nb_NO" value="nbNO">Norsk</a-menu-item>
- <a-menu-item key="pl" value="plPL">Polish</a-menu-item>
- <a-menu-item key="pt_BR" value="ptBR">Português brasileiro</a-menu-item>
- <a-menu-item key="ru_RU" value="ruRU">Русский</a-menu-item>
- <a-menu-item key="el_GR" value="elGR">Ελληνικά</a-menu-item>
Review comment:
added
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-993231737
@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1001443300
Hi @utchoang hope you're having a good time! No rush - I'm just wondering if your PR has reached end of your dev cycle so we can help with some review and testing. This bring major changes to the UI so it would make sense to get it in main branch soon so the UI stabilisation effort can get 2-3 months before 4.17 RC1 around Q1/Q2 timeframe. cc @davidjumani @borisstoyanov @vladimirpetrov @shwstppr @Pearl1594
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1001481637
@rohityadavcloud Hi Rohit, I think PR is OK for now and we can proceed with review and testing now. If there is an error or problem please let me know so I can fix it soon. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-982304822
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-982366666
@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1003266123
UI build: :heavy_multiplication_x:
(SL-JID-957)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-982307497
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5151 (SL-JID-866)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang edited a comment on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
utchoang edited a comment on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1053883780
@rohityadavcloud cc @davidjumani What do you think if I will combine `filter by` and `columns` as shown below?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1056658492
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5151 (SL-JID-1202)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez merged pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
nvazquez merged pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1062794573
@davidjumani a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1031234151
@utchoang some initial notes:
- there's a lot of css issues between this PR and the main branch, for ex. issue of margins, colours (on hover)
- settings panel visible - what's the use of that? (it doesn't really save any setting, either a json downloaded or in backend)
- open UI from main and during development/testing compare/fix issues from this PR
- Can you also run a smoketest or full test plan on the UI https://github.com/apache/cloudstack-primate/blob/master/.github/ISSUE_TEMPLATE/test_full_plan.md and report your findings?
Here are screenshots for comparing UI from this PR against from ACS 4.16.0.0:
<img width="1218" alt="Screenshot 2022-02-07 at 2 37 25 PM" src="https://user-images.githubusercontent.com/95203/152758216-a42d9770-0bca-4483-bda3-bebb2e60a780.png">
<img width="1218" alt="Screenshot 2022-02-07 at 2 37 18 PM" src="https://user-images.githubusercontent.com/95203/152758240-9322115f-bb7a-4d9b-9ce3-c9f1af642778.png">
Another one with the menus collapsed: (notice the colour in dashboard nav, isn't fully stretched)
<img width="1219" alt="Screenshot 2022-02-07 at 2 37 43 PM" src="https://user-images.githubusercontent.com/95203/152758327-0bbf9f40-ff6d-423a-aa25-e6b04b7369b4.png">
Resource view: (note the gutter widths, gaps/margin between cards)
<img width="1218" alt="Screenshot 2022-02-07 at 2 38 31 PM" src="https://user-images.githubusercontent.com/95203/152758445-e58ff790-2dcc-43e2-bf3d-51f5a500ddb4.png">
<img width="1220" alt="Screenshot 2022-02-07 at 2 38 39 PM" src="https://user-images.githubusercontent.com/95203/152758423-4a9f3f76-e742-4ba2-be56-a89165d2bba0.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1030663116
Hi @utchoang can you please fix the conflicts? Is this PR ready for review/testing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1034614175
@sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1034593767
UI build: :heavy_multiplication_x:
(SL-JID-1118)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1034703110
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 2566
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1041112028
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1039839896
@utchoang Thanks, I'll have a look at the fonts issue. Meanwhile could you look into the following issues :
1. Unable to upload a template
2. Label not visible when trying to migrate a VM
I'll add more as I come across them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1038620352
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5151 (SL-JID-1130)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang edited a comment on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
utchoang edited a comment on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1038528147
@davidjumani About the font, I don't know where to look. Can you be more specific?
In my Develop tools:
QA:
Vue3:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1047714377
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 2683
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1046720263
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 2670
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1050520381
@davidjumani a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1048662552
@davidjumani a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5151: [WIP] UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-925621826
@davidjumani a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #5151: [WIP] UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-925621356
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-926334162
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5151 (SL-JID-693)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5151: [WIP] UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-925578854
@davidjumani a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-926332037
@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1005452143
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1007877950
@utchoang can you fix the conflict and advise if you've completed testing on your side, is this now ready for our testing and review yet? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1031114971
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1034617604
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1034659137
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1038660434
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 2595
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1047685001
@davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1047478687
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1047146511
Sorry @utchoang some conflicts again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1047595223
@davidjumani `The set default nic button is messed up` I can't find where to fix the error, can you be more specific?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1053990261
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1054040437
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 2728
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1056387051
@davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1062543032
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1047665254
@davidjumani a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1012956383
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5151 (SL-JID-1015)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1017306424
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5151 (SL-JID-1043)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1003267496
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5151 (SL-JID-958)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1002981648
Thanks @utchoang pl rebase against latest main branch, fix conflicts and do a quick round of your testing and let us know when we can commence testing this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #5151: [WIP] UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-909033344
@utchoang please discuss on dev@, if this ends up rewriting the whole UI - we may want to discuss some other strategy to do it (for ex. use some automated tool or in phases?) and start with just the bare minimum just to upgrade the dependency library from 2.x to 3.x (https://v3.vuejs.org/guide/migration/introduction.html) cc @davidjumani @shwstppr @Pearl1594
Also it seems 2.x continues to be maintained so we're also not in a hurry for that - https://github.com/vuejs/vue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1046465254
@utchoang Can you please fix the conflicts? Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1046487705
@utchoang The bulk actions does not update once the task is completed, and the status colours do not show
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1035877472
@utchoang Really good work! However, after a quick look (I'm still looking), here are a few issues :
1. The font is different :
Before :
After :
2. Unable to list projects in the header
3. Unalbe to edit templates
4. Colour difference between dropdown selections
Before :
After :
5. Unable to upload a template
6. Issue trying to migrate a VM
7. Issue displaying certain icons
8. Error on opening the upload volumes form
9. Error adding comments
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1034625209
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5151 (SL-JID-1119)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1034684433
DomainAdmin
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1031115230
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1031158893
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 2484
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1039905153
@utchoang A few more issues
1. No link to download the volume / template in the notification
2. Default network to create should be isolated but shows as L2
3. Unable to select VM while creating PF and LB rules
4. Error on closing change disk offering form
5. Migrate volume form is misaligned
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang removed a comment on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
utchoang removed a comment on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1038523816
@davidjumani About the font, I don't know where to look, because according to the comparison in the Develop tools section, I see it as the same. Can you be more specific?
QA:
Vue3:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani edited a comment on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
davidjumani edited a comment on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1039839896
@utchoang Thanks, I'll have a look at the fonts issue. Meanwhile could you look into the following issues :
1. Unable to upload a template
2. Label not visible when trying to migrate a VM
3. Creating offerings : Compute, system, network
I'll add more as I come across them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1060443523
Not yet @rohityadavcloud - I'll update once testing is complete
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1060964747
@utchoang great work! I have been testing the PR and found out some visibility issues (still no functionality issues, which is great). Compared your PR to the current main branch and found some differences:
1: Responsive seems to be broken - please check the following images while resizing the window:
<img width="1678" alt="Screen Shot 2022-03-07 at 14 03 21" src="https://user-images.githubusercontent.com/5295080/157089838-d26008da-5639-4bd9-b19d-43790dfb7840.png">
<img width="826" alt="Screen Shot 2022-03-07 at 14 03 04" src="https://user-images.githubusercontent.com/5295080/157089854-1e836af6-6220-4acd-b3ec-ee30a7456540.png">
<img width="965" alt="Screen Shot 2022-03-07 at 14 02 11" src="https://user-images.githubusercontent.com/5295080/157089930-2e7b39f9-e061-42dd-aac0-fb6e7154eaf1.png">
2: The top-right menu buttons do not work most of the times (Profile, Help). Logout works after few tries
<img width="269" alt="Screen Shot 2022-03-07 at 14 36 57" src="https://user-images.githubusercontent.com/5295080/157087642-63c3d333-2762-4168-a026-79f29cd4f97b.png">
3: The left menu has changed its behaviour, it now allows multiple collapsible menus open at the same time:
<img width="257" alt="Screen Shot 2022-03-07 at 14 39 28" src="https://user-images.githubusercontent.com/5295080/157088019-b6347ada-ceb2-49bb-9910-fae04d690a2e.png">
4: Some minor CSS differences Rohit and David have mentioned
Can you please address the first 3?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1054009697
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani removed a comment on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
davidjumani removed a comment on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1053904209
>
+1 from my side
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1055000281
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1054059132
Few nits, @utchoang @davidjumani cc @nvazquez pl also test as normal user account and domain accounts.
Notes:
- Worth hiding removing the blue gear/button for all accounts except the root admin
- the dashboard for user/account is broken
- please test a round as normal user account
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1062438675
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1062477713
@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1062537204
@davidjumani a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1061945700
@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1034480300
@utchoang Can you please fix the conflicts ? Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani removed a comment on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
davidjumani removed a comment on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1034587152
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1047478027
@utchoang Great job! Functionally almost everything seems to work. A few cosmetic issues :
- The link to individual events in the dashboard leads to a 404
- Clicking anywhere in the table selection should select that row (eg . in DeployVM form)
- Start VM should by default be checked in the deploy VM form
- On navigating back, itshould open the last opened tab
- The set default nic button is messed up
- The View instances, networks, users, etc. button in the info card redirects to the page without any filter for the selected resource
- Unable to upload a custom Role csv file
- When creating an account, let the current domain be selected by default in the dropdown
- Unable to configure / update any limits. The value is reset right after loosing focus on the element
- No accounts are visible in the dropdown when creating a user
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-926286684
@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #5151: [WIP] UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-914924448
This is significant bit of work, moving to next major milestone.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1005456085
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5151 (SL-JID-976)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1003264314
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1003266206
@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1008838077
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5151 (SL-JID-997)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-982304974
@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-982369756
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5151 (SL-JID-867)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-981450076
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-926286468
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1003264476
@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang removed a comment on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
utchoang removed a comment on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1003264314
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1003266090
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1008607333
@sureshanaparti a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1008464156
@rohityadavcloud I have finished testing in my environment. You can start testing/reviewing it now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1009886566
Thanks @utchoang we'll start some testing cc @davidjumani @shwstppr @Pearl1594
Pl help fix the conflicts too (unfortunately that will keep happening until we merge this PR - so let's try to test/merge this PR soon)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1031115390
@rohityadavcloud a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1034618200
@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani edited a comment on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
davidjumani edited a comment on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1035877472
@utchoang Really good work! However, after a quick look (I'm still looking), here are a few issues :
1. The font is different :
Before :
After :
2. Unable to list projects in the header
3. Unalbe to edit templates
4. Colour difference between dropdown selections
Before :
After :
5. Unable to upload a template
6. Issue trying to migrate a VM
7. Issue displaying certain icons
8. Error on opening the upload volumes form
9. Error adding comments
Adding more on here
10. Creating offerings : Compute, system, network
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang edited a comment on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
utchoang edited a comment on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1038528147
@davidjumani About the font, I don't know where to look. Can you be more specific?
In my Develop tools:
QA:
Vue3:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1041108383
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5151 (SL-JID-1141)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1039839896
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1047434936
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 2678
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1047484043
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5151 (SL-JID-1170)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1047607375
> @davidjumani `The set default nic button is messed up` I can't find where to fix the error, can you be more specific?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1053938094
@rohityadavcloud @davidjumani After changing, dropdown columns will look like below
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1053994759
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5151 (SL-JID-1195)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1054041476
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1054046481
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5151 (SL-JID-1196)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani removed a comment on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
davidjumani removed a comment on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1048662052
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1053926957
@utchoang Yes but just at the corner of the table, not in every header cell
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1055008659
@davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1053905254
@utchoang Is it possible to add a filter like icon at the corner of the table header for the columns ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1062834800
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 2809
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1038528147
@davidjumani About the font, I don't know where to look. Can you be more specific?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani edited a comment on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
davidjumani edited a comment on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1039839896
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1038523816
@davidjumani About the font, I don't know where to look, because according to the comparison in the Develop tools section, I see it as the same. Can you be more specific?
QA:
Vue3:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1035885944
@davidjumani Thanks, I will check these issues again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1034573230
Packaging result: :heavy_multiplication_x: el7 :heavy_multiplication_x: el8 :heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-JID 2560
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1034684950
@davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1041104568
@davidjumani a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1041133190
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 2629
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1041150343
Thanks @utchoang ! A few more issues :
1. Migrate instance / volume table is incomplete / not filled in
2. Error populating settings options
3. Error uploading volume from local
4. VM selection table is not aligned for the Static NAT form
5. Autogen view throws errors once static nat is enabled for an IP
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1047420247
@davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1048515980
@davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-987835130
@utchoang Is this ready for review ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1004171596
@rohityadavcloud a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on a change in pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on a change in pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#discussion_r791396190
##########
File path: ui/src/components/header/TranslationMenu.vue
##########
@@ -18,36 +18,35 @@
<template>
<a-dropdown>
<span class="action ant-dropdown-link translation-menu">
- <font-awesome-icon :icon="['fas', 'language']" size="lg" />
+ <TranslationOutlined />
</span>
- <a-menu
- slot="overlay"
- :selectedKeys="[language]"
- @click="onClick">
- <a-menu-item key="en" value="enUS">English</a-menu-item>
- <a-menu-item key="hi" value="hi">हिन्दी</a-menu-item>
- <a-menu-item key="ja_JP" value="jpJP">日本語</a-menu-item>
- <a-menu-item key="ko_KR" value="koKR">한국어</a-menu-item>
- <a-menu-item key="zh_CN" value="zhCN">简体中文</a-menu-item>
- <a-menu-item key="ar" value="arEG">Arabic</a-menu-item>
- <a-menu-item key="ca" value="caES">Catalan</a-menu-item>
- <a-menu-item key="de_DE" value="deDE">Deutsch</a-menu-item>
- <a-menu-item key="es" value="esES">Español</a-menu-item>
- <a-menu-item key="fr_FR" value="frFR">Français</a-menu-item>
- <a-menu-item key="it_IT" value="itIT">Italiano</a-menu-item>
- <a-menu-item key="hu" value="huHU">Magyar</a-menu-item>
- <a-menu-item key="nl_NL" value="nlNL">Nederlands</a-menu-item>
- <a-menu-item key="nb_NO" value="nbNO">Norsk</a-menu-item>
- <a-menu-item key="pl" value="plPL">Polish</a-menu-item>
- <a-menu-item key="pt_BR" value="ptBR">Português brasileiro</a-menu-item>
- <a-menu-item key="ru_RU" value="ruRU">Русский</a-menu-item>
- <a-menu-item key="el_GR" value="elGR">Ελληνικά</a-menu-item>
Review comment:
Any particular reason this translation was removed?
##########
File path: ui/src/components/menu/SideMenu.vue
##########
@@ -69,6 +68,11 @@ export default {
required: true
}
},
+ computed: {
+ isCollaped () {
Review comment:
nit: minor Typo
```suggestion
isCollapsed () {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on a change in pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on a change in pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#discussion_r791382666
##########
File path: ui/src/components/menu/SMenu.vue
##########
@@ -0,0 +1,155 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+<template>
Review comment:
Has this component been created as a replacement to menu.js? If so, should we remove that file?
##########
File path: ui/src/components/header/TranslationMenu.vue
##########
@@ -18,36 +18,35 @@
<template>
<a-dropdown>
<span class="action ant-dropdown-link translation-menu">
- <font-awesome-icon :icon="['fas', 'language']" size="lg" />
+ <TranslationOutlined />
</span>
- <a-menu
- slot="overlay"
- :selectedKeys="[language]"
- @click="onClick">
- <a-menu-item key="en" value="enUS">English</a-menu-item>
- <a-menu-item key="hi" value="hi">हिन्दी</a-menu-item>
- <a-menu-item key="ja_JP" value="jpJP">日本語</a-menu-item>
- <a-menu-item key="ko_KR" value="koKR">한국어</a-menu-item>
- <a-menu-item key="zh_CN" value="zhCN">简体中文</a-menu-item>
- <a-menu-item key="ar" value="arEG">Arabic</a-menu-item>
- <a-menu-item key="ca" value="caES">Catalan</a-menu-item>
- <a-menu-item key="de_DE" value="deDE">Deutsch</a-menu-item>
- <a-menu-item key="es" value="esES">Español</a-menu-item>
- <a-menu-item key="fr_FR" value="frFR">Français</a-menu-item>
- <a-menu-item key="it_IT" value="itIT">Italiano</a-menu-item>
- <a-menu-item key="hu" value="huHU">Magyar</a-menu-item>
- <a-menu-item key="nl_NL" value="nlNL">Nederlands</a-menu-item>
- <a-menu-item key="nb_NO" value="nbNO">Norsk</a-menu-item>
- <a-menu-item key="pl" value="plPL">Polish</a-menu-item>
- <a-menu-item key="pt_BR" value="ptBR">Português brasileiro</a-menu-item>
- <a-menu-item key="ru_RU" value="ruRU">Русский</a-menu-item>
- <a-menu-item key="el_GR" value="elGR">Ελληνικά</a-menu-item>
Review comment:
Any particular reason this translation was removed?
##########
File path: ui/src/components/menu/SideMenu.vue
##########
@@ -69,6 +68,11 @@ export default {
required: true
}
},
+ computed: {
+ isCollaped () {
Review comment:
nit: minor Typo
```suggestion
isCollapsed () {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1012947643
@rohityadavcloud a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-985275917
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1003264476
@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1003266123
UI build: :heavy_multiplication_x:
(SL-JID-957)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1060390067
Ping @andrijapanicsb @nvazquez @davidjumani @weizhouapache @Pearl1594 - is this ready for merging?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1062491799
Packaging result: :heavy_multiplication_x: el7 :heavy_multiplication_x: el8 :heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-JID 2799
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1062794334
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1062795190
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-926289037
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5151 (SL-JID-690)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #5151: [WIP] UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-895103616
@utchoang I think there are huge no. of changes - are you strictly upgrading the library or also refactoring/rewriting components? Could this work be split into phases so some phase can still be completed for 4.16?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #5151: [WIP] UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-925578430
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1056385792
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1050523373
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5151 (SL-JID-1187)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1056227767
@utchoang Can you please fix the conflicts and also have a look at https://github.com/apache/cloudstack/blob/main/ui/src/views/compute/ResetSshKeyPair.vue
Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1054011884
@davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1055000836
@davidjumani a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-928903731
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-925621826
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani edited a comment on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
davidjumani edited a comment on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-935392493
Thanks @utchoang I'll test / review once 4.16 is out
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1047669678
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5151 (SL-JID-1173)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1048058119
@utchoang can you fix the conflicts? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1047684493
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1055030759
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 2733
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1050520071
@davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1053853236
@rohityadavcloud As for the columns dropdown/list, I think to switch to https://www.antdv.com/components/drawer/. What do you think? cc @davidjumani
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang removed a comment on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
utchoang removed a comment on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1053853236
@rohityadavcloud As for the columns dropdown/list, I think to switch to https://www.antdv.com/components/drawer/. What do you think? cc @davidjumani
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on a change in pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on a change in pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#discussion_r788536735
##########
File path: ui/src/components/view/ResourceLimitTab.vue
##########
@@ -119,7 +128,7 @@ export default {
if (this.formLoading) return
- this.form.validateFieldsAndScroll((err, values) => {
+ this.form.validateFields((err, values) => {
if (err) {
return
}
Review comment:
@utchoang I believe this should be changed?
```suggestion
this.formRef.value.validate().then(() => {
const values = toRaw(this.form)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5151: UI: Upgrade to Vue3 library
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1005452472
@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org