You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by al...@apache.org on 2007/05/23 20:25:01 UTC
svn commit: r541010 -
/incubator/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/html/form/FormComponent.java
Author: almaw
Date: Wed May 23 11:25:00 2007
New Revision: 541010
URL: http://svn.apache.org/viewvc?view=rev&rev=541010
Log:
isValid() was offending my sensibilities. Don't use final boolean[] hack.
Modified:
incubator/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/html/form/FormComponent.java
Modified: incubator/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/html/form/FormComponent.java
URL: http://svn.apache.org/viewvc/incubator/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/html/form/FormComponent.java?view=diff&rev=541010&r1=541009&r2=541010
==============================================================================
--- incubator/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/html/form/FormComponent.java (original)
+++ incubator/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/html/form/FormComponent.java Wed May 23 11:25:00 2007
@@ -31,7 +31,6 @@
import org.apache.wicket.MarkupContainer;
import org.apache.wicket.Page;
import org.apache.wicket.WicketRuntimeException;
-import org.apache.wicket.behavior.IBehavior;
import org.apache.wicket.markup.ComponentTag;
import org.apache.wicket.markup.html.WebMarkupContainer;
import org.apache.wicket.model.IComponentAssignedModel;
@@ -598,22 +597,22 @@
*/
public final boolean isValid()
{
- final boolean valid[] = { true };
- visitFormComponentsPostOrder(this, new IVisitor()
- {
+ class IsValidVisitor implements IVisitor {
+ boolean valid = true;
public Object formComponent(IFormVisitorParticipant formComponent)
{
final FormComponent fc = (FormComponent)formComponent;
if (fc.hasErrorMessage())
{
- valid[0] = false;
+ valid = false;
return Component.IVisitor.STOP_TRAVERSAL;
}
return Component.IVisitor.CONTINUE_TRAVERSAL;
}
- });
-
- return valid[0];
+ }
+ IsValidVisitor tmp = new IsValidVisitor();
+ visitFormComponentsPostOrder(this, tmp);
+ return tmp.valid;
}
/**