You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Oliver Szabo <os...@hortonworks.com> on 2015/12/10 21:03:56 UTC
Review Request 41220: In stack service scripts
"commandParams/version" is misused
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41220/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez, Sumit Mohanty, and Sebastian Toader.
Bugs: AMBARI-14330
https://issues.apache.org/jira/browse/AMBARI-14330
Repository: ambari
Description
-------
In this patch: https://reviews.apache.org/r/41133/
Although the issue was fixed, "commandParams/version" should not be redefined, because it used by RU/EU. Instead of using that parameter I using to less detailed version (2 digit) and an another condition (spark thriftserver config exists) to adding the needed configuration properties. (also I reverted the removed comment)
Diffs
-----
ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py c327c42
ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/params.py 732f32c
Diff: https://reviews.apache.org/r/41220/diff/
Testing
-------
Python tests succeeded for ambari-server.
Other Unit tests are in progress.
Thanks,
Oliver Szabo
Re: Review Request 41220: In stack service scripts
"commandParams/version" is misused
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41220/#review110134
-----------------------------------------------------------
Ship it!
Ship It!
- Alejandro Fernandez
On Dec. 12, 2015, 6:33 p.m., Oliver Szabo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41220/
> -----------------------------------------------------------
>
> (Updated Dec. 12, 2015, 6:33 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Sumit Mohanty, and Sebastian Toader.
>
>
> Bugs: AMBARI-14330
> https://issues.apache.org/jira/browse/AMBARI-14330
>
>
> Repository: ambari
>
>
> Description
> -------
>
> In this patch: https://reviews.apache.org/r/41133/
> Although the issue was fixed, "commandParams/version" should not be redefined, because it used by RU/EU. Instead of using that parameter I checking that thriftserver is available.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py a4e31bf
> ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/params.py c4bbdc1
>
> Diff: https://reviews.apache.org/r/41220/diff/
>
>
> Testing
> -------
>
> Python tests succeeded for ambari-server.
> Other Unit tests are in progress.
>
> FT: EU ugrade/downgrade:
> HDP 2.2 -> 2.3.0 no thriftserver
> HDP 2.2 -> 2.3.2 no thriftserver
> HDP 2.3.0 -> 2.3.2 no thriftserver
> HDP 2.3.2 -> 2.3.4 have thriftserver (this one is in progress)
>
>
> Thanks,
>
> Oliver Szabo
>
>
Re: Review Request 41220: In stack service scripts
"commandParams/version" is misused
Posted by Sebastian Toader <st...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41220/#review110135
-----------------------------------------------------------
Ship it!
Ship It!
- Sebastian Toader
On Dec. 12, 2015, 7:33 p.m., Oliver Szabo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41220/
> -----------------------------------------------------------
>
> (Updated Dec. 12, 2015, 7:33 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Sumit Mohanty, and Sebastian Toader.
>
>
> Bugs: AMBARI-14330
> https://issues.apache.org/jira/browse/AMBARI-14330
>
>
> Repository: ambari
>
>
> Description
> -------
>
> In this patch: https://reviews.apache.org/r/41133/
> Although the issue was fixed, "commandParams/version" should not be redefined, because it used by RU/EU. Instead of using that parameter I checking that thriftserver is available.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py a4e31bf
> ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/params.py c4bbdc1
>
> Diff: https://reviews.apache.org/r/41220/diff/
>
>
> Testing
> -------
>
> Python tests succeeded for ambari-server.
> Other Unit tests are in progress.
>
> FT: EU ugrade/downgrade:
> HDP 2.2 -> 2.3.0 no thriftserver
> HDP 2.2 -> 2.3.2 no thriftserver
> HDP 2.3.0 -> 2.3.2 no thriftserver
> HDP 2.3.2 -> 2.3.4 have thriftserver (this one is in progress)
>
>
> Thanks,
>
> Oliver Szabo
>
>
Re: Review Request 41220: In stack service scripts
"commandParams/version" is misused
Posted by Alejandro Fernandez <af...@hortonworks.com>.
> On Dec. 14, 2015, 9:59 p.m., Alejandro Fernandez wrote:
> > Pushed to trunk,
> > commit e9c9f18cc0c0112f83b95d6edffbb657a33a72e5
> >
> > Pushed to branch-2.2,
> > commit fce013b54d94fb55a8953518332a099d4d1c01f3
Just reverted from branch-2.2, please remove that branch from the code review "branch" field
- Alejandro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41220/#review110316
-----------------------------------------------------------
On Dec. 12, 2015, 6:33 p.m., Oliver Szabo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41220/
> -----------------------------------------------------------
>
> (Updated Dec. 12, 2015, 6:33 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Sumit Mohanty, and Sebastian Toader.
>
>
> Bugs: AMBARI-14330
> https://issues.apache.org/jira/browse/AMBARI-14330
>
>
> Repository: ambari
>
>
> Description
> -------
>
> In this patch: https://reviews.apache.org/r/41133/
> Although the issue was fixed, "commandParams/version" should not be redefined, because it used by RU/EU. Instead of using that parameter I checking that thriftserver is available.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py a4e31bf
> ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/params.py c4bbdc1
>
> Diff: https://reviews.apache.org/r/41220/diff/
>
>
> Testing
> -------
>
> Python tests succeeded for ambari-server.
> Other Unit tests are in progress.
>
> FT: EU ugrade/downgrade:
> HDP 2.2 -> 2.3.0 no thriftserver
> HDP 2.2 -> 2.3.2 no thriftserver
> HDP 2.3.0 -> 2.3.2 no thriftserver
> HDP 2.3.2 -> 2.3.4 have thriftserver (this one is in progress)
>
>
> Thanks,
>
> Oliver Szabo
>
>
Re: Review Request 41220: In stack service scripts
"commandParams/version" is misused
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41220/#review110316
-----------------------------------------------------------
Pushed to trunk,
commit e9c9f18cc0c0112f83b95d6edffbb657a33a72e5
Pushed to branch-2.2,
commit fce013b54d94fb55a8953518332a099d4d1c01f3
- Alejandro Fernandez
On Dec. 12, 2015, 6:33 p.m., Oliver Szabo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41220/
> -----------------------------------------------------------
>
> (Updated Dec. 12, 2015, 6:33 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Sumit Mohanty, and Sebastian Toader.
>
>
> Bugs: AMBARI-14330
> https://issues.apache.org/jira/browse/AMBARI-14330
>
>
> Repository: ambari
>
>
> Description
> -------
>
> In this patch: https://reviews.apache.org/r/41133/
> Although the issue was fixed, "commandParams/version" should not be redefined, because it used by RU/EU. Instead of using that parameter I checking that thriftserver is available.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py a4e31bf
> ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/params.py c4bbdc1
>
> Diff: https://reviews.apache.org/r/41220/diff/
>
>
> Testing
> -------
>
> Python tests succeeded for ambari-server.
> Other Unit tests are in progress.
>
> FT: EU ugrade/downgrade:
> HDP 2.2 -> 2.3.0 no thriftserver
> HDP 2.2 -> 2.3.2 no thriftserver
> HDP 2.3.0 -> 2.3.2 no thriftserver
> HDP 2.3.2 -> 2.3.4 have thriftserver (this one is in progress)
>
>
> Thanks,
>
> Oliver Szabo
>
>
Re: Review Request 41220: In stack service scripts
"commandParams/version" is misused
Posted by Oliver Szabo <os...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41220/
-----------------------------------------------------------
(Updated Dec. 15, 2015, 12:14 a.m.)
Review request for Ambari, Alejandro Fernandez, Sumit Mohanty, and Sebastian Toader.
Changes
-------
removed branch-2.2
Bugs: AMBARI-14330
https://issues.apache.org/jira/browse/AMBARI-14330
Repository: ambari
Description
-------
In this patch: https://reviews.apache.org/r/41133/
Although the issue was fixed, "commandParams/version" should not be redefined, because it used by RU/EU. Instead of using that parameter I checking that thriftserver is available.
Diffs
-----
ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py a4e31bf
ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/params.py c4bbdc1
Diff: https://reviews.apache.org/r/41220/diff/
Testing
-------
Python tests succeeded for ambari-server.
Other Unit tests are in progress.
FT: EU ugrade/downgrade:
HDP 2.2 -> 2.3.0 no thriftserver
HDP 2.2 -> 2.3.2 no thriftserver
HDP 2.3.0 -> 2.3.2 no thriftserver
HDP 2.3.2 -> 2.3.4 have thriftserver (this one is in progress)
Thanks,
Oliver Szabo
Re: Review Request 41220: In stack service scripts
"commandParams/version" is misused
Posted by Oliver Szabo <os...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41220/
-----------------------------------------------------------
(Updated Dec. 12, 2015, 6:33 p.m.)
Review request for Ambari, Alejandro Fernandez, Sumit Mohanty, and Sebastian Toader.
Changes
-------
check thriftserver is available instead of checking version
Bugs: AMBARI-14330
https://issues.apache.org/jira/browse/AMBARI-14330
Repository: ambari
Description (updated)
-------
In this patch: https://reviews.apache.org/r/41133/
Although the issue was fixed, "commandParams/version" should not be redefined, because it used by RU/EU. Instead of using that parameter I checking that thriftserver is available.
Diffs (updated)
-----
ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py a4e31bf
ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/params.py c4bbdc1
Diff: https://reviews.apache.org/r/41220/diff/
Testing (updated)
-------
Python tests succeeded for ambari-server.
Other Unit tests are in progress.
FT: EU ugrade/downgrade:
HDP 2.2 -> 2.3.0 no thriftserver
HDP 2.2 -> 2.3.2 no thriftserver
HDP 2.3.0 -> 2.3.2 no thriftserver
HDP 2.3.2 -> 2.3.4 have thriftserver (this one is in progress)
Thanks,
Oliver Szabo
Re: Review Request 41220: In stack service scripts
"commandParams/version" is misused
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41220/#review109851
-----------------------------------------------------------
ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/params.py (line 156)
<https://reviews.apache.org/r/41220/#comment169507>
This will work for a fresh install of 2.3.0.0 and 2.3.4.0.
However, in an RU from 2.2 to 2.3.4.0 and then downgrade,
Script.is_hdp_stack_greater_or_equal("2.3") == true
and the config 'spark-thrift-sparkconf' exists,
so the downgrade back to 2.2 will be using 2.3.4.0 configs.
ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/params.py (line 163)
<https://reviews.apache.org/r/41220/#comment169505>
Are these properties always available in HDP 2.3, e.g., 2.3.0.0 and 2.3.2.0?
- Alejandro Fernandez
On Dec. 10, 2015, 8:03 p.m., Oliver Szabo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41220/
> -----------------------------------------------------------
>
> (Updated Dec. 10, 2015, 8:03 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Sumit Mohanty, and Sebastian Toader.
>
>
> Bugs: AMBARI-14330
> https://issues.apache.org/jira/browse/AMBARI-14330
>
>
> Repository: ambari
>
>
> Description
> -------
>
> In this patch: https://reviews.apache.org/r/41133/
> Although the issue was fixed, "commandParams/version" should not be redefined, because it used by RU/EU. Instead of using that parameter I using to less detailed version (2 digit) and an another condition (spark thriftserver config exists) to adding the needed configuration properties. (also I reverted the removed comment)
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py c327c42
> ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/params.py 732f32c
>
> Diff: https://reviews.apache.org/r/41220/diff/
>
>
> Testing
> -------
>
> Python tests succeeded for ambari-server.
> Other Unit tests are in progress.
>
>
> Thanks,
>
> Oliver Szabo
>
>