[jira] [Updated] (CALCITE-2435) Refactor SqlTestFactory

["Vladimir Sitnikov (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/CALCITE-2435?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vladimir Sitnikov updated CALCITE-2435:
---------------------------------------
    Description: 
Current SqlTestFactory/DelegatingSqlTestFactory is hard to reason about, and it is hard to extend/cache properly.

There are three key changes here:

1. Rename DefaultSqlTestFactory to SqlTestFactory. SqlTestFactory was an interface, however it has a single viable implementation, so it makes little sense to keep it as is.
2. Move MockCatalogReader.init and MockCatalogReader.init2 to MockCatalogReaderSimple and MockCatalogReaderExtended
3. Move MockCatalogReader to its own package, and split several inner classes to a top-level ones.
4. Replace usages

  was:Current SqlTestFactory/DelegatingSqlTestFactory is hard to reason about, and it is hard to extend/cache properly.


> Refactor SqlTestFactory
> -----------------------
>
>                 Key: CALCITE-2435
>                 URL: https://issues.apache.org/jira/browse/CALCITE-2435
>             Project: Calcite
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 1.17.0
>            Reporter: Vladimir Sitnikov
>            Assignee: Julian Hyde
>            Priority: Major
>
> Current SqlTestFactory/DelegatingSqlTestFactory is hard to reason about, and it is hard to extend/cache properly.
> There are three key changes here:
> 1. Rename DefaultSqlTestFactory to SqlTestFactory. SqlTestFactory was an interface, however it has a single viable implementation, so it makes little sense to keep it as is.
> 2. Move MockCatalogReader.init and MockCatalogReader.init2 to MockCatalogReaderSimple and MockCatalogReaderExtended
> 3. Move MockCatalogReader to its own package, and split several inner classes to a top-level ones.
> 4. Replace usages



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)