You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Michael Smith (Code Review)" <ge...@cloudera.org> on 2024/03/28 18:21:37 UTC
[Impala-ASF-CR] IMPALA-12540: (Fixup) Add EventSequence arg to load
Michael Smith has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21222
Change subject: IMPALA-12540: (Fixup) Add EventSequence arg to load
......................................................................
IMPALA-12540: (Fixup) Add EventSequence arg to load
Adds a new argument from IMPALA-12443 to Table#load.
Change-Id: I46185e9c0095cc470178e0d2d45d10a1803bff99
---
M fe/src/main/java/org/apache/impala/catalog/SystemTable.java
1 file changed, 3 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/22/21222/1
--
To view, visit http://gerrit.cloudera.org:8080/21222
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I46185e9c0095cc470178e0d2d45d10a1803bff99
Gerrit-Change-Number: 21222
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
[Impala-ASF-CR] IMPALA-12540: (Fixup) Add EventSequence arg to load
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21222 )
Change subject: IMPALA-12540: (Fixup) Add EventSequence arg to load
......................................................................
IMPALA-12540: (Fixup) Add EventSequence arg to load
Adds a new argument from IMPALA-12443 to Table#load.
Change-Id: I46185e9c0095cc470178e0d2d45d10a1803bff99
Reviewed-on: http://gerrit.cloudera.org:8080/21222
Reviewed-by: Wenzhe Zhou <wz...@cloudera.com>
Reviewed-by: Jason Fehr <jf...@cloudera.com>
Tested-by: Michael Smith <mi...@cloudera.com>
---
M fe/src/main/java/org/apache/impala/catalog/SystemTable.java
1 file changed, 3 insertions(+), 2 deletions(-)
Approvals:
Wenzhe Zhou: Looks good to me, approved
Jason Fehr: Looks good to me, but someone else must approve
Michael Smith: Verified
--
To view, visit http://gerrit.cloudera.org:8080/21222
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I46185e9c0095cc470178e0d2d45d10a1803bff99
Gerrit-Change-Number: 21222
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
[Impala-ASF-CR] IMPALA-12540: (Fixup) Add EventSequence arg to load
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21222 )
Change subject: IMPALA-12540: (Fixup) Add EventSequence arg to load
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/10458/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/21222
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I46185e9c0095cc470178e0d2d45d10a1803bff99
Gerrit-Change-Number: 21222
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 28 Mar 2024 18:22:12 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12540: (Fixup) Add EventSequence arg to load
Posted by "Jason Fehr (Code Review)" <ge...@cloudera.org>.
Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/21222 )
Change subject: IMPALA-12540: (Fixup) Add EventSequence arg to load
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/21222
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I46185e9c0095cc470178e0d2d45d10a1803bff99
Gerrit-Change-Number: 21222
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Thu, 28 Mar 2024 18:24:21 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12540: (Fixup) Add EventSequence arg to load
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21222 )
Change subject: IMPALA-12540: (Fixup) Add EventSequence arg to load
......................................................................
Patch Set 1: Verified+1
I'm going to merge this so builds aren't broken. If there are tests that also need fixed, I'll address them in a later patch.
--
To view, visit http://gerrit.cloudera.org:8080/21222
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I46185e9c0095cc470178e0d2d45d10a1803bff99
Gerrit-Change-Number: 21222
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Thu, 28 Mar 2024 18:41:23 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12540: (Fixup) Add EventSequence arg to load
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21222 )
Change subject: IMPALA-12540: (Fixup) Add EventSequence arg to load
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/21222
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I46185e9c0095cc470178e0d2d45d10a1803bff99
Gerrit-Change-Number: 21222
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Thu, 28 Mar 2024 23:34:47 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12540: (Fixup) Add EventSequence arg to load
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21222 )
Change subject: IMPALA-12540: (Fixup) Add EventSequence arg to load
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/15721/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/21222
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I46185e9c0095cc470178e0d2d45d10a1803bff99
Gerrit-Change-Number: 21222
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Thu, 28 Mar 2024 18:40:20 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12540: (Fixup) Add EventSequence arg to load
Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/21222 )
Change subject: IMPALA-12540: (Fixup) Add EventSequence arg to load
......................................................................
Patch Set 1: Code-Review+2
Tried same code change on local machine.
--
To view, visit http://gerrit.cloudera.org:8080/21222
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I46185e9c0095cc470178e0d2d45d10a1803bff99
Gerrit-Change-Number: 21222
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Thu, 28 Mar 2024 18:23:06 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12540: (Fixup) Add EventSequence arg to load
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21222 )
Change subject: IMPALA-12540: (Fixup) Add EventSequence arg to load
......................................................................
Patch Set 1:
Now based on latest commits, so running test suite as well.
--
To view, visit http://gerrit.cloudera.org:8080/21222
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I46185e9c0095cc470178e0d2d45d10a1803bff99
Gerrit-Change-Number: 21222
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 28 Mar 2024 18:22:41 +0000
Gerrit-HasComments: No