[GitHub] [beam] TheNeuralBit commented on a change in pull request #16319: [BEAM-13430] Upgrade beam to gradle 7.3.2

[GitBox <gi...@apache.org>]

TheNeuralBit commented on a change in pull request #16319:
URL: https://github.com/apache/beam/pull/16319#discussion_r774228885



##########
File path: runners/spark/job-server/spark_job_server.gradle
##########
@@ -52,9 +52,9 @@ configurations.all {
 dependencies {
   implementation project(sparkRunnerProject)
   permitUnusedDeclared project(sparkRunnerProject)
-  implementation project(path: sparkRunnerProject, configuration: "compileOnly")
+  implementation project(sparkRunnerProject)
   validatesPortableRunner project(path: sparkRunnerProject, configuration: "testRuntimeMigration")
-  validatesPortableRunner project(path: sparkRunnerProject, configuration: "compileOnly")

Review comment:
       Same question here, and in spark_runner

##########
File path: buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
##########
@@ -1244,7 +1237,7 @@ class BeamModulePlugin implements Plugin<Project> {
 
           project.dependencies {
             shadowTestRuntimeClasspath it.project(path: project.path, configuration: "shadowTest")
-            shadowTestRuntimeClasspath it.project(path: project.path, configuration: "compileOnly")

Review comment:
       What is the impact of this change, will this affect the artifacts we publish?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org