[GitHub] [incubator-doris] chaoyli commented on a change in pull request #2134: Fix default value column bug

[GitBox <gi...@apache.org>]

chaoyli commented on a change in pull request #2134: Fix default value column bug
URL: https://github.com/apache/incubator-doris/pull/2134#discussion_r342466930
 
 

 ##########
 File path: be/src/olap/rowset/segment_v2/column_reader.cpp
 ##########
 @@ -483,16 +483,24 @@ Status FileColumnIterator::_read_page(const OrdinalPageIndexIterator& iter, Pars
 Status DefaultValueColumnIterator::init(const ColumnIteratorOptions& opts) {
     _opts = opts;
     // be consistent with segment v1
-    if (_default_value == "NULL" && _is_nullable) {
+    if (_has_default_value) {
 
 Review comment:
   This function is hard to understand.
   I think you add some annotation may be better.
   Or change the if/else structure. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org