You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2023/03/09 19:18:30 UTC
[GitHub] [arrow-datafusion] alamb opened a new pull request, #5536: Avoid circular(ish) dependency parquet-test-utils on datafusion, try 2
alamb opened a new pull request, #5536:
URL: https://github.com/apache/arrow-datafusion/pull/5536
# Which issue does this PR close?
Closes https://github.com/apache/arrow-datafusion/issues/5453
(see alternate approach in https://github.com/apache/arrow-datafusion/pull/5506)
# Rationale for this change
Improve the DataFusion development cycle time by `cargo test -p datafusion` having to compile datafusion lib, then the parquet-test-utils, and then the tests.
# What changes are included in this PR?
Remove `parquet-test-utils` crate entirely and put `ParquetTestFile` into `datafusion::test_utils`
# Are these changes tested?
Yes (existing tests)
# Are there any user-facing changes?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #5536: Avoid circular(ish) dependency parquet-test-utils on datafusion, try 2
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #5536:
URL: https://github.com/apache/arrow-datafusion/pull/5536#issuecomment-1464967666
It appears that using parquet-test-utils was masking a breakage in the feature flag for regular expressions. I fixed it in https://github.com/apache/arrow-datafusion/pull/5536/commits/193971a99e39b437447da36d2fb971c2dea1c690
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] tustvold commented on pull request #5536: Avoid circular(ish) dependency parquet-test-utils on datafusion, try 2
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on PR #5536:
URL: https://github.com/apache/arrow-datafusion/pull/5536#issuecomment-1464554587
I do wonder if the test_util module should be behind some feature flag, but definitely not a blocker to this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb merged pull request #5536: Avoid circular(ish) dependency parquet-test-utils on datafusion, try 2
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #5536:
URL: https://github.com/apache/arrow-datafusion/pull/5536
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #5536: Avoid circular(ish) dependency parquet-test-utils on datafusion, try 2
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #5536:
URL: https://github.com/apache/arrow-datafusion/pull/5536#issuecomment-1464897563
> I do wonder if the test_util module should be behind some feature flag, but definitely not a blocker to this PR
Yeah, I agree that would probably be a good idea; Let's do it if test_utils grows too big
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] ursabot commented on pull request #5536: Avoid circular(ish) dependency parquet-test-utils on datafusion, try 2
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #5536:
URL: https://github.com/apache/arrow-datafusion/pull/5536#issuecomment-1465176759
Benchmark runs are scheduled for baseline = ecbc843a1a8c38b2466748bc92a6e22ce08d51ed and contender = 5423ba0785035911680fdc27f8033fb7b31a577b. 5423ba0785035911680fdc27f8033fb7b31a577b is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/39861901d35c4ab2b1bb508597923b7c...46873b668f7b4b629993a79a07b41f21/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/cdd69c7aad0e415998fe813bcf32b6c7...857d7f8214344968a204c88fb2d7c32f/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/9b59219bfd804324853017d6a6068fab...b9d8dc1a24784ed988bd495089525edc/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/c77d8ee360714fe9b60a2dd43cb4cf4e...bd795f0e30934279a7b39ee62d774eb5/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org